diff options
author | Pavel Emelyanov <xemul@openvz.org> | 2007-10-19 02:40:40 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-19 14:53:43 -0400 |
commit | ba25f9dcc4ea6e30839fcab5a5516f2176d5bfed (patch) | |
tree | 3123c03b25dd5c0cd24b6ab4fc16731217838157 /lib | |
parent | 9a2e70572e94e21e7ec4186702d045415422bda0 (diff) |
Use helpers to obtain task pid in printks
The task_struct->pid member is going to be deprecated, so start
using the helpers (task_pid_nr/task_pid_vnr/task_pid_nr_ns) in
the kernel.
The first thing to start with is the pid, printed to dmesg - in
this case we may safely use task_pid_nr(). Besides, printks produce
more (much more) than a half of all the explicit pid usage.
[akpm@linux-foundation.org: git-drm went and changed lots of stuff]
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: Dave Airlie <airlied@linux.ie>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/spinlock_debug.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/spinlock_debug.c b/lib/spinlock_debug.c index 479fd462eaa9..9c4b0256490b 100644 --- a/lib/spinlock_debug.c +++ b/lib/spinlock_debug.c | |||
@@ -60,12 +60,12 @@ static void spin_bug(spinlock_t *lock, const char *msg) | |||
60 | owner = lock->owner; | 60 | owner = lock->owner; |
61 | printk(KERN_EMERG "BUG: spinlock %s on CPU#%d, %s/%d\n", | 61 | printk(KERN_EMERG "BUG: spinlock %s on CPU#%d, %s/%d\n", |
62 | msg, raw_smp_processor_id(), | 62 | msg, raw_smp_processor_id(), |
63 | current->comm, current->pid); | 63 | current->comm, task_pid_nr(current)); |
64 | printk(KERN_EMERG " lock: %p, .magic: %08x, .owner: %s/%d, " | 64 | printk(KERN_EMERG " lock: %p, .magic: %08x, .owner: %s/%d, " |
65 | ".owner_cpu: %d\n", | 65 | ".owner_cpu: %d\n", |
66 | lock, lock->magic, | 66 | lock, lock->magic, |
67 | owner ? owner->comm : "<none>", | 67 | owner ? owner->comm : "<none>", |
68 | owner ? owner->pid : -1, | 68 | owner ? task_pid_nr(owner) : -1, |
69 | lock->owner_cpu); | 69 | lock->owner_cpu); |
70 | dump_stack(); | 70 | dump_stack(); |
71 | } | 71 | } |
@@ -116,7 +116,7 @@ static void __spin_lock_debug(spinlock_t *lock) | |||
116 | printk(KERN_EMERG "BUG: spinlock lockup on CPU#%d, " | 116 | printk(KERN_EMERG "BUG: spinlock lockup on CPU#%d, " |
117 | "%s/%d, %p\n", | 117 | "%s/%d, %p\n", |
118 | raw_smp_processor_id(), current->comm, | 118 | raw_smp_processor_id(), current->comm, |
119 | current->pid, lock); | 119 | task_pid_nr(current), lock); |
120 | dump_stack(); | 120 | dump_stack(); |
121 | #ifdef CONFIG_SMP | 121 | #ifdef CONFIG_SMP |
122 | trigger_all_cpu_backtrace(); | 122 | trigger_all_cpu_backtrace(); |
@@ -161,7 +161,7 @@ static void rwlock_bug(rwlock_t *lock, const char *msg) | |||
161 | 161 | ||
162 | printk(KERN_EMERG "BUG: rwlock %s on CPU#%d, %s/%d, %p\n", | 162 | printk(KERN_EMERG "BUG: rwlock %s on CPU#%d, %s/%d, %p\n", |
163 | msg, raw_smp_processor_id(), current->comm, | 163 | msg, raw_smp_processor_id(), current->comm, |
164 | current->pid, lock); | 164 | task_pid_nr(current), lock); |
165 | dump_stack(); | 165 | dump_stack(); |
166 | } | 166 | } |
167 | 167 | ||