diff options
author | Christoph Lameter <clameter@sgi.com> | 2007-10-17 02:25:51 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-17 11:42:45 -0400 |
commit | 4ba9b9d0ba0a49d91fa6417c7510ee36f48cf957 (patch) | |
tree | 191b4f45f926e44b882b1e87a9a85dc12230b892 /lib | |
parent | b811c202a0edadaac7242ab834fe7ba409978ae7 (diff) |
Slab API: remove useless ctor parameter and reorder parameters
Slab constructors currently have a flags parameter that is never used. And
the order of the arguments is opposite to other slab functions. The object
pointer is placed before the kmem_cache pointer.
Convert
ctor(void *object, struct kmem_cache *s, unsigned long flags)
to
ctor(struct kmem_cache *s, void *object)
throughout the kernel
[akpm@linux-foundation.org: coupla fixes]
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/idr.c | 3 | ||||
-rw-r--r-- | lib/radix-tree.c | 2 |
2 files changed, 2 insertions, 3 deletions
@@ -580,8 +580,7 @@ void *idr_replace(struct idr *idp, void *ptr, int id) | |||
580 | } | 580 | } |
581 | EXPORT_SYMBOL(idr_replace); | 581 | EXPORT_SYMBOL(idr_replace); |
582 | 582 | ||
583 | static void idr_cache_ctor(void * idr_layer, struct kmem_cache *idr_layer_cache, | 583 | static void idr_cache_ctor(struct kmem_cache *idr_layer_cache, void *idr_layer) |
584 | unsigned long flags) | ||
585 | { | 584 | { |
586 | memset(idr_layer, 0, sizeof(struct idr_layer)); | 585 | memset(idr_layer, 0, sizeof(struct idr_layer)); |
587 | } | 586 | } |
diff --git a/lib/radix-tree.c b/lib/radix-tree.c index 6b26f9d39800..53fd44d78716 100644 --- a/lib/radix-tree.c +++ b/lib/radix-tree.c | |||
@@ -1042,7 +1042,7 @@ int radix_tree_tagged(struct radix_tree_root *root, unsigned int tag) | |||
1042 | EXPORT_SYMBOL(radix_tree_tagged); | 1042 | EXPORT_SYMBOL(radix_tree_tagged); |
1043 | 1043 | ||
1044 | static void | 1044 | static void |
1045 | radix_tree_node_ctor(void *node, struct kmem_cache *cachep, unsigned long flags) | 1045 | radix_tree_node_ctor(struct kmem_cache *cachep, void *node) |
1046 | { | 1046 | { |
1047 | memset(node, 0, sizeof(struct radix_tree_node)); | 1047 | memset(node, 0, sizeof(struct radix_tree_node)); |
1048 | } | 1048 | } |