diff options
author | Ingo Molnar <mingo@elte.hu> | 2009-10-01 05:20:33 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-10-01 05:20:48 -0400 |
commit | 0aa73ba1c4e1ad1d51a29e0df95ccd9f746918b6 (patch) | |
tree | f0714ddcd02812b4fbe3b5405df9e4068f5587e2 /lib | |
parent | 925936ebf35a95c290e010b784c962164e6728f3 (diff) | |
parent | 33974093c024f08caadd2fc71a83bd811ed1831d (diff) |
Merge branch 'tracing/urgent' into tracing/core
Merge reason: Pick up latest fixes and update to latest upstream.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Kconfig.debug | 8 | ||||
-rw-r--r-- | lib/Kconfig.kmemcheck | 3 | ||||
-rw-r--r-- | lib/decompress_inflate.c | 8 | ||||
-rw-r--r-- | lib/decompress_unlzma.c | 10 | ||||
-rw-r--r-- | lib/flex_array.c | 121 | ||||
-rw-r--r-- | lib/vsprintf.c | 39 | ||||
-rw-r--r-- | lib/zlib_deflate/deflate.c | 4 |
7 files changed, 137 insertions, 56 deletions
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index d57b12f59c8c..891155817bc6 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug | |||
@@ -50,6 +50,14 @@ config MAGIC_SYSRQ | |||
50 | keys are documented in <file:Documentation/sysrq.txt>. Don't say Y | 50 | keys are documented in <file:Documentation/sysrq.txt>. Don't say Y |
51 | unless you really know what this hack does. | 51 | unless you really know what this hack does. |
52 | 52 | ||
53 | config STRIP_ASM_SYMS | ||
54 | bool "Strip assembler-generated symbols during link" | ||
55 | default n | ||
56 | help | ||
57 | Strip internal assembler-generated symbols during a link (symbols | ||
58 | that look like '.Lxxx') so they don't pollute the output of | ||
59 | get_wchan() and suchlike. | ||
60 | |||
53 | config UNUSED_SYMBOLS | 61 | config UNUSED_SYMBOLS |
54 | bool "Enable unused/obsolete exported symbols" | 62 | bool "Enable unused/obsolete exported symbols" |
55 | default y if X86 | 63 | default y if X86 |
diff --git a/lib/Kconfig.kmemcheck b/lib/Kconfig.kmemcheck index 603c81b66549..846e039a86b4 100644 --- a/lib/Kconfig.kmemcheck +++ b/lib/Kconfig.kmemcheck | |||
@@ -1,6 +1,8 @@ | |||
1 | config HAVE_ARCH_KMEMCHECK | 1 | config HAVE_ARCH_KMEMCHECK |
2 | bool | 2 | bool |
3 | 3 | ||
4 | if HAVE_ARCH_KMEMCHECK | ||
5 | |||
4 | menuconfig KMEMCHECK | 6 | menuconfig KMEMCHECK |
5 | bool "kmemcheck: trap use of uninitialized memory" | 7 | bool "kmemcheck: trap use of uninitialized memory" |
6 | depends on DEBUG_KERNEL | 8 | depends on DEBUG_KERNEL |
@@ -89,3 +91,4 @@ config KMEMCHECK_BITOPS_OK | |||
89 | accesses where not all the bits are initialized at the same time. | 91 | accesses where not all the bits are initialized at the same time. |
90 | This may also hide some real bugs. | 92 | This may also hide some real bugs. |
91 | 93 | ||
94 | endif | ||
diff --git a/lib/decompress_inflate.c b/lib/decompress_inflate.c index 68dfce59c1b8..fc686c7a0a0d 100644 --- a/lib/decompress_inflate.c +++ b/lib/decompress_inflate.c | |||
@@ -27,6 +27,11 @@ | |||
27 | 27 | ||
28 | #define GZIP_IOBUF_SIZE (16*1024) | 28 | #define GZIP_IOBUF_SIZE (16*1024) |
29 | 29 | ||
30 | static int nofill(void *buffer, unsigned int len) | ||
31 | { | ||
32 | return -1; | ||
33 | } | ||
34 | |||
30 | /* Included from initramfs et al code */ | 35 | /* Included from initramfs et al code */ |
31 | STATIC int INIT gunzip(unsigned char *buf, int len, | 36 | STATIC int INIT gunzip(unsigned char *buf, int len, |
32 | int(*fill)(void*, unsigned int), | 37 | int(*fill)(void*, unsigned int), |
@@ -76,6 +81,9 @@ STATIC int INIT gunzip(unsigned char *buf, int len, | |||
76 | goto gunzip_nomem4; | 81 | goto gunzip_nomem4; |
77 | } | 82 | } |
78 | 83 | ||
84 | if (!fill) | ||
85 | fill = nofill; | ||
86 | |||
79 | if (len == 0) | 87 | if (len == 0) |
80 | len = fill(zbuf, GZIP_IOBUF_SIZE); | 88 | len = fill(zbuf, GZIP_IOBUF_SIZE); |
81 | 89 | ||
diff --git a/lib/decompress_unlzma.c b/lib/decompress_unlzma.c index 0b954e04bd30..ca82fde81c8f 100644 --- a/lib/decompress_unlzma.c +++ b/lib/decompress_unlzma.c | |||
@@ -82,6 +82,11 @@ struct rc { | |||
82 | #define RC_MODEL_TOTAL_BITS 11 | 82 | #define RC_MODEL_TOTAL_BITS 11 |
83 | 83 | ||
84 | 84 | ||
85 | static int nofill(void *buffer, unsigned int len) | ||
86 | { | ||
87 | return -1; | ||
88 | } | ||
89 | |||
85 | /* Called twice: once at startup and once in rc_normalize() */ | 90 | /* Called twice: once at startup and once in rc_normalize() */ |
86 | static void INIT rc_read(struct rc *rc) | 91 | static void INIT rc_read(struct rc *rc) |
87 | { | 92 | { |
@@ -97,7 +102,10 @@ static inline void INIT rc_init(struct rc *rc, | |||
97 | int (*fill)(void*, unsigned int), | 102 | int (*fill)(void*, unsigned int), |
98 | char *buffer, int buffer_size) | 103 | char *buffer, int buffer_size) |
99 | { | 104 | { |
100 | rc->fill = fill; | 105 | if (fill) |
106 | rc->fill = fill; | ||
107 | else | ||
108 | rc->fill = nofill; | ||
101 | rc->buffer = (uint8_t *)buffer; | 109 | rc->buffer = (uint8_t *)buffer; |
102 | rc->buffer_size = buffer_size; | 110 | rc->buffer_size = buffer_size; |
103 | rc->buffer_end = rc->buffer + rc->buffer_size; | 111 | rc->buffer_end = rc->buffer + rc->buffer_size; |
diff --git a/lib/flex_array.c b/lib/flex_array.c index 7baed2fc3bc8..66eef2e4483e 100644 --- a/lib/flex_array.c +++ b/lib/flex_array.c | |||
@@ -28,23 +28,6 @@ struct flex_array_part { | |||
28 | char elements[FLEX_ARRAY_PART_SIZE]; | 28 | char elements[FLEX_ARRAY_PART_SIZE]; |
29 | }; | 29 | }; |
30 | 30 | ||
31 | static inline int __elements_per_part(int element_size) | ||
32 | { | ||
33 | return FLEX_ARRAY_PART_SIZE / element_size; | ||
34 | } | ||
35 | |||
36 | static inline int bytes_left_in_base(void) | ||
37 | { | ||
38 | int element_offset = offsetof(struct flex_array, parts); | ||
39 | int bytes_left = FLEX_ARRAY_BASE_SIZE - element_offset; | ||
40 | return bytes_left; | ||
41 | } | ||
42 | |||
43 | static inline int nr_base_part_ptrs(void) | ||
44 | { | ||
45 | return bytes_left_in_base() / sizeof(struct flex_array_part *); | ||
46 | } | ||
47 | |||
48 | /* | 31 | /* |
49 | * If a user requests an allocation which is small | 32 | * If a user requests an allocation which is small |
50 | * enough, we may simply use the space in the | 33 | * enough, we may simply use the space in the |
@@ -54,7 +37,7 @@ static inline int nr_base_part_ptrs(void) | |||
54 | static inline int elements_fit_in_base(struct flex_array *fa) | 37 | static inline int elements_fit_in_base(struct flex_array *fa) |
55 | { | 38 | { |
56 | int data_size = fa->element_size * fa->total_nr_elements; | 39 | int data_size = fa->element_size * fa->total_nr_elements; |
57 | if (data_size <= bytes_left_in_base()) | 40 | if (data_size <= FLEX_ARRAY_BASE_BYTES_LEFT) |
58 | return 1; | 41 | return 1; |
59 | return 0; | 42 | return 0; |
60 | } | 43 | } |
@@ -63,6 +46,7 @@ static inline int elements_fit_in_base(struct flex_array *fa) | |||
63 | * flex_array_alloc - allocate a new flexible array | 46 | * flex_array_alloc - allocate a new flexible array |
64 | * @element_size: the size of individual elements in the array | 47 | * @element_size: the size of individual elements in the array |
65 | * @total: total number of elements that this should hold | 48 | * @total: total number of elements that this should hold |
49 | * @flags: page allocation flags to use for base array | ||
66 | * | 50 | * |
67 | * Note: all locking must be provided by the caller. | 51 | * Note: all locking must be provided by the caller. |
68 | * | 52 | * |
@@ -103,7 +87,8 @@ struct flex_array *flex_array_alloc(int element_size, unsigned int total, | |||
103 | gfp_t flags) | 87 | gfp_t flags) |
104 | { | 88 | { |
105 | struct flex_array *ret; | 89 | struct flex_array *ret; |
106 | int max_size = nr_base_part_ptrs() * __elements_per_part(element_size); | 90 | int max_size = FLEX_ARRAY_NR_BASE_PTRS * |
91 | FLEX_ARRAY_ELEMENTS_PER_PART(element_size); | ||
107 | 92 | ||
108 | /* max_size will end up 0 if element_size > PAGE_SIZE */ | 93 | /* max_size will end up 0 if element_size > PAGE_SIZE */ |
109 | if (total > max_size) | 94 | if (total > max_size) |
@@ -113,17 +98,21 @@ struct flex_array *flex_array_alloc(int element_size, unsigned int total, | |||
113 | return NULL; | 98 | return NULL; |
114 | ret->element_size = element_size; | 99 | ret->element_size = element_size; |
115 | ret->total_nr_elements = total; | 100 | ret->total_nr_elements = total; |
101 | if (elements_fit_in_base(ret) && !(flags & __GFP_ZERO)) | ||
102 | memset(ret->parts[0], FLEX_ARRAY_FREE, | ||
103 | FLEX_ARRAY_BASE_BYTES_LEFT); | ||
116 | return ret; | 104 | return ret; |
117 | } | 105 | } |
118 | 106 | ||
119 | static int fa_element_to_part_nr(struct flex_array *fa, | 107 | static int fa_element_to_part_nr(struct flex_array *fa, |
120 | unsigned int element_nr) | 108 | unsigned int element_nr) |
121 | { | 109 | { |
122 | return element_nr / __elements_per_part(fa->element_size); | 110 | return element_nr / FLEX_ARRAY_ELEMENTS_PER_PART(fa->element_size); |
123 | } | 111 | } |
124 | 112 | ||
125 | /** | 113 | /** |
126 | * flex_array_free_parts - just free the second-level pages | 114 | * flex_array_free_parts - just free the second-level pages |
115 | * @fa: the flex array from which to free parts | ||
127 | * | 116 | * |
128 | * This is to be used in cases where the base 'struct flex_array' | 117 | * This is to be used in cases where the base 'struct flex_array' |
129 | * has been statically allocated and should not be free. | 118 | * has been statically allocated and should not be free. |
@@ -131,11 +120,10 @@ static int fa_element_to_part_nr(struct flex_array *fa, | |||
131 | void flex_array_free_parts(struct flex_array *fa) | 120 | void flex_array_free_parts(struct flex_array *fa) |
132 | { | 121 | { |
133 | int part_nr; | 122 | int part_nr; |
134 | int max_part = nr_base_part_ptrs(); | ||
135 | 123 | ||
136 | if (elements_fit_in_base(fa)) | 124 | if (elements_fit_in_base(fa)) |
137 | return; | 125 | return; |
138 | for (part_nr = 0; part_nr < max_part; part_nr++) | 126 | for (part_nr = 0; part_nr < FLEX_ARRAY_NR_BASE_PTRS; part_nr++) |
139 | kfree(fa->parts[part_nr]); | 127 | kfree(fa->parts[part_nr]); |
140 | } | 128 | } |
141 | 129 | ||
@@ -150,7 +138,8 @@ static unsigned int index_inside_part(struct flex_array *fa, | |||
150 | { | 138 | { |
151 | unsigned int part_offset; | 139 | unsigned int part_offset; |
152 | 140 | ||
153 | part_offset = element_nr % __elements_per_part(fa->element_size); | 141 | part_offset = element_nr % |
142 | FLEX_ARRAY_ELEMENTS_PER_PART(fa->element_size); | ||
154 | return part_offset * fa->element_size; | 143 | return part_offset * fa->element_size; |
155 | } | 144 | } |
156 | 145 | ||
@@ -159,15 +148,12 @@ __fa_get_part(struct flex_array *fa, int part_nr, gfp_t flags) | |||
159 | { | 148 | { |
160 | struct flex_array_part *part = fa->parts[part_nr]; | 149 | struct flex_array_part *part = fa->parts[part_nr]; |
161 | if (!part) { | 150 | if (!part) { |
162 | /* | 151 | part = kmalloc(sizeof(struct flex_array_part), flags); |
163 | * This leaves the part pages uninitialized | ||
164 | * and with potentially random data, just | ||
165 | * as if the user had kmalloc()'d the whole. | ||
166 | * __GFP_ZERO can be used to zero it. | ||
167 | */ | ||
168 | part = kmalloc(FLEX_ARRAY_PART_SIZE, flags); | ||
169 | if (!part) | 152 | if (!part) |
170 | return NULL; | 153 | return NULL; |
154 | if (!(flags & __GFP_ZERO)) | ||
155 | memset(part, FLEX_ARRAY_FREE, | ||
156 | sizeof(struct flex_array_part)); | ||
171 | fa->parts[part_nr] = part; | 157 | fa->parts[part_nr] = part; |
172 | } | 158 | } |
173 | return part; | 159 | return part; |
@@ -175,9 +161,12 @@ __fa_get_part(struct flex_array *fa, int part_nr, gfp_t flags) | |||
175 | 161 | ||
176 | /** | 162 | /** |
177 | * flex_array_put - copy data into the array at @element_nr | 163 | * flex_array_put - copy data into the array at @element_nr |
178 | * @src: address of data to copy into the array | 164 | * @fa: the flex array to copy data into |
179 | * @element_nr: index of the position in which to insert | 165 | * @element_nr: index of the position in which to insert |
180 | * the new element. | 166 | * the new element. |
167 | * @src: address of data to copy into the array | ||
168 | * @flags: page allocation flags to use for array expansion | ||
169 | * | ||
181 | * | 170 | * |
182 | * Note that this *copies* the contents of @src into | 171 | * Note that this *copies* the contents of @src into |
183 | * the array. If you are trying to store an array of | 172 | * the array. If you are trying to store an array of |
@@ -207,9 +196,38 @@ int flex_array_put(struct flex_array *fa, unsigned int element_nr, void *src, | |||
207 | } | 196 | } |
208 | 197 | ||
209 | /** | 198 | /** |
199 | * flex_array_clear - clear element in array at @element_nr | ||
200 | * @fa: the flex array of the element. | ||
201 | * @element_nr: index of the position to clear. | ||
202 | * | ||
203 | * Locking must be provided by the caller. | ||
204 | */ | ||
205 | int flex_array_clear(struct flex_array *fa, unsigned int element_nr) | ||
206 | { | ||
207 | int part_nr = fa_element_to_part_nr(fa, element_nr); | ||
208 | struct flex_array_part *part; | ||
209 | void *dst; | ||
210 | |||
211 | if (element_nr >= fa->total_nr_elements) | ||
212 | return -ENOSPC; | ||
213 | if (elements_fit_in_base(fa)) | ||
214 | part = (struct flex_array_part *)&fa->parts[0]; | ||
215 | else { | ||
216 | part = fa->parts[part_nr]; | ||
217 | if (!part) | ||
218 | return -EINVAL; | ||
219 | } | ||
220 | dst = &part->elements[index_inside_part(fa, element_nr)]; | ||
221 | memset(dst, FLEX_ARRAY_FREE, fa->element_size); | ||
222 | return 0; | ||
223 | } | ||
224 | |||
225 | /** | ||
210 | * flex_array_prealloc - guarantee that array space exists | 226 | * flex_array_prealloc - guarantee that array space exists |
227 | * @fa: the flex array for which to preallocate parts | ||
211 | * @start: index of first array element for which space is allocated | 228 | * @start: index of first array element for which space is allocated |
212 | * @end: index of last (inclusive) element for which space is allocated | 229 | * @end: index of last (inclusive) element for which space is allocated |
230 | * @flags: page allocation flags | ||
213 | * | 231 | * |
214 | * This will guarantee that no future calls to flex_array_put() | 232 | * This will guarantee that no future calls to flex_array_put() |
215 | * will allocate memory. It can be used if you are expecting to | 233 | * will allocate memory. It can be used if you are expecting to |
@@ -242,6 +260,7 @@ int flex_array_prealloc(struct flex_array *fa, unsigned int start, | |||
242 | 260 | ||
243 | /** | 261 | /** |
244 | * flex_array_get - pull data back out of the array | 262 | * flex_array_get - pull data back out of the array |
263 | * @fa: the flex array from which to extract data | ||
245 | * @element_nr: index of the element to fetch from the array | 264 | * @element_nr: index of the element to fetch from the array |
246 | * | 265 | * |
247 | * Returns a pointer to the data at index @element_nr. Note | 266 | * Returns a pointer to the data at index @element_nr. Note |
@@ -266,3 +285,43 @@ void *flex_array_get(struct flex_array *fa, unsigned int element_nr) | |||
266 | } | 285 | } |
267 | return &part->elements[index_inside_part(fa, element_nr)]; | 286 | return &part->elements[index_inside_part(fa, element_nr)]; |
268 | } | 287 | } |
288 | |||
289 | static int part_is_free(struct flex_array_part *part) | ||
290 | { | ||
291 | int i; | ||
292 | |||
293 | for (i = 0; i < sizeof(struct flex_array_part); i++) | ||
294 | if (part->elements[i] != FLEX_ARRAY_FREE) | ||
295 | return 0; | ||
296 | return 1; | ||
297 | } | ||
298 | |||
299 | /** | ||
300 | * flex_array_shrink - free unused second-level pages | ||
301 | * @fa: the flex array to shrink | ||
302 | * | ||
303 | * Frees all second-level pages that consist solely of unused | ||
304 | * elements. Returns the number of pages freed. | ||
305 | * | ||
306 | * Locking must be provided by the caller. | ||
307 | */ | ||
308 | int flex_array_shrink(struct flex_array *fa) | ||
309 | { | ||
310 | struct flex_array_part *part; | ||
311 | int part_nr; | ||
312 | int ret = 0; | ||
313 | |||
314 | if (elements_fit_in_base(fa)) | ||
315 | return ret; | ||
316 | for (part_nr = 0; part_nr < FLEX_ARRAY_NR_BASE_PTRS; part_nr++) { | ||
317 | part = fa->parts[part_nr]; | ||
318 | if (!part) | ||
319 | continue; | ||
320 | if (part_is_free(part)) { | ||
321 | fa->parts[part_nr] = NULL; | ||
322 | kfree(part); | ||
323 | ret++; | ||
324 | } | ||
325 | } | ||
326 | return ret; | ||
327 | } | ||
diff --git a/lib/vsprintf.c b/lib/vsprintf.c index d320c1816a7b..b91839e9e892 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c | |||
@@ -671,7 +671,7 @@ static char *ip4_string(char *p, const u8 *addr, bool leading_zeros) | |||
671 | return p; | 671 | return p; |
672 | } | 672 | } |
673 | 673 | ||
674 | static char *ip6_compressed_string(char *p, const struct in6_addr *addr) | 674 | static char *ip6_compressed_string(char *p, const char *addr) |
675 | { | 675 | { |
676 | int i; | 676 | int i; |
677 | int j; | 677 | int j; |
@@ -683,7 +683,12 @@ static char *ip6_compressed_string(char *p, const struct in6_addr *addr) | |||
683 | u8 hi; | 683 | u8 hi; |
684 | u8 lo; | 684 | u8 lo; |
685 | bool needcolon = false; | 685 | bool needcolon = false; |
686 | bool useIPv4 = ipv6_addr_v4mapped(addr) || ipv6_addr_is_isatap(addr); | 686 | bool useIPv4; |
687 | struct in6_addr in6; | ||
688 | |||
689 | memcpy(&in6, addr, sizeof(struct in6_addr)); | ||
690 | |||
691 | useIPv4 = ipv6_addr_v4mapped(&in6) || ipv6_addr_is_isatap(&in6); | ||
687 | 692 | ||
688 | memset(zerolength, 0, sizeof(zerolength)); | 693 | memset(zerolength, 0, sizeof(zerolength)); |
689 | 694 | ||
@@ -695,7 +700,7 @@ static char *ip6_compressed_string(char *p, const struct in6_addr *addr) | |||
695 | /* find position of longest 0 run */ | 700 | /* find position of longest 0 run */ |
696 | for (i = 0; i < range; i++) { | 701 | for (i = 0; i < range; i++) { |
697 | for (j = i; j < range; j++) { | 702 | for (j = i; j < range; j++) { |
698 | if (addr->s6_addr16[j] != 0) | 703 | if (in6.s6_addr16[j] != 0) |
699 | break; | 704 | break; |
700 | zerolength[i]++; | 705 | zerolength[i]++; |
701 | } | 706 | } |
@@ -722,7 +727,7 @@ static char *ip6_compressed_string(char *p, const struct in6_addr *addr) | |||
722 | needcolon = false; | 727 | needcolon = false; |
723 | } | 728 | } |
724 | /* hex u16 without leading 0s */ | 729 | /* hex u16 without leading 0s */ |
725 | word = ntohs(addr->s6_addr16[i]); | 730 | word = ntohs(in6.s6_addr16[i]); |
726 | hi = word >> 8; | 731 | hi = word >> 8; |
727 | lo = word & 0xff; | 732 | lo = word & 0xff; |
728 | if (hi) { | 733 | if (hi) { |
@@ -741,19 +746,19 @@ static char *ip6_compressed_string(char *p, const struct in6_addr *addr) | |||
741 | if (useIPv4) { | 746 | if (useIPv4) { |
742 | if (needcolon) | 747 | if (needcolon) |
743 | *p++ = ':'; | 748 | *p++ = ':'; |
744 | p = ip4_string(p, &addr->s6_addr[12], false); | 749 | p = ip4_string(p, &in6.s6_addr[12], false); |
745 | } | 750 | } |
746 | 751 | ||
747 | *p = '\0'; | 752 | *p = '\0'; |
748 | return p; | 753 | return p; |
749 | } | 754 | } |
750 | 755 | ||
751 | static char *ip6_string(char *p, const struct in6_addr *addr, const char *fmt) | 756 | static char *ip6_string(char *p, const char *addr, const char *fmt) |
752 | { | 757 | { |
753 | int i; | 758 | int i; |
754 | for (i = 0; i < 8; i++) { | 759 | for (i = 0; i < 8; i++) { |
755 | p = pack_hex_byte(p, addr->s6_addr[2 * i]); | 760 | p = pack_hex_byte(p, *addr++); |
756 | p = pack_hex_byte(p, addr->s6_addr[2 * i + 1]); | 761 | p = pack_hex_byte(p, *addr++); |
757 | if (fmt[0] == 'I' && i != 7) | 762 | if (fmt[0] == 'I' && i != 7) |
758 | *p++ = ':'; | 763 | *p++ = ':'; |
759 | } | 764 | } |
@@ -768,9 +773,9 @@ static char *ip6_addr_string(char *buf, char *end, const u8 *addr, | |||
768 | char ip6_addr[sizeof("xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:255.255.255.255")]; | 773 | char ip6_addr[sizeof("xxxx:xxxx:xxxx:xxxx:xxxx:xxxx:255.255.255.255")]; |
769 | 774 | ||
770 | if (fmt[0] == 'I' && fmt[2] == 'c') | 775 | if (fmt[0] == 'I' && fmt[2] == 'c') |
771 | ip6_compressed_string(ip6_addr, (const struct in6_addr *)addr); | 776 | ip6_compressed_string(ip6_addr, addr); |
772 | else | 777 | else |
773 | ip6_string(ip6_addr, (const struct in6_addr *)addr, fmt); | 778 | ip6_string(ip6_addr, addr, fmt); |
774 | 779 | ||
775 | return string(buf, end, ip6_addr, spec); | 780 | return string(buf, end, ip6_addr, spec); |
776 | } | 781 | } |
@@ -1092,13 +1097,8 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args) | |||
1092 | 1097 | ||
1093 | /* Reject out-of-range values early. Large positive sizes are | 1098 | /* Reject out-of-range values early. Large positive sizes are |
1094 | used for unknown buffer sizes. */ | 1099 | used for unknown buffer sizes. */ |
1095 | if (unlikely((int) size < 0)) { | 1100 | if (WARN_ON_ONCE((int) size < 0)) |
1096 | /* There can be only one.. */ | ||
1097 | static char warn = 1; | ||
1098 | WARN_ON(warn); | ||
1099 | warn = 0; | ||
1100 | return 0; | 1101 | return 0; |
1101 | } | ||
1102 | 1102 | ||
1103 | str = buf; | 1103 | str = buf; |
1104 | end = buf + size; | 1104 | end = buf + size; |
@@ -1544,13 +1544,8 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf) | |||
1544 | 1544 | ||
1545 | struct printf_spec spec = {0}; | 1545 | struct printf_spec spec = {0}; |
1546 | 1546 | ||
1547 | if (unlikely((int) size < 0)) { | 1547 | if (WARN_ON_ONCE((int) size < 0)) |
1548 | /* There can be only one.. */ | ||
1549 | static char warn = 1; | ||
1550 | WARN_ON(warn); | ||
1551 | warn = 0; | ||
1552 | return 0; | 1548 | return 0; |
1553 | } | ||
1554 | 1549 | ||
1555 | str = buf; | 1550 | str = buf; |
1556 | end = buf + size; | 1551 | end = buf + size; |
diff --git a/lib/zlib_deflate/deflate.c b/lib/zlib_deflate/deflate.c index c3e4a2baf835..46a31e5f49c3 100644 --- a/lib/zlib_deflate/deflate.c +++ b/lib/zlib_deflate/deflate.c | |||
@@ -135,7 +135,7 @@ static const config configuration_table[10] = { | |||
135 | 135 | ||
136 | /* =========================================================================== | 136 | /* =========================================================================== |
137 | * Update a hash value with the given input byte | 137 | * Update a hash value with the given input byte |
138 | * IN assertion: all calls to to UPDATE_HASH are made with consecutive | 138 | * IN assertion: all calls to UPDATE_HASH are made with consecutive |
139 | * input characters, so that a running hash key can be computed from the | 139 | * input characters, so that a running hash key can be computed from the |
140 | * previous key instead of complete recalculation each time. | 140 | * previous key instead of complete recalculation each time. |
141 | */ | 141 | */ |
@@ -146,7 +146,7 @@ static const config configuration_table[10] = { | |||
146 | * Insert string str in the dictionary and set match_head to the previous head | 146 | * Insert string str in the dictionary and set match_head to the previous head |
147 | * of the hash chain (the most recent string with same hash key). Return | 147 | * of the hash chain (the most recent string with same hash key). Return |
148 | * the previous length of the hash chain. | 148 | * the previous length of the hash chain. |
149 | * IN assertion: all calls to to INSERT_STRING are made with consecutive | 149 | * IN assertion: all calls to INSERT_STRING are made with consecutive |
150 | * input characters and the first MIN_MATCH bytes of str are valid | 150 | * input characters and the first MIN_MATCH bytes of str are valid |
151 | * (except for the last MIN_MATCH-1 bytes of the input file). | 151 | * (except for the last MIN_MATCH-1 bytes of the input file). |
152 | */ | 152 | */ |