aboutsummaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorEric Dumazet <dada1@cosmosbay.com>2008-01-03 23:41:28 -0500
committerDavid S. Miller <davem@davemloft.net>2008-01-28 18:00:35 -0500
commit571e7682026fd0e25833d103a3eeb74be29bf199 (patch)
tree3707c7fb4ea4384a163cddc9fac76e9d8860a109 /lib
parent789675e216617b1331875c42a81f58227a06df91 (diff)
[LIB] pcounter : unline too big functions
Before pushing pcounter to Linus tree, I would like to make some adjustments. Goal is to reduce kernel text size, by unlining too big functions. When a pcounter is bound to a statically defined per_cpu variable, we define two small helpers functions. (No more folding function using the fat for_each_possible_cpu(cpu) ... ) static DEFINE_PER_CPU(int, NAME##_pcounter_values); static void NAME##_pcounter_add(struct pcounter *self, int val) { __get_cpu_var(NAME##_pcounter_values) += val; } static int NAME##_pcounter_getval(const struct pcounter *self, int cpu) { return per_cpu(NAME##_pcounter_values, cpu); } Fast path is therefore unchanged, while folding/alloc/free is now unlined. This saves 228 bytes on i386 Signed-off-by: Eric Dumazet <dada1@cosmosbay.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
-rw-r--r--lib/pcounter.c42
1 files changed, 37 insertions, 5 deletions
diff --git a/lib/pcounter.c b/lib/pcounter.c
index 93feea598251..9b56807da93b 100644
--- a/lib/pcounter.c
+++ b/lib/pcounter.c
@@ -7,20 +7,52 @@
7#include <linux/module.h> 7#include <linux/module.h>
8#include <linux/pcounter.h> 8#include <linux/pcounter.h>
9#include <linux/smp.h> 9#include <linux/smp.h>
10#include <linux/cpumask.h>
10 11
11void pcounter_def_add(struct pcounter *self, int inc) 12static void pcounter_dyn_add(struct pcounter *self, int inc)
12{ 13{
13 per_cpu_ptr(self->per_cpu_values, smp_processor_id())[0] += inc; 14 per_cpu_ptr(self->per_cpu_values, smp_processor_id())[0] += inc;
14} 15}
15 16
16EXPORT_SYMBOL_GPL(pcounter_def_add); 17static int pcounter_dyn_getval(const struct pcounter *self, int cpu)
18{
19 return per_cpu_ptr(self->per_cpu_values, cpu)[0];
20}
17 21
18int pcounter_def_getval(const struct pcounter *self) 22int pcounter_getval(const struct pcounter *self)
19{ 23{
20 int res = 0, cpu; 24 int res = 0, cpu;
25
21 for_each_possible_cpu(cpu) 26 for_each_possible_cpu(cpu)
22 res += per_cpu_ptr(self->per_cpu_values, cpu)[0]; 27 res += self->getval(self, cpu);
28
23 return res; 29 return res;
24} 30}
31EXPORT_SYMBOL_GPL(pcounter_getval);
32
33int pcounter_alloc(struct pcounter *self)
34{
35 int rc = 0;
36 if (self->add == NULL) {
37 self->per_cpu_values = alloc_percpu(int);
38 if (self->per_cpu_values != NULL) {
39 self->add = pcounter_dyn_add;
40 self->getval = pcounter_dyn_getval;
41 } else
42 rc = 1;
43 }
44 return rc;
45}
46EXPORT_SYMBOL_GPL(pcounter_alloc);
47
48void pcounter_free(struct pcounter *self)
49{
50 if (self->per_cpu_values != NULL) {
51 free_percpu(self->per_cpu_values);
52 self->per_cpu_values = NULL;
53 self->getval = NULL;
54 self->add = NULL;
55 }
56}
57EXPORT_SYMBOL_GPL(pcounter_free);
25 58
26EXPORT_SYMBOL_GPL(pcounter_def_getval);