diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-24 18:10:28 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-05-24 18:10:28 -0400 |
commit | ce004178be1bbaa292e9e6497939e2970300095a (patch) | |
tree | 1cd5306548947deaedd612189b56d35265217e8e /lib | |
parent | 9978306e31a8f89bd81fbc4c49fd9aefb1d30d10 (diff) | |
parent | c5389831cda3b38a56606a348a537a1332f2d729 (diff) |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc
Pull sparc changes from David S. Miller:
"This has the generic strncpy_from_user() implementation architectures
can now use, which we've been developing on linux-arch over the past
few days.
For good measure I ran both a 32-bit and a 64-bit glibc testsuite run,
and the latter of which pointed out an adjustment I needed to make to
sparc's user_addr_max() definition. Linus, you were right, STACK_TOP
was not the right thing to use, even on sparc itself :-)
From Sam Ravnborg, we have a conversion of sparc32 over to the common
alloc_thread_info_node(), since the aspect which originally blocked
our doing so (sun4c) has been removed."
Fix up trivial arch/sparc/Kconfig and lib/Makefile conflicts.
* git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
sparc: Fix user_addr_max() definition.
lib: Sparc's strncpy_from_user is generic enough, move under lib/
kernel: Move REPEAT_BYTE definition into linux/kernel.h
sparc: Increase portability of strncpy_from_user() implementation.
sparc: Optimize strncpy_from_user() zero byte search.
sparc: Add full proper error handling to strncpy_from_user().
sparc32: use the common implementation of alloc_thread_info_node()
Diffstat (limited to 'lib')
-rw-r--r-- | lib/Kconfig | 3 | ||||
-rw-r--r-- | lib/Makefile | 2 | ||||
-rw-r--r-- | lib/strncpy_from_user.c | 146 |
3 files changed, 151 insertions, 0 deletions
diff --git a/lib/Kconfig b/lib/Kconfig index 0e25c03939e3..98230ac3db29 100644 --- a/lib/Kconfig +++ b/lib/Kconfig | |||
@@ -16,6 +16,9 @@ config BITREVERSE | |||
16 | config RATIONAL | 16 | config RATIONAL |
17 | boolean | 17 | boolean |
18 | 18 | ||
19 | config GENERIC_STRNCPY_FROM_USER | ||
20 | bool | ||
21 | |||
19 | config GENERIC_FIND_FIRST_BIT | 22 | config GENERIC_FIND_FIRST_BIT |
20 | bool | 23 | bool |
21 | 24 | ||
diff --git a/lib/Makefile b/lib/Makefile index 74290c9e2864..b98df505f335 100644 --- a/lib/Makefile +++ b/lib/Makefile | |||
@@ -125,6 +125,8 @@ obj-$(CONFIG_CLZ_TAB) += clz_tab.o | |||
125 | 125 | ||
126 | obj-$(CONFIG_DDR) += jedec_ddr_data.o | 126 | obj-$(CONFIG_DDR) += jedec_ddr_data.o |
127 | 127 | ||
128 | obj-$(CONFIG_GENERIC_STRNCPY_FROM_USER) += strncpy_from_user.o | ||
129 | |||
128 | hostprogs-y := gen_crc32table | 130 | hostprogs-y := gen_crc32table |
129 | clean-files := crc32table.h | 131 | clean-files := crc32table.h |
130 | 132 | ||
diff --git a/lib/strncpy_from_user.c b/lib/strncpy_from_user.c new file mode 100644 index 000000000000..c4c09b0e96ba --- /dev/null +++ b/lib/strncpy_from_user.c | |||
@@ -0,0 +1,146 @@ | |||
1 | #include <linux/module.h> | ||
2 | #include <linux/uaccess.h> | ||
3 | #include <linux/kernel.h> | ||
4 | #include <linux/errno.h> | ||
5 | |||
6 | #include <asm/byteorder.h> | ||
7 | |||
8 | static inline long find_zero(unsigned long mask) | ||
9 | { | ||
10 | long byte = 0; | ||
11 | |||
12 | #ifdef __BIG_ENDIAN | ||
13 | #ifdef CONFIG_64BIT | ||
14 | if (mask >> 32) | ||
15 | mask >>= 32; | ||
16 | else | ||
17 | byte = 4; | ||
18 | #endif | ||
19 | if (mask >> 16) | ||
20 | mask >>= 16; | ||
21 | else | ||
22 | byte += 2; | ||
23 | return (mask >> 8) ? byte : byte + 1; | ||
24 | #else | ||
25 | #ifdef CONFIG_64BIT | ||
26 | if (!((unsigned int) mask)) { | ||
27 | mask >>= 32; | ||
28 | byte = 4; | ||
29 | } | ||
30 | #endif | ||
31 | if (!(mask & 0xffff)) { | ||
32 | mask >>= 16; | ||
33 | byte += 2; | ||
34 | } | ||
35 | return (mask & 0xff) ? byte : byte + 1; | ||
36 | #endif | ||
37 | } | ||
38 | |||
39 | #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS | ||
40 | #define IS_UNALIGNED(src, dst) 0 | ||
41 | #else | ||
42 | #define IS_UNALIGNED(src, dst) \ | ||
43 | (((long) dst | (long) src) & (sizeof(long) - 1)) | ||
44 | #endif | ||
45 | |||
46 | /* | ||
47 | * Do a strncpy, return length of string without final '\0'. | ||
48 | * 'count' is the user-supplied count (return 'count' if we | ||
49 | * hit it), 'max' is the address space maximum (and we return | ||
50 | * -EFAULT if we hit it). | ||
51 | */ | ||
52 | static inline long do_strncpy_from_user(char *dst, const char __user *src, long count, unsigned long max) | ||
53 | { | ||
54 | const unsigned long high_bits = REPEAT_BYTE(0xfe) + 1; | ||
55 | const unsigned long low_bits = REPEAT_BYTE(0x7f); | ||
56 | long res = 0; | ||
57 | |||
58 | /* | ||
59 | * Truncate 'max' to the user-specified limit, so that | ||
60 | * we only have one limit we need to check in the loop | ||
61 | */ | ||
62 | if (max > count) | ||
63 | max = count; | ||
64 | |||
65 | if (IS_UNALIGNED(src, dst)) | ||
66 | goto byte_at_a_time; | ||
67 | |||
68 | while (max >= sizeof(unsigned long)) { | ||
69 | unsigned long c, v, rhs; | ||
70 | |||
71 | /* Fall back to byte-at-a-time if we get a page fault */ | ||
72 | if (unlikely(__get_user(c,(unsigned long __user *)(src+res)))) | ||
73 | break; | ||
74 | rhs = c | low_bits; | ||
75 | v = (c + high_bits) & ~rhs; | ||
76 | *(unsigned long *)(dst+res) = c; | ||
77 | if (v) { | ||
78 | v = (c & low_bits) + low_bits; | ||
79 | v = ~(v | rhs); | ||
80 | return res + find_zero(v); | ||
81 | } | ||
82 | res += sizeof(unsigned long); | ||
83 | max -= sizeof(unsigned long); | ||
84 | } | ||
85 | |||
86 | byte_at_a_time: | ||
87 | while (max) { | ||
88 | char c; | ||
89 | |||
90 | if (unlikely(__get_user(c,src+res))) | ||
91 | return -EFAULT; | ||
92 | dst[res] = c; | ||
93 | if (!c) | ||
94 | return res; | ||
95 | res++; | ||
96 | max--; | ||
97 | } | ||
98 | |||
99 | /* | ||
100 | * Uhhuh. We hit 'max'. But was that the user-specified maximum | ||
101 | * too? If so, that's ok - we got as much as the user asked for. | ||
102 | */ | ||
103 | if (res >= count) | ||
104 | return res; | ||
105 | |||
106 | /* | ||
107 | * Nope: we hit the address space limit, and we still had more | ||
108 | * characters the caller would have wanted. That's an EFAULT. | ||
109 | */ | ||
110 | return -EFAULT; | ||
111 | } | ||
112 | |||
113 | /** | ||
114 | * strncpy_from_user: - Copy a NUL terminated string from userspace. | ||
115 | * @dst: Destination address, in kernel space. This buffer must be at | ||
116 | * least @count bytes long. | ||
117 | * @src: Source address, in user space. | ||
118 | * @count: Maximum number of bytes to copy, including the trailing NUL. | ||
119 | * | ||
120 | * Copies a NUL-terminated string from userspace to kernel space. | ||
121 | * | ||
122 | * On success, returns the length of the string (not including the trailing | ||
123 | * NUL). | ||
124 | * | ||
125 | * If access to userspace fails, returns -EFAULT (some data may have been | ||
126 | * copied). | ||
127 | * | ||
128 | * If @count is smaller than the length of the string, copies @count bytes | ||
129 | * and returns @count. | ||
130 | */ | ||
131 | long strncpy_from_user(char *dst, const char __user *src, long count) | ||
132 | { | ||
133 | unsigned long max_addr, src_addr; | ||
134 | |||
135 | if (unlikely(count <= 0)) | ||
136 | return 0; | ||
137 | |||
138 | max_addr = user_addr_max(); | ||
139 | src_addr = (unsigned long)src; | ||
140 | if (likely(src_addr < max_addr)) { | ||
141 | unsigned long max = max_addr - src_addr; | ||
142 | return do_strncpy_from_user(dst, src, count, max); | ||
143 | } | ||
144 | return -EFAULT; | ||
145 | } | ||
146 | EXPORT_SYMBOL(strncpy_from_user); | ||