diff options
author | David Howells <dhowells@redhat.com> | 2009-07-02 09:35:32 -0400 |
---|---|---|
committer | J. Bruce Fields <bfields@citi.umich.edu> | 2009-07-03 10:21:10 -0400 |
commit | 033a666ccb842ab4134fcd0c861d5ba9f5d6bf3a (patch) | |
tree | 95da0764ea928ce4f821023e23a25001297c7bf3 /lib/string.c | |
parent | 28d0325ce6e0a52f53d8af687e6427fee59004d3 (diff) |
NFSD: Don't hold unrefcounted creds over call to nfsd_setuser()
nfsd_open() gets an unrefcounted pointer to the current process's effective
credentials at the top of the function, then calls nfsd_setuser() via
fh_verify() - which may replace and destroy the current process's effective
credentials - and then passes the unrefcounted pointer to dentry_open() - but
the credentials may have been destroyed by this point.
Instead, the value from current_cred() should be passed directly to
dentry_open() as one of its arguments, rather than being cached in a variable.
Possibly fh_verify() should return the creds to use.
This is a regression introduced by
745ca2475a6ac596e3d8d37c2759c0fbe2586227 "CRED: Pass credentials through
dentry_open()".
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-and-Verified-By: Steve Dickson <steved@redhat.com>
Cc: stable@kernel.org
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Diffstat (limited to 'lib/string.c')
0 files changed, 0 insertions, 0 deletions