diff options
author | Steven Whitehouse <swhiteho@redhat.com> | 2006-07-05 08:27:42 -0400 |
---|---|---|
committer | Steven Whitehouse <swhiteho@redhat.com> | 2006-07-05 08:27:42 -0400 |
commit | cf57a308436653f3094590202c77459aab250ff3 (patch) | |
tree | 8a9e7096e494141911147a1f24865c3d79d583c1 /lib/spinlock_debug.c | |
parent | faac9bd0e3ce7cb0572ec66e0a426cacf6afa970 (diff) | |
parent | ca78f6baca863afe2e6a244a0fe94b3a70211d46 (diff) |
Merge branch 'master'
Diffstat (limited to 'lib/spinlock_debug.c')
-rw-r--r-- | lib/spinlock_debug.c | 98 |
1 files changed, 62 insertions, 36 deletions
diff --git a/lib/spinlock_debug.c b/lib/spinlock_debug.c index 93c15ee3f8ea..3d9c4dc965ed 100644 --- a/lib/spinlock_debug.c +++ b/lib/spinlock_debug.c | |||
@@ -8,38 +8,71 @@ | |||
8 | 8 | ||
9 | #include <linux/spinlock.h> | 9 | #include <linux/spinlock.h> |
10 | #include <linux/interrupt.h> | 10 | #include <linux/interrupt.h> |
11 | #include <linux/debug_locks.h> | ||
11 | #include <linux/delay.h> | 12 | #include <linux/delay.h> |
13 | #include <linux/module.h> | ||
14 | |||
15 | void __spin_lock_init(spinlock_t *lock, const char *name, | ||
16 | struct lock_class_key *key) | ||
17 | { | ||
18 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
19 | /* | ||
20 | * Make sure we are not reinitializing a held lock: | ||
21 | */ | ||
22 | debug_check_no_locks_freed((void *)lock, sizeof(*lock)); | ||
23 | lockdep_init_map(&lock->dep_map, name, key); | ||
24 | #endif | ||
25 | lock->raw_lock = (raw_spinlock_t)__RAW_SPIN_LOCK_UNLOCKED; | ||
26 | lock->magic = SPINLOCK_MAGIC; | ||
27 | lock->owner = SPINLOCK_OWNER_INIT; | ||
28 | lock->owner_cpu = -1; | ||
29 | } | ||
30 | |||
31 | EXPORT_SYMBOL(__spin_lock_init); | ||
32 | |||
33 | void __rwlock_init(rwlock_t *lock, const char *name, | ||
34 | struct lock_class_key *key) | ||
35 | { | ||
36 | #ifdef CONFIG_DEBUG_LOCK_ALLOC | ||
37 | /* | ||
38 | * Make sure we are not reinitializing a held lock: | ||
39 | */ | ||
40 | debug_check_no_locks_freed((void *)lock, sizeof(*lock)); | ||
41 | lockdep_init_map(&lock->dep_map, name, key); | ||
42 | #endif | ||
43 | lock->raw_lock = (raw_rwlock_t) __RAW_RW_LOCK_UNLOCKED; | ||
44 | lock->magic = RWLOCK_MAGIC; | ||
45 | lock->owner = SPINLOCK_OWNER_INIT; | ||
46 | lock->owner_cpu = -1; | ||
47 | } | ||
48 | |||
49 | EXPORT_SYMBOL(__rwlock_init); | ||
12 | 50 | ||
13 | static void spin_bug(spinlock_t *lock, const char *msg) | 51 | static void spin_bug(spinlock_t *lock, const char *msg) |
14 | { | 52 | { |
15 | static long print_once = 1; | ||
16 | struct task_struct *owner = NULL; | 53 | struct task_struct *owner = NULL; |
17 | 54 | ||
18 | if (xchg(&print_once, 0)) { | 55 | if (!debug_locks_off()) |
19 | if (lock->owner && lock->owner != SPINLOCK_OWNER_INIT) | 56 | return; |
20 | owner = lock->owner; | 57 | |
21 | printk(KERN_EMERG "BUG: spinlock %s on CPU#%d, %s/%d\n", | 58 | if (lock->owner && lock->owner != SPINLOCK_OWNER_INIT) |
22 | msg, raw_smp_processor_id(), | 59 | owner = lock->owner; |
23 | current->comm, current->pid); | 60 | printk(KERN_EMERG "BUG: spinlock %s on CPU#%d, %s/%d\n", |
24 | printk(KERN_EMERG " lock: %p, .magic: %08x, .owner: %s/%d, " | 61 | msg, raw_smp_processor_id(), |
25 | ".owner_cpu: %d\n", | 62 | current->comm, current->pid); |
26 | lock, lock->magic, | 63 | printk(KERN_EMERG " lock: %p, .magic: %08x, .owner: %s/%d, " |
27 | owner ? owner->comm : "<none>", | 64 | ".owner_cpu: %d\n", |
28 | owner ? owner->pid : -1, | 65 | lock, lock->magic, |
29 | lock->owner_cpu); | 66 | owner ? owner->comm : "<none>", |
30 | dump_stack(); | 67 | owner ? owner->pid : -1, |
31 | #ifdef CONFIG_SMP | 68 | lock->owner_cpu); |
32 | /* | 69 | dump_stack(); |
33 | * We cannot continue on SMP: | ||
34 | */ | ||
35 | // panic("bad locking"); | ||
36 | #endif | ||
37 | } | ||
38 | } | 70 | } |
39 | 71 | ||
40 | #define SPIN_BUG_ON(cond, lock, msg) if (unlikely(cond)) spin_bug(lock, msg) | 72 | #define SPIN_BUG_ON(cond, lock, msg) if (unlikely(cond)) spin_bug(lock, msg) |
41 | 73 | ||
42 | static inline void debug_spin_lock_before(spinlock_t *lock) | 74 | static inline void |
75 | debug_spin_lock_before(spinlock_t *lock) | ||
43 | { | 76 | { |
44 | SPIN_BUG_ON(lock->magic != SPINLOCK_MAGIC, lock, "bad magic"); | 77 | SPIN_BUG_ON(lock->magic != SPINLOCK_MAGIC, lock, "bad magic"); |
45 | SPIN_BUG_ON(lock->owner == current, lock, "recursion"); | 78 | SPIN_BUG_ON(lock->owner == current, lock, "recursion"); |
@@ -118,20 +151,13 @@ void _raw_spin_unlock(spinlock_t *lock) | |||
118 | 151 | ||
119 | static void rwlock_bug(rwlock_t *lock, const char *msg) | 152 | static void rwlock_bug(rwlock_t *lock, const char *msg) |
120 | { | 153 | { |
121 | static long print_once = 1; | 154 | if (!debug_locks_off()) |
122 | 155 | return; | |
123 | if (xchg(&print_once, 0)) { | 156 | |
124 | printk(KERN_EMERG "BUG: rwlock %s on CPU#%d, %s/%d, %p\n", | 157 | printk(KERN_EMERG "BUG: rwlock %s on CPU#%d, %s/%d, %p\n", |
125 | msg, raw_smp_processor_id(), current->comm, | 158 | msg, raw_smp_processor_id(), current->comm, |
126 | current->pid, lock); | 159 | current->pid, lock); |
127 | dump_stack(); | 160 | dump_stack(); |
128 | #ifdef CONFIG_SMP | ||
129 | /* | ||
130 | * We cannot continue on SMP: | ||
131 | */ | ||
132 | panic("bad locking"); | ||
133 | #endif | ||
134 | } | ||
135 | } | 161 | } |
136 | 162 | ||
137 | #define RWLOCK_BUG_ON(cond, lock, msg) if (unlikely(cond)) rwlock_bug(lock, msg) | 163 | #define RWLOCK_BUG_ON(cond, lock, msg) if (unlikely(cond)) rwlock_bug(lock, msg) |