diff options
author | NeilBrown <neilb@suse.de> | 2009-06-09 00:39:59 -0400 |
---|---|---|
committer | NeilBrown <neilb@suse.de> | 2009-06-09 00:39:59 -0400 |
commit | a8c906ca3f63d05f0d25490cf82276f73c6fe095 (patch) | |
tree | 993249ef5865a2ec81ed21e8934ed9c0eb9f33dd /lib/rwsem.c | |
parent | f001a70cdc61c01452d42e8b32fd7c7842ef62d5 (diff) |
md/raid5 - avoid deadlocks in get_active_stripe during reshape
md has functionality to 'quiesce' and array so that all pending
IO completed and no new IO starts. This is used to achieve a
stable state before making internal changes.
Currently this quiescing applies equally to normal IO, resync
IO, and reshape IO.
However there is a problem with applying it to reshape IO.
Reshape can have multiple 'stripe_heads' that must be active together.
If the quiesce come between allocating the first and the last of
such a collection, then we deadlock, as the last will not be allocated
until the quiesce is lifted, the quiesce will not be lifted until the
first (which has been allocated) gets used, and that first cannot be
used until the last is allocated.
It is not necessary to inhibit reshape IO when a quiesce is
requested. Those places in the code that require a full quiesce will
ensure the reshape thread is not running at all.
So allow reshape requests to get access to new stripe_heads without
being blocked by a 'quiesce'.
This only affects in-place reshapes (i.e. where the array does not
grow or shrink) and these are only newly supported. So this patch is
not needed in earlier kernels.
Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'lib/rwsem.c')
0 files changed, 0 insertions, 0 deletions