aboutsummaryrefslogtreecommitdiffstats
path: root/lib/rhashtable.c
diff options
context:
space:
mode:
authorHerbert Xu <herbert@gondor.apana.org.au>2015-03-20 06:56:59 -0400
committerDavid S. Miller <davem@davemloft.net>2015-03-20 16:16:24 -0400
commit488fb86ee91d3b1182c2e30a9f9b45da14eda46f (patch)
treebcee7b730a66a4d7853310f8677778ccfb9484e3 /lib/rhashtable.c
parent0b8c707ddf37171413fe67350263e5b6ffeedf7c (diff)
rhashtable: Make rhashtable_init params argument const
This patch marks the rhashtable_init params argument const as there is no reason to modify it since we will always make a copy of it in the rhashtable. This patch also fixes a bug where we don't actually round up the value of min_size unless it is less than HASH_MIN_SIZE. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> Acked-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib/rhashtable.c')
-rw-r--r--lib/rhashtable.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index e75c48d9d82f..e0a9d59f80d6 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -870,7 +870,7 @@ out:
870} 870}
871EXPORT_SYMBOL_GPL(rhashtable_walk_stop); 871EXPORT_SYMBOL_GPL(rhashtable_walk_stop);
872 872
873static size_t rounded_hashtable_size(struct rhashtable_params *params) 873static size_t rounded_hashtable_size(const struct rhashtable_params *params)
874{ 874{
875 return max(roundup_pow_of_two(params->nelem_hint * 4 / 3), 875 return max(roundup_pow_of_two(params->nelem_hint * 4 / 3),
876 (unsigned long)params->min_size); 876 (unsigned long)params->min_size);
@@ -919,7 +919,8 @@ static size_t rounded_hashtable_size(struct rhashtable_params *params)
919 * .obj_hashfn = my_hash_fn, 919 * .obj_hashfn = my_hash_fn,
920 * }; 920 * };
921 */ 921 */
922int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params) 922int rhashtable_init(struct rhashtable *ht,
923 const struct rhashtable_params *params)
923{ 924{
924 struct bucket_table *tbl; 925 struct bucket_table *tbl;
925 size_t size; 926 size_t size;
@@ -946,7 +947,7 @@ int rhashtable_init(struct rhashtable *ht, struct rhashtable_params *params)
946 if (params->max_size) 947 if (params->max_size)
947 ht->p.max_size = rounddown_pow_of_two(params->max_size); 948 ht->p.max_size = rounddown_pow_of_two(params->max_size);
948 949
949 ht->p.min_size = max(params->min_size, HASH_MIN_SIZE); 950 ht->p.min_size = max(ht->p.min_size, HASH_MIN_SIZE);
950 951
951 if (params->locks_mul) 952 if (params->locks_mul)
952 ht->p.locks_mul = roundup_pow_of_two(params->locks_mul); 953 ht->p.locks_mul = roundup_pow_of_two(params->locks_mul);