Use WARN() in lib/

Use WARN() instead of a printk+WARN_ON() pair; this way the message becomes
part of the warning section for better reporting/collection.  In addition, one
of the if() clauses collapes into the WARN() entirely now.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

1 files changed, 7 insertions, 6 deletions

diff --git a/lib/plist.c b/lib/plist.c
index 3074a02272f3..d6c64a824e1d 100644
--- a/lib/plist.c
+++ b/lib/plist.c
@@ -31,12 +31,13 @@
 static void plist_check_prev_next(struct list_head *t, struct list_head *p,
                                   struct list_head *n)
 {
-        if (n->prev != p || p->next != n) {
-                printk("top: %p, n: %p, p: %p\n", t, t->next, t->prev);
-                printk("prev: %p, n: %p, p: %p\n", p, p->next, p->prev);
-                printk("next: %p, n: %p, p: %p\n", n, n->next, n->prev);
-                WARN_ON(1);
-        }
+        WARN(n->prev != p || p->next != n,
+                        "top: %p, n: %p, p: %p\n"
+                        "prev: %p, n: %p, p: %p\n"
+                        "next: %p, n: %p, p: %p\n",
+                         t, t->next, t->prev,
+                        p, p->next, p->prev,
+                        n, n->next, n->prev);
 }
 
 static void plist_check_list(struct list_head *top)