diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2014-08-06 19:10:24 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-06 21:01:27 -0400 |
| commit | 74e765319084bd2940a9612ada961f0f7385936c (patch) | |
| tree | 3adcb5655903b6978283b96e3d062cd82f95b731 /lib/bitmap.c | |
| parent | 7e5f97d1927f41affa21aa5b321865ceab1994ce (diff) | |
lib: bitmap: add missing mask in bitmap_andnot
Apparently, bitmap_andnot is supposed to return whether the new bitmap
is empty. But it didn't take potential garbage bits in the last word
into account.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/bitmap.c')
| -rw-r--r-- | lib/bitmap.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/bitmap.c b/lib/bitmap.c index ce2ec80bf431..1e031f2c9aba 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c | |||
| @@ -223,11 +223,14 @@ int __bitmap_andnot(unsigned long *dst, const unsigned long *bitmap1, | |||
| 223 | const unsigned long *bitmap2, unsigned int bits) | 223 | const unsigned long *bitmap2, unsigned int bits) |
| 224 | { | 224 | { |
| 225 | unsigned int k; | 225 | unsigned int k; |
| 226 | unsigned int nr = BITS_TO_LONGS(bits); | 226 | unsigned int lim = bits/BITS_PER_LONG; |
| 227 | unsigned long result = 0; | 227 | unsigned long result = 0; |
| 228 | 228 | ||
| 229 | for (k = 0; k < nr; k++) | 229 | for (k = 0; k < lim; k++) |
| 230 | result |= (dst[k] = bitmap1[k] & ~bitmap2[k]); | 230 | result |= (dst[k] = bitmap1[k] & ~bitmap2[k]); |
| 231 | if (bits % BITS_PER_LONG) | ||
| 232 | result |= (dst[k] = bitmap1[k] & ~bitmap2[k] & | ||
| 233 | BITMAP_LAST_WORD_MASK(bits)); | ||
| 231 | return result != 0; | 234 | return result != 0; |
| 232 | } | 235 | } |
| 233 | EXPORT_SYMBOL(__bitmap_andnot); | 236 | EXPORT_SYMBOL(__bitmap_andnot); |
