diff options
author | Valentin Rothberg <valentinrothberg@gmail.com> | 2014-10-13 18:51:38 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-10-13 20:18:14 -0400 |
commit | 8a6f0b47dad5f8653f2f6ca6360f9f97b8113571 (patch) | |
tree | 3a7c8a862c4a876da753831ce99a8189f30ca763 /lib/Kconfig.debug | |
parent | 6de8ab68bc30da75116209d818c75497bdaed09d (diff) |
lib: rename TEST_MODULE to TEST_LKM
The "_MODULE" suffix is reserved for tristates compiled as loadable kernel
modules (LKM). The "TEST_MODULE" feature thereby violates this
convention. The feature is used to compile the lib/test_module.c kernel
module.
Sadly this convention is not made explicit, but the Kconfig code documents
it. The following code (./scripts/kconfig/confdata.c) is used to generate
the autoconf.h header file during the build process. When a feature is
selected as a kernel module ('m'), it is suffixed with "_MODULE" to
indicate it.
switch (*value) {
case 'n':
break;
case 'm':
suffix = "_MODULE";
/* fall through */
This causes problems for static code analysis, which assumes a consistent
use of the "_MODULE" suffix.
This patch renames the feature and its reference in a Makefile to
"TEST_LKM", which still expresses the test of a LKM.
Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
Cc: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/Kconfig.debug')
-rw-r--r-- | lib/Kconfig.debug | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index e7ad58c5fbeb..4e35a5d767ed 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug | |||
@@ -1648,7 +1648,7 @@ config DMA_API_DEBUG | |||
1648 | 1648 | ||
1649 | If unsure, say N. | 1649 | If unsure, say N. |
1650 | 1650 | ||
1651 | config TEST_MODULE | 1651 | config TEST_LKM |
1652 | tristate "Test module loading with 'hello world' module" | 1652 | tristate "Test module loading with 'hello world' module" |
1653 | default n | 1653 | default n |
1654 | depends on m | 1654 | depends on m |