diff options
author | Mel Gorman <mgorman@suse.de> | 2013-10-07 06:29:35 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2013-10-09 08:48:14 -0400 |
commit | 3e6a9418cf05638b103e34f5d13be0321872e623 (patch) | |
tree | 5ef3c692c7cd728f53ebabcfebdc94a21db7a8ea /kernel | |
parent | dabe1d992414a6456e60e41f1d1ad8affc6d444d (diff) |
sched/numa: Take false sharing into account when adapting scan rate
Scan rate is altered based on whether shared/private faults dominated.
task_numa_group() may detect false sharing but that information is not
taken into account when adapting the scan rate. Take it into account.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Reviewed-by: Rik van Riel <riel@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/1381141781-10992-58-git-send-email-mgorman@suse.de
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sched/fair.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 222c2d0b6ae2..d26a16e45437 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c | |||
@@ -1381,7 +1381,8 @@ static void double_lock(spinlock_t *l1, spinlock_t *l2) | |||
1381 | spin_lock_nested(l2, SINGLE_DEPTH_NESTING); | 1381 | spin_lock_nested(l2, SINGLE_DEPTH_NESTING); |
1382 | } | 1382 | } |
1383 | 1383 | ||
1384 | static void task_numa_group(struct task_struct *p, int cpupid, int flags) | 1384 | static void task_numa_group(struct task_struct *p, int cpupid, int flags, |
1385 | int *priv) | ||
1385 | { | 1386 | { |
1386 | struct numa_group *grp, *my_grp; | 1387 | struct numa_group *grp, *my_grp; |
1387 | struct task_struct *tsk; | 1388 | struct task_struct *tsk; |
@@ -1447,6 +1448,9 @@ static void task_numa_group(struct task_struct *p, int cpupid, int flags) | |||
1447 | if (flags & TNF_SHARED) | 1448 | if (flags & TNF_SHARED) |
1448 | join = true; | 1449 | join = true; |
1449 | 1450 | ||
1451 | /* Update priv based on whether false sharing was detected */ | ||
1452 | *priv = !join; | ||
1453 | |||
1450 | if (join && !get_numa_group(grp)) | 1454 | if (join && !get_numa_group(grp)) |
1451 | join = false; | 1455 | join = false; |
1452 | 1456 | ||
@@ -1545,7 +1549,7 @@ void task_numa_fault(int last_cpupid, int node, int pages, int flags) | |||
1545 | } else { | 1549 | } else { |
1546 | priv = cpupid_match_pid(p, last_cpupid); | 1550 | priv = cpupid_match_pid(p, last_cpupid); |
1547 | if (!priv && !(flags & TNF_NO_GROUP)) | 1551 | if (!priv && !(flags & TNF_NO_GROUP)) |
1548 | task_numa_group(p, last_cpupid, flags); | 1552 | task_numa_group(p, last_cpupid, flags, &priv); |
1549 | } | 1553 | } |
1550 | 1554 | ||
1551 | /* | 1555 | /* |