diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2012-11-21 10:26:44 -0500 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2012-11-28 11:07:57 -0500 |
commit | e80d0a1ae8bb8fee0edd37427836f108b30f596b (patch) | |
tree | 437db8b1643e39d3d114a7c0e3c913455e693b70 /kernel | |
parent | a634f93335daa8f38180a0e576ccd68a73c36eaf (diff) |
cputime: Rename thread_group_times to thread_group_cputime_adjusted
We have thread_group_cputime() and thread_group_times(). The naming
doesn't provide enough information about the difference between
these two APIs.
To lower the confusion, rename thread_group_times() to
thread_group_cputime_adjusted(). This name better suggests that
it's a version of thread_group_cputime() that does some stabilization
on the raw cputime values. ie here: scale on top of CFS runtime
stats and bound lower value for monotonicity.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/exit.c | 4 | ||||
-rw-r--r-- | kernel/sched/cputime.c | 8 | ||||
-rw-r--r-- | kernel/sys.c | 6 |
3 files changed, 9 insertions, 9 deletions
diff --git a/kernel/exit.c b/kernel/exit.c index 346616c0092c..618f7ee56003 100644 --- a/kernel/exit.c +++ b/kernel/exit.c | |||
@@ -1186,11 +1186,11 @@ static int wait_task_zombie(struct wait_opts *wo, struct task_struct *p) | |||
1186 | * as other threads in the parent group can be right | 1186 | * as other threads in the parent group can be right |
1187 | * here reaping other children at the same time. | 1187 | * here reaping other children at the same time. |
1188 | * | 1188 | * |
1189 | * We use thread_group_times() to get times for the thread | 1189 | * We use thread_group_cputime_adjusted() to get times for the thread |
1190 | * group, which consolidates times for all threads in the | 1190 | * group, which consolidates times for all threads in the |
1191 | * group including the group leader. | 1191 | * group including the group leader. |
1192 | */ | 1192 | */ |
1193 | thread_group_times(p, &tgutime, &tgstime); | 1193 | thread_group_cputime_adjusted(p, &tgutime, &tgstime); |
1194 | spin_lock_irq(&p->real_parent->sighand->siglock); | 1194 | spin_lock_irq(&p->real_parent->sighand->siglock); |
1195 | psig = p->real_parent->signal; | 1195 | psig = p->real_parent->signal; |
1196 | sig = p->signal; | 1196 | sig = p->signal; |
diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index e56f138a23c7..7dc155371b95 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c | |||
@@ -445,13 +445,13 @@ void account_idle_ticks(unsigned long ticks) | |||
445 | * Use precise platform statistics if available: | 445 | * Use precise platform statistics if available: |
446 | */ | 446 | */ |
447 | #ifdef CONFIG_VIRT_CPU_ACCOUNTING | 447 | #ifdef CONFIG_VIRT_CPU_ACCOUNTING |
448 | void task_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | 448 | void task_cputime_adjusted(struct task_struct *p, cputime_t *ut, cputime_t *st) |
449 | { | 449 | { |
450 | *ut = p->utime; | 450 | *ut = p->utime; |
451 | *st = p->stime; | 451 | *st = p->stime; |
452 | } | 452 | } |
453 | 453 | ||
454 | void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | 454 | void thread_group_cputime_adjusted(struct task_struct *p, cputime_t *ut, cputime_t *st) |
455 | { | 455 | { |
456 | struct task_cputime cputime; | 456 | struct task_cputime cputime; |
457 | 457 | ||
@@ -516,7 +516,7 @@ static cputime_t scale_utime(cputime_t utime, cputime_t rtime, cputime_t total) | |||
516 | return (__force cputime_t) temp; | 516 | return (__force cputime_t) temp; |
517 | } | 517 | } |
518 | 518 | ||
519 | void task_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | 519 | void task_cputime_adjusted(struct task_struct *p, cputime_t *ut, cputime_t *st) |
520 | { | 520 | { |
521 | cputime_t rtime, utime = p->utime, total = utime + p->stime; | 521 | cputime_t rtime, utime = p->utime, total = utime + p->stime; |
522 | 522 | ||
@@ -543,7 +543,7 @@ void task_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | |||
543 | /* | 543 | /* |
544 | * Must be called with siglock held. | 544 | * Must be called with siglock held. |
545 | */ | 545 | */ |
546 | void thread_group_times(struct task_struct *p, cputime_t *ut, cputime_t *st) | 546 | void thread_group_cputime_adjusted(struct task_struct *p, cputime_t *ut, cputime_t *st) |
547 | { | 547 | { |
548 | struct signal_struct *sig = p->signal; | 548 | struct signal_struct *sig = p->signal; |
549 | struct task_cputime cputime; | 549 | struct task_cputime cputime; |
diff --git a/kernel/sys.c b/kernel/sys.c index e6e0ece5f6a0..265b37690421 100644 --- a/kernel/sys.c +++ b/kernel/sys.c | |||
@@ -1046,7 +1046,7 @@ void do_sys_times(struct tms *tms) | |||
1046 | cputime_t tgutime, tgstime, cutime, cstime; | 1046 | cputime_t tgutime, tgstime, cutime, cstime; |
1047 | 1047 | ||
1048 | spin_lock_irq(¤t->sighand->siglock); | 1048 | spin_lock_irq(¤t->sighand->siglock); |
1049 | thread_group_times(current, &tgutime, &tgstime); | 1049 | thread_group_cputime_adjusted(current, &tgutime, &tgstime); |
1050 | cutime = current->signal->cutime; | 1050 | cutime = current->signal->cutime; |
1051 | cstime = current->signal->cstime; | 1051 | cstime = current->signal->cstime; |
1052 | spin_unlock_irq(¤t->sighand->siglock); | 1052 | spin_unlock_irq(¤t->sighand->siglock); |
@@ -1704,7 +1704,7 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r) | |||
1704 | utime = stime = 0; | 1704 | utime = stime = 0; |
1705 | 1705 | ||
1706 | if (who == RUSAGE_THREAD) { | 1706 | if (who == RUSAGE_THREAD) { |
1707 | task_times(current, &utime, &stime); | 1707 | task_cputime_adjusted(current, &utime, &stime); |
1708 | accumulate_thread_rusage(p, r); | 1708 | accumulate_thread_rusage(p, r); |
1709 | maxrss = p->signal->maxrss; | 1709 | maxrss = p->signal->maxrss; |
1710 | goto out; | 1710 | goto out; |
@@ -1730,7 +1730,7 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r) | |||
1730 | break; | 1730 | break; |
1731 | 1731 | ||
1732 | case RUSAGE_SELF: | 1732 | case RUSAGE_SELF: |
1733 | thread_group_times(p, &tgutime, &tgstime); | 1733 | thread_group_cputime_adjusted(p, &tgutime, &tgstime); |
1734 | utime += tgutime; | 1734 | utime += tgutime; |
1735 | stime += tgstime; | 1735 | stime += tgstime; |
1736 | r->ru_nvcsw += p->signal->nvcsw; | 1736 | r->ru_nvcsw += p->signal->nvcsw; |