diff options
author | Tejun Heo <tj@kernel.org> | 2013-06-03 22:13:55 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2013-06-05 15:00:33 -0400 |
commit | cc5943a7816ba6c00639837a62131386619548dc (patch) | |
tree | 53027a91d8fa13ef177292cdc32e2b87d56d8284 /kernel | |
parent | f12dc020149fad7087e119e54cffea668272bf7d (diff) |
cgroup: mark "notify_on_release" and "release_agent" cgroup files insane
The empty cgroup notification mechanism currently implemented in
cgroup is tragically outdated. Forking and execing userland process
stopped being a viable notification mechanism more than a decade ago.
We're gonna have a saner mechanism. Let's make it clear that this
abomination is going away.
Mark "notify_on_release" and "release_agent" with CFTYPE_INSANE.
Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/cgroup.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index 1e0f445b5b88..b3bb8a393642 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
@@ -4052,6 +4052,7 @@ static struct cftype files[] = { | |||
4052 | }, | 4052 | }, |
4053 | { | 4053 | { |
4054 | .name = "notify_on_release", | 4054 | .name = "notify_on_release", |
4055 | .flags = CFTYPE_INSANE, | ||
4055 | .read_u64 = cgroup_read_notify_on_release, | 4056 | .read_u64 = cgroup_read_notify_on_release, |
4056 | .write_u64 = cgroup_write_notify_on_release, | 4057 | .write_u64 = cgroup_write_notify_on_release, |
4057 | }, | 4058 | }, |
@@ -4073,7 +4074,7 @@ static struct cftype files[] = { | |||
4073 | }, | 4074 | }, |
4074 | { | 4075 | { |
4075 | .name = "release_agent", | 4076 | .name = "release_agent", |
4076 | .flags = CFTYPE_ONLY_ON_ROOT, | 4077 | .flags = CFTYPE_INSANE | CFTYPE_ONLY_ON_ROOT, |
4077 | .read_seq_string = cgroup_release_agent_show, | 4078 | .read_seq_string = cgroup_release_agent_show, |
4078 | .write_string = cgroup_release_agent_write, | 4079 | .write_string = cgroup_release_agent_write, |
4079 | .max_write_len = PATH_MAX, | 4080 | .max_write_len = PATH_MAX, |