diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2008-02-08 07:18:43 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-08 12:22:24 -0500 |
commit | 92dfc9dc7ba63134f721b6e745dbdcfc13ea341b (patch) | |
tree | aa959d2d5ba1819651888601e4d917b01ddcc88c /kernel | |
parent | 6d7623943c905efae327933bc5ee0b2f78e15f56 (diff) |
fix "modules: make module_address_lookup() safe"
Get the constness right, avoid nasty cast.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/module.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/module.c b/kernel/module.c index 676c023c831b..4202da97a1da 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
@@ -2253,7 +2253,7 @@ static const char *get_ksymbol(struct module *mod, | |||
2253 | 2253 | ||
2254 | /* For kallsyms to ask for address resolution. NULL means not found. Careful | 2254 | /* For kallsyms to ask for address resolution. NULL means not found. Careful |
2255 | * not to lock to avoid deadlock on oopses, simply disable preemption. */ | 2255 | * not to lock to avoid deadlock on oopses, simply disable preemption. */ |
2256 | char *module_address_lookup(unsigned long addr, | 2256 | const char *module_address_lookup(unsigned long addr, |
2257 | unsigned long *size, | 2257 | unsigned long *size, |
2258 | unsigned long *offset, | 2258 | unsigned long *offset, |
2259 | char **modname, | 2259 | char **modname, |
@@ -2278,7 +2278,7 @@ char *module_address_lookup(unsigned long addr, | |||
2278 | ret = namebuf; | 2278 | ret = namebuf; |
2279 | } | 2279 | } |
2280 | preempt_enable(); | 2280 | preempt_enable(); |
2281 | return (char *)ret; | 2281 | return ret; |
2282 | } | 2282 | } |
2283 | 2283 | ||
2284 | int lookup_module_symbol_name(unsigned long addr, char *symname) | 2284 | int lookup_module_symbol_name(unsigned long addr, char *symname) |