diff options
author | Michael Neuling <mikey@neuling.org> | 2007-10-18 06:06:34 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-18 17:37:28 -0400 |
commit | c66f08be7e3ad0a28bcd9a0aef766fdf08ea0ec6 (patch) | |
tree | d147c0a43a66973014d924a6020388a249c509a7 /kernel | |
parent | 898eb71cb17644964c5895fb190e79e3d0c49679 (diff) |
Add scaled time to taskstats based process accounting
This adds items to the taststats struct to account for user and system
time based on scaling the CPU frequency and instruction issue rates.
Adds account_(user|system)_time_scaled callbacks which architectures
can use to account for time using this mechanism.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Cc: Balbir Singh <balbir@in.ibm.com>
Cc: Jay Lan <jlan@engr.sgi.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/delayacct.c | 6 | ||||
-rw-r--r-- | kernel/fork.c | 2 | ||||
-rw-r--r-- | kernel/sched.c | 21 | ||||
-rw-r--r-- | kernel/timer.c | 7 | ||||
-rw-r--r-- | kernel/tsacct.c | 4 |
5 files changed, 38 insertions, 2 deletions
diff --git a/kernel/delayacct.c b/kernel/delayacct.c index 09e9574eeb26..10e43fd8b721 100644 --- a/kernel/delayacct.c +++ b/kernel/delayacct.c | |||
@@ -115,6 +115,12 @@ int __delayacct_add_tsk(struct taskstats *d, struct task_struct *tsk) | |||
115 | tmp += timespec_to_ns(&ts); | 115 | tmp += timespec_to_ns(&ts); |
116 | d->cpu_run_real_total = (tmp < (s64)d->cpu_run_real_total) ? 0 : tmp; | 116 | d->cpu_run_real_total = (tmp < (s64)d->cpu_run_real_total) ? 0 : tmp; |
117 | 117 | ||
118 | tmp = (s64)d->cpu_scaled_run_real_total; | ||
119 | cputime_to_timespec(tsk->utimescaled + tsk->stimescaled, &ts); | ||
120 | tmp += timespec_to_ns(&ts); | ||
121 | d->cpu_scaled_run_real_total = | ||
122 | (tmp < (s64)d->cpu_scaled_run_real_total) ? 0 : tmp; | ||
123 | |||
118 | /* | 124 | /* |
119 | * No locking available for sched_info (and too expensive to add one) | 125 | * No locking available for sched_info (and too expensive to add one) |
120 | * Mitigate by taking snapshot of values | 126 | * Mitigate by taking snapshot of values |
diff --git a/kernel/fork.c b/kernel/fork.c index 1232aac6a1cd..2ce28f165e31 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -1059,6 +1059,8 @@ static struct task_struct *copy_process(unsigned long clone_flags, | |||
1059 | p->utime = cputime_zero; | 1059 | p->utime = cputime_zero; |
1060 | p->stime = cputime_zero; | 1060 | p->stime = cputime_zero; |
1061 | p->gtime = cputime_zero; | 1061 | p->gtime = cputime_zero; |
1062 | p->utimescaled = cputime_zero; | ||
1063 | p->stimescaled = cputime_zero; | ||
1062 | 1064 | ||
1063 | #ifdef CONFIG_TASK_XACCT | 1065 | #ifdef CONFIG_TASK_XACCT |
1064 | p->rchar = 0; /* I/O counter: bytes read */ | 1066 | p->rchar = 0; /* I/O counter: bytes read */ |
diff --git a/kernel/sched.c b/kernel/sched.c index 92721d1534b8..12534421d7b5 100644 --- a/kernel/sched.c +++ b/kernel/sched.c | |||
@@ -3334,6 +3334,16 @@ void account_guest_time(struct task_struct *p, cputime_t cputime) | |||
3334 | } | 3334 | } |
3335 | 3335 | ||
3336 | /* | 3336 | /* |
3337 | * Account scaled user cpu time to a process. | ||
3338 | * @p: the process that the cpu time gets accounted to | ||
3339 | * @cputime: the cpu time spent in user space since the last update | ||
3340 | */ | ||
3341 | void account_user_time_scaled(struct task_struct *p, cputime_t cputime) | ||
3342 | { | ||
3343 | p->utimescaled = cputime_add(p->utimescaled, cputime); | ||
3344 | } | ||
3345 | |||
3346 | /* | ||
3337 | * Account system cpu time to a process. | 3347 | * Account system cpu time to a process. |
3338 | * @p: the process that the cpu time gets accounted to | 3348 | * @p: the process that the cpu time gets accounted to |
3339 | * @hardirq_offset: the offset to subtract from hardirq_count() | 3349 | * @hardirq_offset: the offset to subtract from hardirq_count() |
@@ -3371,6 +3381,17 @@ void account_system_time(struct task_struct *p, int hardirq_offset, | |||
3371 | } | 3381 | } |
3372 | 3382 | ||
3373 | /* | 3383 | /* |
3384 | * Account scaled system cpu time to a process. | ||
3385 | * @p: the process that the cpu time gets accounted to | ||
3386 | * @hardirq_offset: the offset to subtract from hardirq_count() | ||
3387 | * @cputime: the cpu time spent in kernel space since the last update | ||
3388 | */ | ||
3389 | void account_system_time_scaled(struct task_struct *p, cputime_t cputime) | ||
3390 | { | ||
3391 | p->stimescaled = cputime_add(p->stimescaled, cputime); | ||
3392 | } | ||
3393 | |||
3394 | /* | ||
3374 | * Account for involuntary wait time. | 3395 | * Account for involuntary wait time. |
3375 | * @p: the process from which the cpu time has been stolen | 3396 | * @p: the process from which the cpu time has been stolen |
3376 | * @steal: the cpu time spent in involuntary wait | 3397 | * @steal: the cpu time spent in involuntary wait |
diff --git a/kernel/timer.c b/kernel/timer.c index 0735f0aa3afb..8521d10fbb27 100644 --- a/kernel/timer.c +++ b/kernel/timer.c | |||
@@ -826,10 +826,13 @@ void update_process_times(int user_tick) | |||
826 | int cpu = smp_processor_id(); | 826 | int cpu = smp_processor_id(); |
827 | 827 | ||
828 | /* Note: this timer irq context must be accounted for as well. */ | 828 | /* Note: this timer irq context must be accounted for as well. */ |
829 | if (user_tick) | 829 | if (user_tick) { |
830 | account_user_time(p, jiffies_to_cputime(1)); | 830 | account_user_time(p, jiffies_to_cputime(1)); |
831 | else | 831 | account_user_time_scaled(p, jiffies_to_cputime(1)); |
832 | } else { | ||
832 | account_system_time(p, HARDIRQ_OFFSET, jiffies_to_cputime(1)); | 833 | account_system_time(p, HARDIRQ_OFFSET, jiffies_to_cputime(1)); |
834 | account_system_time_scaled(p, jiffies_to_cputime(1)); | ||
835 | } | ||
833 | run_local_timers(); | 836 | run_local_timers(); |
834 | if (rcu_pending(cpu)) | 837 | if (rcu_pending(cpu)) |
835 | rcu_check_callbacks(cpu, user_tick); | 838 | rcu_check_callbacks(cpu, user_tick); |
diff --git a/kernel/tsacct.c b/kernel/tsacct.c index c122131a122f..4ab1b584961b 100644 --- a/kernel/tsacct.c +++ b/kernel/tsacct.c | |||
@@ -62,6 +62,10 @@ void bacct_add_tsk(struct taskstats *stats, struct task_struct *tsk) | |||
62 | rcu_read_unlock(); | 62 | rcu_read_unlock(); |
63 | stats->ac_utime = cputime_to_msecs(tsk->utime) * USEC_PER_MSEC; | 63 | stats->ac_utime = cputime_to_msecs(tsk->utime) * USEC_PER_MSEC; |
64 | stats->ac_stime = cputime_to_msecs(tsk->stime) * USEC_PER_MSEC; | 64 | stats->ac_stime = cputime_to_msecs(tsk->stime) * USEC_PER_MSEC; |
65 | stats->ac_utimescaled = | ||
66 | cputime_to_msecs(tsk->utimescaled) * USEC_PER_MSEC; | ||
67 | stats->ac_stimescaled = | ||
68 | cputime_to_msecs(tsk->stimescaled) * USEC_PER_MSEC; | ||
65 | stats->ac_minflt = tsk->min_flt; | 69 | stats->ac_minflt = tsk->min_flt; |
66 | stats->ac_majflt = tsk->maj_flt; | 70 | stats->ac_majflt = tsk->maj_flt; |
67 | 71 | ||