diff options
author | Jan Kara <jack@suse.cz> | 2014-06-04 19:11:34 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-06-04 19:54:16 -0400 |
commit | ca1d432ad8a527fabc5c7ceed8526e3a28de121c (patch) | |
tree | aeba2801756018b1b16267c55927746b2e19e283 /kernel | |
parent | 034633ccb24d675850f99bf85c1c5880c831e4b6 (diff) |
printk: remove outdated comment
Comment about interesting interlocking between lockbuf_lock and
console_sem is outdated.
It was added in 2002 by commit a880f45a48be during conversion of
console_lock to console_sem + lockbuf_lock.
At that time release_console_sem() (today's equivalent is
console_unlock()) was indeed using lockbuf_lock to avoid races between
trylock on console_sem in printk() and unlock of console_sem. However
these days the interlocking is gone and the races are avoided by
rechecking logbuf state after releasing console_sem.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/printk/printk.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 7476a53bc378..5bc54478c963 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c | |||
@@ -206,8 +206,7 @@ struct printk_log { | |||
206 | }; | 206 | }; |
207 | 207 | ||
208 | /* | 208 | /* |
209 | * The logbuf_lock protects kmsg buffer, indices, counters. It is also | 209 | * The logbuf_lock protects kmsg buffer, indices, counters. |
210 | * used in interesting ways to provide interlocking in console_unlock(); | ||
211 | */ | 210 | */ |
212 | static DEFINE_RAW_SPINLOCK(logbuf_lock); | 211 | static DEFINE_RAW_SPINLOCK(logbuf_lock); |
213 | 212 | ||