diff options
author | Tejun Heo <tj@kernel.org> | 2013-11-27 18:17:27 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2013-11-27 18:17:27 -0500 |
commit | c729b11edf7458a939556e1889446184f42f37a7 (patch) | |
tree | 157c8a20d0c9b0cf9b5835855c9bfe3bfacb98d6 /kernel | |
parent | edab95103d3a1eb5e3faf977eae4ad0b5bf5669c (diff) | |
parent | e605b36575e896edd8161534550c9ea021b03bc0 (diff) |
cgroup: Merge branch 'for-3.13-fixes' into for-3.14
Pull to receive e605b36575e8 ("cgroup: fix cgroup_subsys_state leak
for seq_files") as for-3.14 is scheduled to have a lot of changes
which depend on it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/cgroup.c | 5 | ||||
-rw-r--r-- | kernel/cpuset.c | 8 |
2 files changed, 10 insertions, 3 deletions
diff --git a/kernel/cgroup.c b/kernel/cgroup.c index be42967f4f1a..34fd1be0d9bf 100644 --- a/kernel/cgroup.c +++ b/kernel/cgroup.c | |||
@@ -166,6 +166,7 @@ static void cgroup_destroy_css_killed(struct cgroup *cgrp); | |||
166 | static int cgroup_destroy_locked(struct cgroup *cgrp); | 166 | static int cgroup_destroy_locked(struct cgroup *cgrp); |
167 | static int cgroup_addrm_files(struct cgroup *cgrp, struct cftype cfts[], | 167 | static int cgroup_addrm_files(struct cgroup *cgrp, struct cftype cfts[], |
168 | bool is_add); | 168 | bool is_add); |
169 | static int cgroup_file_release(struct inode *inode, struct file *file); | ||
169 | 170 | ||
170 | /** | 171 | /** |
171 | * cgroup_css - obtain a cgroup's css for the specified subsystem | 172 | * cgroup_css - obtain a cgroup's css for the specified subsystem |
@@ -2394,7 +2395,7 @@ static const struct file_operations cgroup_seqfile_operations = { | |||
2394 | .read = seq_read, | 2395 | .read = seq_read, |
2395 | .write = cgroup_file_write, | 2396 | .write = cgroup_file_write, |
2396 | .llseek = seq_lseek, | 2397 | .llseek = seq_lseek, |
2397 | .release = single_release, | 2398 | .release = cgroup_file_release, |
2398 | }; | 2399 | }; |
2399 | 2400 | ||
2400 | static int cgroup_file_open(struct inode *inode, struct file *file) | 2401 | static int cgroup_file_open(struct inode *inode, struct file *file) |
@@ -2455,6 +2456,8 @@ static int cgroup_file_release(struct inode *inode, struct file *file) | |||
2455 | ret = cft->release(inode, file); | 2456 | ret = cft->release(inode, file); |
2456 | if (css->ss) | 2457 | if (css->ss) |
2457 | css_put(css); | 2458 | css_put(css); |
2459 | if (file->f_op == &cgroup_seqfile_operations) | ||
2460 | single_release(inode, file); | ||
2458 | return ret; | 2461 | return ret; |
2459 | } | 2462 | } |
2460 | 2463 | ||
diff --git a/kernel/cpuset.c b/kernel/cpuset.c index 6bf981e13c43..4772034b4b17 100644 --- a/kernel/cpuset.c +++ b/kernel/cpuset.c | |||
@@ -1033,8 +1033,10 @@ static void cpuset_change_task_nodemask(struct task_struct *tsk, | |||
1033 | need_loop = task_has_mempolicy(tsk) || | 1033 | need_loop = task_has_mempolicy(tsk) || |
1034 | !nodes_intersects(*newmems, tsk->mems_allowed); | 1034 | !nodes_intersects(*newmems, tsk->mems_allowed); |
1035 | 1035 | ||
1036 | if (need_loop) | 1036 | if (need_loop) { |
1037 | local_irq_disable(); | ||
1037 | write_seqcount_begin(&tsk->mems_allowed_seq); | 1038 | write_seqcount_begin(&tsk->mems_allowed_seq); |
1039 | } | ||
1038 | 1040 | ||
1039 | nodes_or(tsk->mems_allowed, tsk->mems_allowed, *newmems); | 1041 | nodes_or(tsk->mems_allowed, tsk->mems_allowed, *newmems); |
1040 | mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP1); | 1042 | mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP1); |
@@ -1042,8 +1044,10 @@ static void cpuset_change_task_nodemask(struct task_struct *tsk, | |||
1042 | mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP2); | 1044 | mpol_rebind_task(tsk, newmems, MPOL_REBIND_STEP2); |
1043 | tsk->mems_allowed = *newmems; | 1045 | tsk->mems_allowed = *newmems; |
1044 | 1046 | ||
1045 | if (need_loop) | 1047 | if (need_loop) { |
1046 | write_seqcount_end(&tsk->mems_allowed_seq); | 1048 | write_seqcount_end(&tsk->mems_allowed_seq); |
1049 | local_irq_enable(); | ||
1050 | } | ||
1047 | 1051 | ||
1048 | task_unlock(tsk); | 1052 | task_unlock(tsk); |
1049 | } | 1053 | } |