diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2013-12-04 12:28:20 -0500 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2014-01-15 17:05:31 -0500 |
commit | 5acac1be499d979e3aa463ea73a498888faefcbe (patch) | |
tree | 5b3b38301cdeabe8d2efc77dbe743e6b7b23fea2 /kernel | |
parent | 1b3f82876006bd4172ca7696aa367baf96ec7c15 (diff) |
tick: Rename tick_check_idle() to tick_irq_enter()
This makes the code more symetric against the existing tick functions
called on irq exit: tick_irq_exit() and tick_nohz_irq_exit().
These function are also symetric as they mirror each other's action:
we start to account idle time on irq exit and we stop this accounting
on irq entry. Also the tick is stopped on irq exit and timekeeping
catches up with the tickless time elapsed until we reach irq entry.
This rename was suggested by Peter Zijlstra a long while ago but it
got forgotten in the mass.
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alex Shi <alex.shi@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Kevin Hilman <khilman@linaro.org>
Link: http://lkml.kernel.org/r/1387320692-28460-2-git-send-email-fweisbec@gmail.com
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/softirq.c | 2 | ||||
-rw-r--r-- | kernel/time/tick-sched.c | 8 |
2 files changed, 5 insertions, 5 deletions
diff --git a/kernel/softirq.c b/kernel/softirq.c index 11348de09400..ca9cb35a96d4 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c | |||
@@ -318,7 +318,7 @@ void irq_enter(void) | |||
318 | * here, as softirq will be serviced on return from interrupt. | 318 | * here, as softirq will be serviced on return from interrupt. |
319 | */ | 319 | */ |
320 | local_bh_disable(); | 320 | local_bh_disable(); |
321 | tick_check_idle(); | 321 | tick_irq_enter(); |
322 | _local_bh_enable(); | 322 | _local_bh_enable(); |
323 | } | 323 | } |
324 | 324 | ||
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 0ddd020bbaf2..e4d0f093061f 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c | |||
@@ -1023,7 +1023,7 @@ static void tick_nohz_kick_tick(struct tick_sched *ts, ktime_t now) | |||
1023 | #endif | 1023 | #endif |
1024 | } | 1024 | } |
1025 | 1025 | ||
1026 | static inline void tick_check_nohz_this_cpu(void) | 1026 | static inline void tick_nohz_irq_enter(void) |
1027 | { | 1027 | { |
1028 | struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched); | 1028 | struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched); |
1029 | ktime_t now; | 1029 | ktime_t now; |
@@ -1042,17 +1042,17 @@ static inline void tick_check_nohz_this_cpu(void) | |||
1042 | #else | 1042 | #else |
1043 | 1043 | ||
1044 | static inline void tick_nohz_switch_to_nohz(void) { } | 1044 | static inline void tick_nohz_switch_to_nohz(void) { } |
1045 | static inline void tick_check_nohz_this_cpu(void) { } | 1045 | static inline void tick_nohz_irq_enter(void) { } |
1046 | 1046 | ||
1047 | #endif /* CONFIG_NO_HZ_COMMON */ | 1047 | #endif /* CONFIG_NO_HZ_COMMON */ |
1048 | 1048 | ||
1049 | /* | 1049 | /* |
1050 | * Called from irq_enter to notify about the possible interruption of idle() | 1050 | * Called from irq_enter to notify about the possible interruption of idle() |
1051 | */ | 1051 | */ |
1052 | void tick_check_idle(void) | 1052 | void tick_irq_enter(void) |
1053 | { | 1053 | { |
1054 | tick_check_oneshot_broadcast_this_cpu(); | 1054 | tick_check_oneshot_broadcast_this_cpu(); |
1055 | tick_check_nohz_this_cpu(); | 1055 | tick_nohz_irq_enter(); |
1056 | } | 1056 | } |
1057 | 1057 | ||
1058 | /* | 1058 | /* |