diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2009-03-19 15:26:14 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-03-20 05:17:06 -0400 |
commit | 28bea271e58e429eccfad3d7ee2ad12d6ee015bf (patch) | |
tree | 00b5cf70bf147e7fad3b438835d21b093a2b9c28 /kernel | |
parent | 23725aeeab10ba02bcf10ec49ad73146b54cb52f (diff) |
ftrace: ensure every event gets an id
Impact: widen user-space visibe event IDs to all events
Previously only TRACE_EVENT events got ids, because only they
generated raw output which needs to be demuxed from the trace.
In order to provide a unique ID for each event, register everybody,
regardless.
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
LKML-Reference: <20090319194233.464914218@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/trace/trace_events_stage_3.h | 15 | ||||
-rw-r--r-- | kernel/trace/trace_output.c | 5 |
2 files changed, 19 insertions, 1 deletions
diff --git a/kernel/trace/trace_events_stage_3.h b/kernel/trace/trace_events_stage_3.h index ae2e323df0c7..4c26d97b4508 100644 --- a/kernel/trace/trace_events_stage_3.h +++ b/kernel/trace/trace_events_stage_3.h | |||
@@ -130,7 +130,19 @@ static void ftrace_unreg_event_##call(void) \ | |||
130 | { \ | 130 | { \ |
131 | unregister_trace_##call(ftrace_event_##call); \ | 131 | unregister_trace_##call(ftrace_event_##call); \ |
132 | } \ | 132 | } \ |
133 | 133 | \ | |
134 | static struct ftrace_event_call event_##call; \ | ||
135 | \ | ||
136 | static int ftrace_init_event_##call(void) \ | ||
137 | { \ | ||
138 | int id; \ | ||
139 | \ | ||
140 | id = register_ftrace_event(NULL); \ | ||
141 | if (!id) \ | ||
142 | return -ENODEV; \ | ||
143 | event_##call.id = id; \ | ||
144 | return 0; \ | ||
145 | } | ||
134 | 146 | ||
135 | #undef TRACE_FORMAT | 147 | #undef TRACE_FORMAT |
136 | #define TRACE_FORMAT(call, proto, args, fmt) \ | 148 | #define TRACE_FORMAT(call, proto, args, fmt) \ |
@@ -140,6 +152,7 @@ __attribute__((__aligned__(4))) \ | |||
140 | __attribute__((section("_ftrace_events"))) event_##call = { \ | 152 | __attribute__((section("_ftrace_events"))) event_##call = { \ |
141 | .name = #call, \ | 153 | .name = #call, \ |
142 | .system = __stringify(TRACE_SYSTEM), \ | 154 | .system = __stringify(TRACE_SYSTEM), \ |
155 | .raw_init = ftrace_init_event_##call, \ | ||
143 | .regfunc = ftrace_reg_event_##call, \ | 156 | .regfunc = ftrace_reg_event_##call, \ |
144 | .unregfunc = ftrace_unreg_event_##call, \ | 157 | .unregfunc = ftrace_unreg_event_##call, \ |
145 | } | 158 | } |
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c index b45141748af5..19261fdd2455 100644 --- a/kernel/trace/trace_output.c +++ b/kernel/trace/trace_output.c | |||
@@ -481,6 +481,11 @@ int register_ftrace_event(struct trace_event *event) | |||
481 | 481 | ||
482 | mutex_lock(&trace_event_mutex); | 482 | mutex_lock(&trace_event_mutex); |
483 | 483 | ||
484 | if (!event) { | ||
485 | ret = next_event_type++; | ||
486 | goto out; | ||
487 | } | ||
488 | |||
484 | if (!event->type) | 489 | if (!event->type) |
485 | event->type = next_event_type++; | 490 | event->type = next_event_type++; |
486 | else if (event->type > __TRACE_LAST_TYPE) { | 491 | else if (event->type > __TRACE_LAST_TYPE) { |