diff options
| author | Oleg Nesterov <oleg@tv-sign.ru> | 2006-09-29 05:00:55 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-09-29 12:18:18 -0400 |
| commit | d359b549bf3d7f42f0084918a4816ea4572e507c (patch) | |
| tree | a154a9b1913a459bdaed49c623d39f1e73689295 /kernel | |
| parent | 44938af6e08580514abce8bea23ae1c034ea0b1d (diff) | |
[PATCH] futex_find_get_task(): don't take tasklist_lock
It is ok to do find_task_by_pid() + get_task_struct() under
rcu_read_lock(), we cand drop tasklist_lock.
Note that testing of ->exit_state is racy with or without tasklist anyway.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/futex.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/futex.c b/kernel/futex.c index 9d260e838cff..ca8ef11feb65 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
| @@ -389,7 +389,7 @@ static struct task_struct * futex_find_get_task(pid_t pid) | |||
| 389 | { | 389 | { |
| 390 | struct task_struct *p; | 390 | struct task_struct *p; |
| 391 | 391 | ||
| 392 | read_lock(&tasklist_lock); | 392 | rcu_read_lock(); |
| 393 | p = find_task_by_pid(pid); | 393 | p = find_task_by_pid(pid); |
| 394 | if (!p) | 394 | if (!p) |
| 395 | goto out_unlock; | 395 | goto out_unlock; |
| @@ -403,7 +403,7 @@ static struct task_struct * futex_find_get_task(pid_t pid) | |||
| 403 | } | 403 | } |
| 404 | get_task_struct(p); | 404 | get_task_struct(p); |
| 405 | out_unlock: | 405 | out_unlock: |
| 406 | read_unlock(&tasklist_lock); | 406 | rcu_read_unlock(); |
| 407 | 407 | ||
| 408 | return p; | 408 | return p; |
| 409 | } | 409 | } |
