diff options
| author | Ingo Molnar <mingo@elte.hu> | 2009-09-06 00:11:38 -0400 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-09-06 00:11:42 -0400 |
| commit | ed011b22ce567eabefa9ea571d3721c10ecd0553 (patch) | |
| tree | c7aee6684613075c772388a99a9137014549434e /kernel | |
| parent | 85bac32c4a52c592b857f2c360cc5ec93a097d70 (diff) | |
| parent | e07cccf4046978df10f2e13fe2b99b2f9b3a65db (diff) | |
Merge commit 'v2.6.31-rc9' into tracing/core
Merge reason: move from -rc5 to -rc9.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/fork.c | 21 | ||||
| -rw-r--r-- | kernel/futex.c | 28 | ||||
| -rw-r--r-- | kernel/futex_compat.c | 6 | ||||
| -rw-r--r-- | kernel/irq/manage.c | 27 | ||||
| -rw-r--r-- | kernel/module.c | 10 | ||||
| -rw-r--r-- | kernel/perf_counter.c | 356 | ||||
| -rw-r--r-- | kernel/sysctl.c | 7 | ||||
| -rw-r--r-- | kernel/time/clockevents.c | 16 | ||||
| -rw-r--r-- | kernel/time/tick-broadcast.c | 7 | ||||
| -rw-r--r-- | kernel/time/timer_list.c | 2 | ||||
| -rw-r--r-- | kernel/trace/blktrace.c | 12 | ||||
| -rw-r--r-- | kernel/trace/ftrace.c | 17 | ||||
| -rw-r--r-- | kernel/trace/trace.c | 12 | ||||
| -rw-r--r-- | kernel/wait.c | 5 |
14 files changed, 342 insertions, 184 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index 021e1138556e..e6c04d462ab2 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
| @@ -426,7 +426,6 @@ static struct mm_struct * mm_init(struct mm_struct * mm, struct task_struct *p) | |||
| 426 | init_rwsem(&mm->mmap_sem); | 426 | init_rwsem(&mm->mmap_sem); |
| 427 | INIT_LIST_HEAD(&mm->mmlist); | 427 | INIT_LIST_HEAD(&mm->mmlist); |
| 428 | mm->flags = (current->mm) ? current->mm->flags : default_dump_filter; | 428 | mm->flags = (current->mm) ? current->mm->flags : default_dump_filter; |
| 429 | mm->oom_adj = (current->mm) ? current->mm->oom_adj : 0; | ||
| 430 | mm->core_state = NULL; | 429 | mm->core_state = NULL; |
| 431 | mm->nr_ptes = 0; | 430 | mm->nr_ptes = 0; |
| 432 | set_mm_counter(mm, file_rss, 0); | 431 | set_mm_counter(mm, file_rss, 0); |
| @@ -816,11 +815,8 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) | |||
| 816 | { | 815 | { |
| 817 | struct signal_struct *sig; | 816 | struct signal_struct *sig; |
| 818 | 817 | ||
| 819 | if (clone_flags & CLONE_THREAD) { | 818 | if (clone_flags & CLONE_THREAD) |
| 820 | atomic_inc(¤t->signal->count); | ||
| 821 | atomic_inc(¤t->signal->live); | ||
| 822 | return 0; | 819 | return 0; |
| 823 | } | ||
| 824 | 820 | ||
| 825 | sig = kmem_cache_alloc(signal_cachep, GFP_KERNEL); | 821 | sig = kmem_cache_alloc(signal_cachep, GFP_KERNEL); |
| 826 | tsk->signal = sig; | 822 | tsk->signal = sig; |
| @@ -878,16 +874,6 @@ void __cleanup_signal(struct signal_struct *sig) | |||
| 878 | kmem_cache_free(signal_cachep, sig); | 874 | kmem_cache_free(signal_cachep, sig); |
| 879 | } | 875 | } |
| 880 | 876 | ||
| 881 | static void cleanup_signal(struct task_struct *tsk) | ||
| 882 | { | ||
| 883 | struct signal_struct *sig = tsk->signal; | ||
| 884 | |||
| 885 | atomic_dec(&sig->live); | ||
| 886 | |||
| 887 | if (atomic_dec_and_test(&sig->count)) | ||
| 888 | __cleanup_signal(sig); | ||
| 889 | } | ||
| 890 | |||
| 891 | static void copy_flags(unsigned long clone_flags, struct task_struct *p) | 877 | static void copy_flags(unsigned long clone_flags, struct task_struct *p) |
| 892 | { | 878 | { |
| 893 | unsigned long new_flags = p->flags; | 879 | unsigned long new_flags = p->flags; |
| @@ -1240,6 +1226,8 @@ static struct task_struct *copy_process(unsigned long clone_flags, | |||
| 1240 | } | 1226 | } |
| 1241 | 1227 | ||
| 1242 | if (clone_flags & CLONE_THREAD) { | 1228 | if (clone_flags & CLONE_THREAD) { |
| 1229 | atomic_inc(¤t->signal->count); | ||
| 1230 | atomic_inc(¤t->signal->live); | ||
| 1243 | p->group_leader = current->group_leader; | 1231 | p->group_leader = current->group_leader; |
| 1244 | list_add_tail_rcu(&p->thread_group, &p->group_leader->thread_group); | 1232 | list_add_tail_rcu(&p->thread_group, &p->group_leader->thread_group); |
| 1245 | } | 1233 | } |
| @@ -1283,7 +1271,8 @@ bad_fork_cleanup_mm: | |||
| 1283 | if (p->mm) | 1271 | if (p->mm) |
| 1284 | mmput(p->mm); | 1272 | mmput(p->mm); |
| 1285 | bad_fork_cleanup_signal: | 1273 | bad_fork_cleanup_signal: |
| 1286 | cleanup_signal(p); | 1274 | if (!(clone_flags & CLONE_THREAD)) |
| 1275 | __cleanup_signal(p->signal); | ||
| 1287 | bad_fork_cleanup_sighand: | 1276 | bad_fork_cleanup_sighand: |
| 1288 | __cleanup_sighand(p->sighand); | 1277 | __cleanup_sighand(p->sighand); |
| 1289 | bad_fork_cleanup_fs: | 1278 | bad_fork_cleanup_fs: |
diff --git a/kernel/futex.c b/kernel/futex.c index 0672ff88f159..e18cfbdc7190 100644 --- a/kernel/futex.c +++ b/kernel/futex.c | |||
| @@ -1010,15 +1010,19 @@ void requeue_futex(struct futex_q *q, struct futex_hash_bucket *hb1, | |||
| 1010 | * requeue_pi_wake_futex() - Wake a task that acquired the lock during requeue | 1010 | * requeue_pi_wake_futex() - Wake a task that acquired the lock during requeue |
| 1011 | * q: the futex_q | 1011 | * q: the futex_q |
| 1012 | * key: the key of the requeue target futex | 1012 | * key: the key of the requeue target futex |
| 1013 | * hb: the hash_bucket of the requeue target futex | ||
| 1013 | * | 1014 | * |
| 1014 | * During futex_requeue, with requeue_pi=1, it is possible to acquire the | 1015 | * During futex_requeue, with requeue_pi=1, it is possible to acquire the |
| 1015 | * target futex if it is uncontended or via a lock steal. Set the futex_q key | 1016 | * target futex if it is uncontended or via a lock steal. Set the futex_q key |
| 1016 | * to the requeue target futex so the waiter can detect the wakeup on the right | 1017 | * to the requeue target futex so the waiter can detect the wakeup on the right |
| 1017 | * futex, but remove it from the hb and NULL the rt_waiter so it can detect | 1018 | * futex, but remove it from the hb and NULL the rt_waiter so it can detect |
| 1018 | * atomic lock acquisition. Must be called with the q->lock_ptr held. | 1019 | * atomic lock acquisition. Set the q->lock_ptr to the requeue target hb->lock |
| 1020 | * to protect access to the pi_state to fixup the owner later. Must be called | ||
| 1021 | * with both q->lock_ptr and hb->lock held. | ||
| 1019 | */ | 1022 | */ |
| 1020 | static inline | 1023 | static inline |
| 1021 | void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key) | 1024 | void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key, |
| 1025 | struct futex_hash_bucket *hb) | ||
| 1022 | { | 1026 | { |
| 1023 | drop_futex_key_refs(&q->key); | 1027 | drop_futex_key_refs(&q->key); |
| 1024 | get_futex_key_refs(key); | 1028 | get_futex_key_refs(key); |
| @@ -1030,6 +1034,11 @@ void requeue_pi_wake_futex(struct futex_q *q, union futex_key *key) | |||
| 1030 | WARN_ON(!q->rt_waiter); | 1034 | WARN_ON(!q->rt_waiter); |
| 1031 | q->rt_waiter = NULL; | 1035 | q->rt_waiter = NULL; |
| 1032 | 1036 | ||
| 1037 | q->lock_ptr = &hb->lock; | ||
| 1038 | #ifdef CONFIG_DEBUG_PI_LIST | ||
| 1039 | q->list.plist.lock = &hb->lock; | ||
| 1040 | #endif | ||
| 1041 | |||
| 1033 | wake_up_state(q->task, TASK_NORMAL); | 1042 | wake_up_state(q->task, TASK_NORMAL); |
| 1034 | } | 1043 | } |
| 1035 | 1044 | ||
| @@ -1088,7 +1097,7 @@ static int futex_proxy_trylock_atomic(u32 __user *pifutex, | |||
| 1088 | ret = futex_lock_pi_atomic(pifutex, hb2, key2, ps, top_waiter->task, | 1097 | ret = futex_lock_pi_atomic(pifutex, hb2, key2, ps, top_waiter->task, |
| 1089 | set_waiters); | 1098 | set_waiters); |
| 1090 | if (ret == 1) | 1099 | if (ret == 1) |
| 1091 | requeue_pi_wake_futex(top_waiter, key2); | 1100 | requeue_pi_wake_futex(top_waiter, key2, hb2); |
| 1092 | 1101 | ||
| 1093 | return ret; | 1102 | return ret; |
| 1094 | } | 1103 | } |
| @@ -1247,8 +1256,15 @@ retry_private: | |||
| 1247 | if (!match_futex(&this->key, &key1)) | 1256 | if (!match_futex(&this->key, &key1)) |
| 1248 | continue; | 1257 | continue; |
| 1249 | 1258 | ||
| 1250 | WARN_ON(!requeue_pi && this->rt_waiter); | 1259 | /* |
| 1251 | WARN_ON(requeue_pi && !this->rt_waiter); | 1260 | * FUTEX_WAIT_REQEUE_PI and FUTEX_CMP_REQUEUE_PI should always |
| 1261 | * be paired with each other and no other futex ops. | ||
| 1262 | */ | ||
| 1263 | if ((requeue_pi && !this->rt_waiter) || | ||
| 1264 | (!requeue_pi && this->rt_waiter)) { | ||
| 1265 | ret = -EINVAL; | ||
| 1266 | break; | ||
| 1267 | } | ||
| 1252 | 1268 | ||
| 1253 | /* | 1269 | /* |
| 1254 | * Wake nr_wake waiters. For requeue_pi, if we acquired the | 1270 | * Wake nr_wake waiters. For requeue_pi, if we acquired the |
| @@ -1273,7 +1289,7 @@ retry_private: | |||
| 1273 | this->task, 1); | 1289 | this->task, 1); |
| 1274 | if (ret == 1) { | 1290 | if (ret == 1) { |
| 1275 | /* We got the lock. */ | 1291 | /* We got the lock. */ |
| 1276 | requeue_pi_wake_futex(this, &key2); | 1292 | requeue_pi_wake_futex(this, &key2, hb2); |
| 1277 | continue; | 1293 | continue; |
| 1278 | } else if (ret) { | 1294 | } else if (ret) { |
| 1279 | /* -EDEADLK */ | 1295 | /* -EDEADLK */ |
diff --git a/kernel/futex_compat.c b/kernel/futex_compat.c index d607a5b9ee29..235716556bf1 100644 --- a/kernel/futex_compat.c +++ b/kernel/futex_compat.c | |||
| @@ -180,7 +180,8 @@ asmlinkage long compat_sys_futex(u32 __user *uaddr, int op, u32 val, | |||
| 180 | int cmd = op & FUTEX_CMD_MASK; | 180 | int cmd = op & FUTEX_CMD_MASK; |
| 181 | 181 | ||
| 182 | if (utime && (cmd == FUTEX_WAIT || cmd == FUTEX_LOCK_PI || | 182 | if (utime && (cmd == FUTEX_WAIT || cmd == FUTEX_LOCK_PI || |
| 183 | cmd == FUTEX_WAIT_BITSET)) { | 183 | cmd == FUTEX_WAIT_BITSET || |
| 184 | cmd == FUTEX_WAIT_REQUEUE_PI)) { | ||
| 184 | if (get_compat_timespec(&ts, utime)) | 185 | if (get_compat_timespec(&ts, utime)) |
| 185 | return -EFAULT; | 186 | return -EFAULT; |
| 186 | if (!timespec_valid(&ts)) | 187 | if (!timespec_valid(&ts)) |
| @@ -191,7 +192,8 @@ asmlinkage long compat_sys_futex(u32 __user *uaddr, int op, u32 val, | |||
| 191 | t = ktime_add_safe(ktime_get(), t); | 192 | t = ktime_add_safe(ktime_get(), t); |
| 192 | tp = &t; | 193 | tp = &t; |
| 193 | } | 194 | } |
| 194 | if (cmd == FUTEX_REQUEUE || cmd == FUTEX_CMP_REQUEUE) | 195 | if (cmd == FUTEX_REQUEUE || cmd == FUTEX_CMP_REQUEUE || |
| 196 | cmd == FUTEX_CMP_REQUEUE_PI || cmd == FUTEX_WAKE_OP) | ||
| 195 | val2 = (int) (unsigned long) utime; | 197 | val2 = (int) (unsigned long) utime; |
| 196 | 198 | ||
| 197 | return do_futex(uaddr, op, val, tp, uaddr2, val2, val3); | 199 | return do_futex(uaddr, op, val, tp, uaddr2, val2, val3); |
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 61c679db4687..0ec9ed831737 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c | |||
| @@ -607,7 +607,6 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
| 607 | */ | 607 | */ |
| 608 | get_task_struct(t); | 608 | get_task_struct(t); |
| 609 | new->thread = t; | 609 | new->thread = t; |
| 610 | wake_up_process(t); | ||
| 611 | } | 610 | } |
| 612 | 611 | ||
| 613 | /* | 612 | /* |
| @@ -690,6 +689,7 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
| 690 | (int)(new->flags & IRQF_TRIGGER_MASK)); | 689 | (int)(new->flags & IRQF_TRIGGER_MASK)); |
| 691 | } | 690 | } |
| 692 | 691 | ||
| 692 | new->irq = irq; | ||
| 693 | *old_ptr = new; | 693 | *old_ptr = new; |
| 694 | 694 | ||
| 695 | /* Reset broken irq detection when installing new handler */ | 695 | /* Reset broken irq detection when installing new handler */ |
| @@ -707,7 +707,13 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) | |||
| 707 | 707 | ||
| 708 | spin_unlock_irqrestore(&desc->lock, flags); | 708 | spin_unlock_irqrestore(&desc->lock, flags); |
| 709 | 709 | ||
| 710 | new->irq = irq; | 710 | /* |
| 711 | * Strictly no need to wake it up, but hung_task complains | ||
| 712 | * when no hard interrupt wakes the thread up. | ||
| 713 | */ | ||
| 714 | if (new->thread) | ||
| 715 | wake_up_process(new->thread); | ||
| 716 | |||
| 711 | register_irq_proc(irq, desc); | 717 | register_irq_proc(irq, desc); |
| 712 | new->dir = NULL; | 718 | new->dir = NULL; |
| 713 | register_handler_proc(irq, new); | 719 | register_handler_proc(irq, new); |
| @@ -761,7 +767,6 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) | |||
| 761 | { | 767 | { |
| 762 | struct irq_desc *desc = irq_to_desc(irq); | 768 | struct irq_desc *desc = irq_to_desc(irq); |
| 763 | struct irqaction *action, **action_ptr; | 769 | struct irqaction *action, **action_ptr; |
| 764 | struct task_struct *irqthread; | ||
| 765 | unsigned long flags; | 770 | unsigned long flags; |
| 766 | 771 | ||
| 767 | WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); | 772 | WARN(in_interrupt(), "Trying to free IRQ %d from IRQ context!\n", irq); |
| @@ -809,9 +814,6 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) | |||
| 809 | desc->chip->disable(irq); | 814 | desc->chip->disable(irq); |
| 810 | } | 815 | } |
| 811 | 816 | ||
| 812 | irqthread = action->thread; | ||
| 813 | action->thread = NULL; | ||
| 814 | |||
| 815 | spin_unlock_irqrestore(&desc->lock, flags); | 817 | spin_unlock_irqrestore(&desc->lock, flags); |
| 816 | 818 | ||
| 817 | unregister_handler_proc(irq, action); | 819 | unregister_handler_proc(irq, action); |
| @@ -819,12 +821,6 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) | |||
| 819 | /* Make sure it's not being used on another CPU: */ | 821 | /* Make sure it's not being used on another CPU: */ |
| 820 | synchronize_irq(irq); | 822 | synchronize_irq(irq); |
| 821 | 823 | ||
| 822 | if (irqthread) { | ||
| 823 | if (!test_bit(IRQTF_DIED, &action->thread_flags)) | ||
| 824 | kthread_stop(irqthread); | ||
| 825 | put_task_struct(irqthread); | ||
| 826 | } | ||
| 827 | |||
| 828 | #ifdef CONFIG_DEBUG_SHIRQ | 824 | #ifdef CONFIG_DEBUG_SHIRQ |
| 829 | /* | 825 | /* |
| 830 | * It's a shared IRQ -- the driver ought to be prepared for an IRQ | 826 | * It's a shared IRQ -- the driver ought to be prepared for an IRQ |
| @@ -840,6 +836,13 @@ static struct irqaction *__free_irq(unsigned int irq, void *dev_id) | |||
| 840 | local_irq_restore(flags); | 836 | local_irq_restore(flags); |
| 841 | } | 837 | } |
| 842 | #endif | 838 | #endif |
| 839 | |||
| 840 | if (action->thread) { | ||
| 841 | if (!test_bit(IRQTF_DIED, &action->thread_flags)) | ||
| 842 | kthread_stop(action->thread); | ||
| 843 | put_task_struct(action->thread); | ||
| 844 | } | ||
| 845 | |||
| 843 | return action; | 846 | return action; |
| 844 | } | 847 | } |
| 845 | 848 | ||
diff --git a/kernel/module.c b/kernel/module.c index b1821438694e..46580edff0cb 100644 --- a/kernel/module.c +++ b/kernel/module.c | |||
| @@ -914,16 +914,18 @@ void __symbol_put(const char *symbol) | |||
| 914 | } | 914 | } |
| 915 | EXPORT_SYMBOL(__symbol_put); | 915 | EXPORT_SYMBOL(__symbol_put); |
| 916 | 916 | ||
| 917 | /* Note this assumes addr is a function, which it currently always is. */ | ||
| 917 | void symbol_put_addr(void *addr) | 918 | void symbol_put_addr(void *addr) |
| 918 | { | 919 | { |
| 919 | struct module *modaddr; | 920 | struct module *modaddr; |
| 921 | unsigned long a = (unsigned long)dereference_function_descriptor(addr); | ||
| 920 | 922 | ||
| 921 | if (core_kernel_text((unsigned long)addr)) | 923 | if (core_kernel_text(a)) |
| 922 | return; | 924 | return; |
| 923 | 925 | ||
| 924 | /* module_text_address is safe here: we're supposed to have reference | 926 | /* module_text_address is safe here: we're supposed to have reference |
| 925 | * to module from symbol_get, so it can't go away. */ | 927 | * to module from symbol_get, so it can't go away. */ |
| 926 | modaddr = __module_text_address((unsigned long)addr); | 928 | modaddr = __module_text_address(a); |
| 927 | BUG_ON(!modaddr); | 929 | BUG_ON(!modaddr); |
| 928 | module_put(modaddr); | 930 | module_put(modaddr); |
| 929 | } | 931 | } |
| @@ -1279,6 +1281,10 @@ static void add_notes_attrs(struct module *mod, unsigned int nsect, | |||
| 1279 | struct module_notes_attrs *notes_attrs; | 1281 | struct module_notes_attrs *notes_attrs; |
| 1280 | struct bin_attribute *nattr; | 1282 | struct bin_attribute *nattr; |
| 1281 | 1283 | ||
| 1284 | /* failed to create section attributes, so can't create notes */ | ||
| 1285 | if (!mod->sect_attrs) | ||
| 1286 | return; | ||
| 1287 | |||
| 1282 | /* Count notes sections and allocate structures. */ | 1288 | /* Count notes sections and allocate structures. */ |
| 1283 | notes = 0; | 1289 | notes = 0; |
| 1284 | for (i = 0; i < nsect; i++) | 1290 | for (i = 0; i < nsect; i++) |
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c index b0b20a07f394..d7cbc579fc80 100644 --- a/kernel/perf_counter.c +++ b/kernel/perf_counter.c | |||
| @@ -50,7 +50,7 @@ static atomic_t nr_task_counters __read_mostly; | |||
| 50 | * 1 - disallow cpu counters to unpriv | 50 | * 1 - disallow cpu counters to unpriv |
| 51 | * 2 - disallow kernel profiling to unpriv | 51 | * 2 - disallow kernel profiling to unpriv |
| 52 | */ | 52 | */ |
| 53 | int sysctl_perf_counter_paranoid __read_mostly; | 53 | int sysctl_perf_counter_paranoid __read_mostly = 1; |
| 54 | 54 | ||
| 55 | static inline bool perf_paranoid_cpu(void) | 55 | static inline bool perf_paranoid_cpu(void) |
| 56 | { | 56 | { |
| @@ -88,6 +88,7 @@ void __weak hw_perf_disable(void) { barrier(); } | |||
| 88 | void __weak hw_perf_enable(void) { barrier(); } | 88 | void __weak hw_perf_enable(void) { barrier(); } |
| 89 | 89 | ||
| 90 | void __weak hw_perf_counter_setup(int cpu) { barrier(); } | 90 | void __weak hw_perf_counter_setup(int cpu) { barrier(); } |
| 91 | void __weak hw_perf_counter_setup_online(int cpu) { barrier(); } | ||
| 91 | 92 | ||
| 92 | int __weak | 93 | int __weak |
| 93 | hw_perf_group_sched_in(struct perf_counter *group_leader, | 94 | hw_perf_group_sched_in(struct perf_counter *group_leader, |
| @@ -306,6 +307,10 @@ counter_sched_out(struct perf_counter *counter, | |||
| 306 | return; | 307 | return; |
| 307 | 308 | ||
| 308 | counter->state = PERF_COUNTER_STATE_INACTIVE; | 309 | counter->state = PERF_COUNTER_STATE_INACTIVE; |
| 310 | if (counter->pending_disable) { | ||
| 311 | counter->pending_disable = 0; | ||
| 312 | counter->state = PERF_COUNTER_STATE_OFF; | ||
| 313 | } | ||
| 309 | counter->tstamp_stopped = ctx->time; | 314 | counter->tstamp_stopped = ctx->time; |
| 310 | counter->pmu->disable(counter); | 315 | counter->pmu->disable(counter); |
| 311 | counter->oncpu = -1; | 316 | counter->oncpu = -1; |
| @@ -1498,10 +1503,21 @@ static void perf_counter_enable_on_exec(struct task_struct *task) | |||
| 1498 | */ | 1503 | */ |
| 1499 | static void __perf_counter_read(void *info) | 1504 | static void __perf_counter_read(void *info) |
| 1500 | { | 1505 | { |
| 1506 | struct perf_cpu_context *cpuctx = &__get_cpu_var(perf_cpu_context); | ||
| 1501 | struct perf_counter *counter = info; | 1507 | struct perf_counter *counter = info; |
| 1502 | struct perf_counter_context *ctx = counter->ctx; | 1508 | struct perf_counter_context *ctx = counter->ctx; |
| 1503 | unsigned long flags; | 1509 | unsigned long flags; |
| 1504 | 1510 | ||
| 1511 | /* | ||
| 1512 | * If this is a task context, we need to check whether it is | ||
| 1513 | * the current task context of this cpu. If not it has been | ||
| 1514 | * scheduled out before the smp call arrived. In that case | ||
| 1515 | * counter->count would have been updated to a recent sample | ||
| 1516 | * when the counter was scheduled out. | ||
| 1517 | */ | ||
| 1518 | if (ctx->task && cpuctx->task_ctx != ctx) | ||
| 1519 | return; | ||
| 1520 | |||
| 1505 | local_irq_save(flags); | 1521 | local_irq_save(flags); |
| 1506 | if (ctx->is_active) | 1522 | if (ctx->is_active) |
| 1507 | update_context_time(ctx); | 1523 | update_context_time(ctx); |
| @@ -1691,7 +1707,32 @@ static int perf_release(struct inode *inode, struct file *file) | |||
| 1691 | return 0; | 1707 | return 0; |
| 1692 | } | 1708 | } |
| 1693 | 1709 | ||
| 1694 | static u64 perf_counter_read_tree(struct perf_counter *counter) | 1710 | static int perf_counter_read_size(struct perf_counter *counter) |
| 1711 | { | ||
| 1712 | int entry = sizeof(u64); /* value */ | ||
| 1713 | int size = 0; | ||
| 1714 | int nr = 1; | ||
| 1715 | |||
| 1716 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) | ||
| 1717 | size += sizeof(u64); | ||
| 1718 | |||
| 1719 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) | ||
| 1720 | size += sizeof(u64); | ||
| 1721 | |||
| 1722 | if (counter->attr.read_format & PERF_FORMAT_ID) | ||
| 1723 | entry += sizeof(u64); | ||
| 1724 | |||
| 1725 | if (counter->attr.read_format & PERF_FORMAT_GROUP) { | ||
| 1726 | nr += counter->group_leader->nr_siblings; | ||
| 1727 | size += sizeof(u64); | ||
| 1728 | } | ||
| 1729 | |||
| 1730 | size += entry * nr; | ||
| 1731 | |||
| 1732 | return size; | ||
| 1733 | } | ||
| 1734 | |||
| 1735 | static u64 perf_counter_read_value(struct perf_counter *counter) | ||
| 1695 | { | 1736 | { |
| 1696 | struct perf_counter *child; | 1737 | struct perf_counter *child; |
| 1697 | u64 total = 0; | 1738 | u64 total = 0; |
| @@ -1703,14 +1744,96 @@ static u64 perf_counter_read_tree(struct perf_counter *counter) | |||
| 1703 | return total; | 1744 | return total; |
| 1704 | } | 1745 | } |
| 1705 | 1746 | ||
| 1747 | static int perf_counter_read_entry(struct perf_counter *counter, | ||
| 1748 | u64 read_format, char __user *buf) | ||
| 1749 | { | ||
| 1750 | int n = 0, count = 0; | ||
| 1751 | u64 values[2]; | ||
| 1752 | |||
| 1753 | values[n++] = perf_counter_read_value(counter); | ||
| 1754 | if (read_format & PERF_FORMAT_ID) | ||
| 1755 | values[n++] = primary_counter_id(counter); | ||
| 1756 | |||
| 1757 | count = n * sizeof(u64); | ||
| 1758 | |||
| 1759 | if (copy_to_user(buf, values, count)) | ||
| 1760 | return -EFAULT; | ||
| 1761 | |||
| 1762 | return count; | ||
| 1763 | } | ||
| 1764 | |||
| 1765 | static int perf_counter_read_group(struct perf_counter *counter, | ||
| 1766 | u64 read_format, char __user *buf) | ||
| 1767 | { | ||
| 1768 | struct perf_counter *leader = counter->group_leader, *sub; | ||
| 1769 | int n = 0, size = 0, err = -EFAULT; | ||
| 1770 | u64 values[3]; | ||
| 1771 | |||
| 1772 | values[n++] = 1 + leader->nr_siblings; | ||
| 1773 | if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) { | ||
| 1774 | values[n++] = leader->total_time_enabled + | ||
| 1775 | atomic64_read(&leader->child_total_time_enabled); | ||
| 1776 | } | ||
| 1777 | if (read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) { | ||
| 1778 | values[n++] = leader->total_time_running + | ||
| 1779 | atomic64_read(&leader->child_total_time_running); | ||
| 1780 | } | ||
| 1781 | |||
| 1782 | size = n * sizeof(u64); | ||
| 1783 | |||
| 1784 | if (copy_to_user(buf, values, size)) | ||
| 1785 | return -EFAULT; | ||
| 1786 | |||
| 1787 | err = perf_counter_read_entry(leader, read_format, buf + size); | ||
| 1788 | if (err < 0) | ||
| 1789 | return err; | ||
| 1790 | |||
| 1791 | size += err; | ||
| 1792 | |||
| 1793 | list_for_each_entry(sub, &leader->sibling_list, list_entry) { | ||
| 1794 | err = perf_counter_read_entry(sub, read_format, | ||
| 1795 | buf + size); | ||
| 1796 | if (err < 0) | ||
| 1797 | return err; | ||
| 1798 | |||
| 1799 | size += err; | ||
| 1800 | } | ||
| 1801 | |||
| 1802 | return size; | ||
| 1803 | } | ||
| 1804 | |||
| 1805 | static int perf_counter_read_one(struct perf_counter *counter, | ||
| 1806 | u64 read_format, char __user *buf) | ||
| 1807 | { | ||
| 1808 | u64 values[4]; | ||
| 1809 | int n = 0; | ||
| 1810 | |||
| 1811 | values[n++] = perf_counter_read_value(counter); | ||
| 1812 | if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) { | ||
| 1813 | values[n++] = counter->total_time_enabled + | ||
| 1814 | atomic64_read(&counter->child_total_time_enabled); | ||
| 1815 | } | ||
| 1816 | if (read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) { | ||
| 1817 | values[n++] = counter->total_time_running + | ||
| 1818 | atomic64_read(&counter->child_total_time_running); | ||
| 1819 | } | ||
| 1820 | if (read_format & PERF_FORMAT_ID) | ||
| 1821 | values[n++] = primary_counter_id(counter); | ||
| 1822 | |||
| 1823 | if (copy_to_user(buf, values, n * sizeof(u64))) | ||
| 1824 | return -EFAULT; | ||
| 1825 | |||
| 1826 | return n * sizeof(u64); | ||
| 1827 | } | ||
| 1828 | |||
| 1706 | /* | 1829 | /* |
| 1707 | * Read the performance counter - simple non blocking version for now | 1830 | * Read the performance counter - simple non blocking version for now |
| 1708 | */ | 1831 | */ |
| 1709 | static ssize_t | 1832 | static ssize_t |
| 1710 | perf_read_hw(struct perf_counter *counter, char __user *buf, size_t count) | 1833 | perf_read_hw(struct perf_counter *counter, char __user *buf, size_t count) |
| 1711 | { | 1834 | { |
| 1712 | u64 values[4]; | 1835 | u64 read_format = counter->attr.read_format; |
| 1713 | int n; | 1836 | int ret; |
| 1714 | 1837 | ||
| 1715 | /* | 1838 | /* |
| 1716 | * Return end-of-file for a read on a counter that is in | 1839 | * Return end-of-file for a read on a counter that is in |
| @@ -1720,28 +1843,18 @@ perf_read_hw(struct perf_counter *counter, char __user *buf, size_t count) | |||
| 1720 | if (counter->state == PERF_COUNTER_STATE_ERROR) | 1843 | if (counter->state == PERF_COUNTER_STATE_ERROR) |
| 1721 | return 0; | 1844 | return 0; |
| 1722 | 1845 | ||
| 1846 | if (count < perf_counter_read_size(counter)) | ||
| 1847 | return -ENOSPC; | ||
| 1848 | |||
| 1723 | WARN_ON_ONCE(counter->ctx->parent_ctx); | 1849 | WARN_ON_ONCE(counter->ctx->parent_ctx); |
| 1724 | mutex_lock(&counter->child_mutex); | 1850 | mutex_lock(&counter->child_mutex); |
| 1725 | values[0] = perf_counter_read_tree(counter); | 1851 | if (read_format & PERF_FORMAT_GROUP) |
| 1726 | n = 1; | 1852 | ret = perf_counter_read_group(counter, read_format, buf); |
| 1727 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) | 1853 | else |
| 1728 | values[n++] = counter->total_time_enabled + | 1854 | ret = perf_counter_read_one(counter, read_format, buf); |
| 1729 | atomic64_read(&counter->child_total_time_enabled); | ||
| 1730 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) | ||
| 1731 | values[n++] = counter->total_time_running + | ||
| 1732 | atomic64_read(&counter->child_total_time_running); | ||
| 1733 | if (counter->attr.read_format & PERF_FORMAT_ID) | ||
| 1734 | values[n++] = primary_counter_id(counter); | ||
| 1735 | mutex_unlock(&counter->child_mutex); | 1855 | mutex_unlock(&counter->child_mutex); |
| 1736 | 1856 | ||
| 1737 | if (count < n * sizeof(u64)) | 1857 | return ret; |
| 1738 | return -EINVAL; | ||
| 1739 | count = n * sizeof(u64); | ||
| 1740 | |||
| 1741 | if (copy_to_user(buf, values, count)) | ||
| 1742 | return -EFAULT; | ||
| 1743 | |||
| 1744 | return count; | ||
| 1745 | } | 1858 | } |
| 1746 | 1859 | ||
| 1747 | static ssize_t | 1860 | static ssize_t |
| @@ -1906,6 +2019,10 @@ int perf_counter_task_disable(void) | |||
| 1906 | return 0; | 2019 | return 0; |
| 1907 | } | 2020 | } |
| 1908 | 2021 | ||
| 2022 | #ifndef PERF_COUNTER_INDEX_OFFSET | ||
| 2023 | # define PERF_COUNTER_INDEX_OFFSET 0 | ||
| 2024 | #endif | ||
| 2025 | |||
| 1909 | static int perf_counter_index(struct perf_counter *counter) | 2026 | static int perf_counter_index(struct perf_counter *counter) |
| 1910 | { | 2027 | { |
| 1911 | if (counter->state != PERF_COUNTER_STATE_ACTIVE) | 2028 | if (counter->state != PERF_COUNTER_STATE_ACTIVE) |
| @@ -2245,7 +2362,7 @@ static void perf_pending_counter(struct perf_pending_entry *entry) | |||
| 2245 | 2362 | ||
| 2246 | if (counter->pending_disable) { | 2363 | if (counter->pending_disable) { |
| 2247 | counter->pending_disable = 0; | 2364 | counter->pending_disable = 0; |
| 2248 | perf_counter_disable(counter); | 2365 | __perf_counter_disable(counter); |
| 2249 | } | 2366 | } |
| 2250 | 2367 | ||
| 2251 | if (counter->pending_wakeup) { | 2368 | if (counter->pending_wakeup) { |
| @@ -2630,7 +2747,80 @@ static u32 perf_counter_tid(struct perf_counter *counter, struct task_struct *p) | |||
| 2630 | return task_pid_nr_ns(p, counter->ns); | 2747 | return task_pid_nr_ns(p, counter->ns); |
| 2631 | } | 2748 | } |
| 2632 | 2749 | ||
| 2633 | static void perf_counter_output(struct perf_counter *counter, int nmi, | 2750 | static void perf_output_read_one(struct perf_output_handle *handle, |
| 2751 | struct perf_counter *counter) | ||
| 2752 | { | ||
| 2753 | u64 read_format = counter->attr.read_format; | ||
| 2754 | u64 values[4]; | ||
| 2755 | int n = 0; | ||
| 2756 | |||
| 2757 | values[n++] = atomic64_read(&counter->count); | ||
| 2758 | if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) { | ||
| 2759 | values[n++] = counter->total_time_enabled + | ||
| 2760 | atomic64_read(&counter->child_total_time_enabled); | ||
| 2761 | } | ||
| 2762 | if (read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) { | ||
| 2763 | values[n++] = counter->total_time_running + | ||
| 2764 | atomic64_read(&counter->child_total_time_running); | ||
| 2765 | } | ||
| 2766 | if (read_format & PERF_FORMAT_ID) | ||
| 2767 | values[n++] = primary_counter_id(counter); | ||
| 2768 | |||
| 2769 | perf_output_copy(handle, values, n * sizeof(u64)); | ||
| 2770 | } | ||
| 2771 | |||
| 2772 | /* | ||
| 2773 | * XXX PERF_FORMAT_GROUP vs inherited counters seems difficult. | ||
| 2774 | */ | ||
| 2775 | static void perf_output_read_group(struct perf_output_handle *handle, | ||
| 2776 | struct perf_counter *counter) | ||
| 2777 | { | ||
| 2778 | struct perf_counter *leader = counter->group_leader, *sub; | ||
| 2779 | u64 read_format = counter->attr.read_format; | ||
| 2780 | u64 values[5]; | ||
| 2781 | int n = 0; | ||
| 2782 | |||
| 2783 | values[n++] = 1 + leader->nr_siblings; | ||
| 2784 | |||
| 2785 | if (read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) | ||
| 2786 | values[n++] = leader->total_time_enabled; | ||
| 2787 | |||
| 2788 | if (read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) | ||
| 2789 | values[n++] = leader->total_time_running; | ||
| 2790 | |||
| 2791 | if (leader != counter) | ||
| 2792 | leader->pmu->read(leader); | ||
| 2793 | |||
| 2794 | values[n++] = atomic64_read(&leader->count); | ||
| 2795 | if (read_format & PERF_FORMAT_ID) | ||
| 2796 | values[n++] = primary_counter_id(leader); | ||
| 2797 | |||
| 2798 | perf_output_copy(handle, values, n * sizeof(u64)); | ||
| 2799 | |||
| 2800 | list_for_each_entry(sub, &leader->sibling_list, list_entry) { | ||
| 2801 | n = 0; | ||
| 2802 | |||
| 2803 | if (sub != counter) | ||
| 2804 | sub->pmu->read(sub); | ||
| 2805 | |||
| 2806 | values[n++] = atomic64_read(&sub->count); | ||
| 2807 | if (read_format & PERF_FORMAT_ID) | ||
| 2808 | values[n++] = primary_counter_id(sub); | ||
| 2809 | |||
| 2810 | perf_output_copy(handle, values, n * sizeof(u64)); | ||
| 2811 | } | ||
| 2812 | } | ||
| 2813 | |||
| 2814 | static void perf_output_read(struct perf_output_handle *handle, | ||
| 2815 | struct perf_counter *counter) | ||
| 2816 | { | ||
| 2817 | if (counter->attr.read_format & PERF_FORMAT_GROUP) | ||
| 2818 | perf_output_read_group(handle, counter); | ||
| 2819 | else | ||
| 2820 | perf_output_read_one(handle, counter); | ||
| 2821 | } | ||
| 2822 | |||
| 2823 | void perf_counter_output(struct perf_counter *counter, int nmi, | ||
| 2634 | struct perf_sample_data *data) | 2824 | struct perf_sample_data *data) |
| 2635 | { | 2825 | { |
| 2636 | int ret; | 2826 | int ret; |
| @@ -2641,10 +2831,6 @@ static void perf_counter_output(struct perf_counter *counter, int nmi, | |||
| 2641 | struct { | 2831 | struct { |
| 2642 | u32 pid, tid; | 2832 | u32 pid, tid; |
| 2643 | } tid_entry; | 2833 | } tid_entry; |
| 2644 | struct { | ||
| 2645 | u64 id; | ||
| 2646 | u64 counter; | ||
| 2647 | } group_entry; | ||
| 2648 | struct perf_callchain_entry *callchain = NULL; | 2834 | struct perf_callchain_entry *callchain = NULL; |
| 2649 | int callchain_size = 0; | 2835 | int callchain_size = 0; |
| 2650 | u64 time; | 2836 | u64 time; |
| @@ -2699,10 +2885,8 @@ static void perf_counter_output(struct perf_counter *counter, int nmi, | |||
| 2699 | if (sample_type & PERF_SAMPLE_PERIOD) | 2885 | if (sample_type & PERF_SAMPLE_PERIOD) |
| 2700 | header.size += sizeof(u64); | 2886 | header.size += sizeof(u64); |
| 2701 | 2887 | ||
| 2702 | if (sample_type & PERF_SAMPLE_GROUP) { | 2888 | if (sample_type & PERF_SAMPLE_READ) |
| 2703 | header.size += sizeof(u64) + | 2889 | header.size += perf_counter_read_size(counter); |
| 2704 | counter->nr_siblings * sizeof(group_entry); | ||
| 2705 | } | ||
| 2706 | 2890 | ||
| 2707 | if (sample_type & PERF_SAMPLE_CALLCHAIN) { | 2891 | if (sample_type & PERF_SAMPLE_CALLCHAIN) { |
| 2708 | callchain = perf_callchain(data->regs); | 2892 | callchain = perf_callchain(data->regs); |
| @@ -2759,26 +2943,8 @@ static void perf_counter_output(struct perf_counter *counter, int nmi, | |||
| 2759 | if (sample_type & PERF_SAMPLE_PERIOD) | 2943 | if (sample_type & PERF_SAMPLE_PERIOD) |
| 2760 | perf_output_put(&handle, data->period); | 2944 | perf_output_put(&handle, data->period); |
| 2761 | 2945 | ||
| 2762 | /* | 2946 | if (sample_type & PERF_SAMPLE_READ) |
| 2763 | * XXX PERF_SAMPLE_GROUP vs inherited counters seems difficult. | 2947 | perf_output_read(&handle, counter); |
| 2764 | */ | ||
| 2765 | if (sample_type & PERF_SAMPLE_GROUP) { | ||
| 2766 | struct perf_counter *leader, *sub; | ||
| 2767 | u64 nr = counter->nr_siblings; | ||
| 2768 | |||
| 2769 | perf_output_put(&handle, nr); | ||
| 2770 | |||
| 2771 | leader = counter->group_leader; | ||
| 2772 | list_for_each_entry(sub, &leader->sibling_list, list_entry) { | ||
| 2773 | if (sub != counter) | ||
| 2774 | sub->pmu->read(sub); | ||
| 2775 | |||
| 2776 | group_entry.id = primary_counter_id(sub); | ||
| 2777 | group_entry.counter = atomic64_read(&sub->count); | ||
| 2778 | |||
| 2779 | perf_output_put(&handle, group_entry); | ||
| 2780 | } | ||
| 2781 | } | ||
| 2782 | 2948 | ||
| 2783 | if (sample_type & PERF_SAMPLE_CALLCHAIN) { | 2949 | if (sample_type & PERF_SAMPLE_CALLCHAIN) { |
| 2784 | if (callchain) | 2950 | if (callchain) |
| @@ -2817,8 +2983,6 @@ struct perf_read_event { | |||
| 2817 | 2983 | ||
| 2818 | u32 pid; | 2984 | u32 pid; |
| 2819 | u32 tid; | 2985 | u32 tid; |
| 2820 | u64 value; | ||
| 2821 | u64 format[3]; | ||
| 2822 | }; | 2986 | }; |
| 2823 | 2987 | ||
| 2824 | static void | 2988 | static void |
| @@ -2830,34 +2994,20 @@ perf_counter_read_event(struct perf_counter *counter, | |||
| 2830 | .header = { | 2994 | .header = { |
| 2831 | .type = PERF_EVENT_READ, | 2995 | .type = PERF_EVENT_READ, |
| 2832 | .misc = 0, | 2996 | .misc = 0, |
| 2833 | .size = sizeof(event) - sizeof(event.format), | 2997 | .size = sizeof(event) + perf_counter_read_size(counter), |
| 2834 | }, | 2998 | }, |
| 2835 | .pid = perf_counter_pid(counter, task), | 2999 | .pid = perf_counter_pid(counter, task), |
| 2836 | .tid = perf_counter_tid(counter, task), | 3000 | .tid = perf_counter_tid(counter, task), |
| 2837 | .value = atomic64_read(&counter->count), | ||
| 2838 | }; | 3001 | }; |
| 2839 | int ret, i = 0; | 3002 | int ret; |
| 2840 | |||
| 2841 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_ENABLED) { | ||
| 2842 | event.header.size += sizeof(u64); | ||
| 2843 | event.format[i++] = counter->total_time_enabled; | ||
| 2844 | } | ||
| 2845 | |||
| 2846 | if (counter->attr.read_format & PERF_FORMAT_TOTAL_TIME_RUNNING) { | ||
| 2847 | event.header.size += sizeof(u64); | ||
| 2848 | event.format[i++] = counter->total_time_running; | ||
| 2849 | } | ||
| 2850 | |||
| 2851 | if (counter->attr.read_format & PERF_FORMAT_ID) { | ||
| 2852 | event.header.size += sizeof(u64); | ||
| 2853 | event.format[i++] = primary_counter_id(counter); | ||
| 2854 | } | ||
| 2855 | 3003 | ||
| 2856 | ret = perf_output_begin(&handle, counter, event.header.size, 0, 0); | 3004 | ret = perf_output_begin(&handle, counter, event.header.size, 0, 0); |
| 2857 | if (ret) | 3005 | if (ret) |
| 2858 | return; | 3006 | return; |
| 2859 | 3007 | ||
| 2860 | perf_output_copy(&handle, &event, event.header.size); | 3008 | perf_output_put(&handle, event); |
| 3009 | perf_output_read(&handle, counter); | ||
| 3010 | |||
| 2861 | perf_output_end(&handle); | 3011 | perf_output_end(&handle); |
| 2862 | } | 3012 | } |
| 2863 | 3013 | ||
| @@ -2893,10 +3043,10 @@ static void perf_counter_task_output(struct perf_counter *counter, | |||
| 2893 | return; | 3043 | return; |
| 2894 | 3044 | ||
| 2895 | task_event->event.pid = perf_counter_pid(counter, task); | 3045 | task_event->event.pid = perf_counter_pid(counter, task); |
| 2896 | task_event->event.ppid = perf_counter_pid(counter, task->real_parent); | 3046 | task_event->event.ppid = perf_counter_pid(counter, current); |
| 2897 | 3047 | ||
| 2898 | task_event->event.tid = perf_counter_tid(counter, task); | 3048 | task_event->event.tid = perf_counter_tid(counter, task); |
| 2899 | task_event->event.ptid = perf_counter_tid(counter, task->real_parent); | 3049 | task_event->event.ptid = perf_counter_tid(counter, current); |
| 2900 | 3050 | ||
| 2901 | perf_output_put(&handle, task_event->event); | 3051 | perf_output_put(&handle, task_event->event); |
| 2902 | perf_output_end(&handle); | 3052 | perf_output_end(&handle); |
| @@ -3443,40 +3593,32 @@ static void perf_swcounter_add(struct perf_counter *counter, u64 nr, | |||
| 3443 | 3593 | ||
| 3444 | static int perf_swcounter_is_counting(struct perf_counter *counter) | 3594 | static int perf_swcounter_is_counting(struct perf_counter *counter) |
| 3445 | { | 3595 | { |
| 3446 | struct perf_counter_context *ctx; | 3596 | /* |
| 3447 | unsigned long flags; | 3597 | * The counter is active, we're good! |
| 3448 | int count; | 3598 | */ |
| 3449 | |||
| 3450 | if (counter->state == PERF_COUNTER_STATE_ACTIVE) | 3599 | if (counter->state == PERF_COUNTER_STATE_ACTIVE) |
| 3451 | return 1; | 3600 | return 1; |
| 3452 | 3601 | ||
| 3602 | /* | ||
| 3603 | * The counter is off/error, not counting. | ||
| 3604 | */ | ||
| 3453 | if (counter->state != PERF_COUNTER_STATE_INACTIVE) | 3605 | if (counter->state != PERF_COUNTER_STATE_INACTIVE) |
| 3454 | return 0; | 3606 | return 0; |
| 3455 | 3607 | ||
| 3456 | /* | 3608 | /* |
| 3457 | * If the counter is inactive, it could be just because | 3609 | * The counter is inactive, if the context is active |
| 3458 | * its task is scheduled out, or because it's in a group | 3610 | * we're part of a group that didn't make it on the 'pmu', |
| 3459 | * which could not go on the PMU. We want to count in | 3611 | * not counting. |
| 3460 | * the first case but not the second. If the context is | ||
| 3461 | * currently active then an inactive software counter must | ||
| 3462 | * be the second case. If it's not currently active then | ||
| 3463 | * we need to know whether the counter was active when the | ||
| 3464 | * context was last active, which we can determine by | ||
| 3465 | * comparing counter->tstamp_stopped with ctx->time. | ||
| 3466 | * | ||
| 3467 | * We are within an RCU read-side critical section, | ||
| 3468 | * which protects the existence of *ctx. | ||
| 3469 | */ | 3612 | */ |
| 3470 | ctx = counter->ctx; | 3613 | if (counter->ctx->is_active) |
| 3471 | spin_lock_irqsave(&ctx->lock, flags); | 3614 | return 0; |
| 3472 | count = 1; | 3615 | |
| 3473 | /* Re-check state now we have the lock */ | 3616 | /* |
| 3474 | if (counter->state < PERF_COUNTER_STATE_INACTIVE || | 3617 | * We're inactive and the context is too, this means the |
| 3475 | counter->ctx->is_active || | 3618 | * task is scheduled out, we're counting events that happen |
| 3476 | counter->tstamp_stopped < ctx->time) | 3619 | * to us, like migration events. |
| 3477 | count = 0; | 3620 | */ |
| 3478 | spin_unlock_irqrestore(&ctx->lock, flags); | 3621 | return 1; |
| 3479 | return count; | ||
| 3480 | } | 3622 | } |
| 3481 | 3623 | ||
| 3482 | static int perf_swcounter_match(struct perf_counter *counter, | 3624 | static int perf_swcounter_match(struct perf_counter *counter, |
| @@ -3924,13 +4066,14 @@ perf_counter_alloc(struct perf_counter_attr *attr, | |||
| 3924 | hwc->sample_period = attr->sample_period; | 4066 | hwc->sample_period = attr->sample_period; |
| 3925 | if (attr->freq && attr->sample_freq) | 4067 | if (attr->freq && attr->sample_freq) |
| 3926 | hwc->sample_period = 1; | 4068 | hwc->sample_period = 1; |
| 4069 | hwc->last_period = hwc->sample_period; | ||
| 3927 | 4070 | ||
| 3928 | atomic64_set(&hwc->period_left, hwc->sample_period); | 4071 | atomic64_set(&hwc->period_left, hwc->sample_period); |
| 3929 | 4072 | ||
| 3930 | /* | 4073 | /* |
| 3931 | * we currently do not support PERF_SAMPLE_GROUP on inherited counters | 4074 | * we currently do not support PERF_FORMAT_GROUP on inherited counters |
| 3932 | */ | 4075 | */ |
| 3933 | if (attr->inherit && (attr->sample_type & PERF_SAMPLE_GROUP)) | 4076 | if (attr->inherit && (attr->read_format & PERF_FORMAT_GROUP)) |
| 3934 | goto done; | 4077 | goto done; |
| 3935 | 4078 | ||
| 3936 | switch (attr->type) { | 4079 | switch (attr->type) { |
| @@ -4592,6 +4735,11 @@ perf_cpu_notify(struct notifier_block *self, unsigned long action, void *hcpu) | |||
| 4592 | perf_counter_init_cpu(cpu); | 4735 | perf_counter_init_cpu(cpu); |
| 4593 | break; | 4736 | break; |
| 4594 | 4737 | ||
| 4738 | case CPU_ONLINE: | ||
| 4739 | case CPU_ONLINE_FROZEN: | ||
| 4740 | hw_perf_counter_setup_online(cpu); | ||
| 4741 | break; | ||
| 4742 | |||
| 4595 | case CPU_DOWN_PREPARE: | 4743 | case CPU_DOWN_PREPARE: |
| 4596 | case CPU_DOWN_PREPARE_FROZEN: | 4744 | case CPU_DOWN_PREPARE_FROZEN: |
| 4597 | perf_counter_exit_cpu(cpu); | 4745 | perf_counter_exit_cpu(cpu); |
| @@ -4616,6 +4764,8 @@ void __init perf_counter_init(void) | |||
| 4616 | { | 4764 | { |
| 4617 | perf_cpu_notify(&perf_cpu_nb, (unsigned long)CPU_UP_PREPARE, | 4765 | perf_cpu_notify(&perf_cpu_nb, (unsigned long)CPU_UP_PREPARE, |
| 4618 | (void *)(long)smp_processor_id()); | 4766 | (void *)(long)smp_processor_id()); |
| 4767 | perf_cpu_notify(&perf_cpu_nb, (unsigned long)CPU_ONLINE, | ||
| 4768 | (void *)(long)smp_processor_id()); | ||
| 4619 | register_cpu_notifier(&perf_cpu_nb); | 4769 | register_cpu_notifier(&perf_cpu_nb); |
| 4620 | } | 4770 | } |
| 4621 | 4771 | ||
diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 98e02328c67d..58be76017fd0 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c | |||
| @@ -49,6 +49,7 @@ | |||
| 49 | #include <linux/acpi.h> | 49 | #include <linux/acpi.h> |
| 50 | #include <linux/reboot.h> | 50 | #include <linux/reboot.h> |
| 51 | #include <linux/ftrace.h> | 51 | #include <linux/ftrace.h> |
| 52 | #include <linux/security.h> | ||
| 52 | #include <linux/slow-work.h> | 53 | #include <linux/slow-work.h> |
| 53 | #include <linux/perf_counter.h> | 54 | #include <linux/perf_counter.h> |
| 54 | 55 | ||
| @@ -1306,10 +1307,10 @@ static struct ctl_table vm_table[] = { | |||
| 1306 | { | 1307 | { |
| 1307 | .ctl_name = CTL_UNNUMBERED, | 1308 | .ctl_name = CTL_UNNUMBERED, |
| 1308 | .procname = "mmap_min_addr", | 1309 | .procname = "mmap_min_addr", |
| 1309 | .data = &mmap_min_addr, | 1310 | .data = &dac_mmap_min_addr, |
| 1310 | .maxlen = sizeof(unsigned long), | 1311 | .maxlen = sizeof(unsigned long), |
| 1311 | .mode = 0644, | 1312 | .mode = 0644, |
| 1312 | .proc_handler = &proc_doulongvec_minmax, | 1313 | .proc_handler = &mmap_min_addr_handler, |
| 1313 | }, | 1314 | }, |
| 1314 | #ifdef CONFIG_NUMA | 1315 | #ifdef CONFIG_NUMA |
| 1315 | { | 1316 | { |
diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index a6dcd67b041d..620b58abdc32 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c | |||
| @@ -137,11 +137,12 @@ int clockevents_program_event(struct clock_event_device *dev, ktime_t expires, | |||
| 137 | */ | 137 | */ |
| 138 | int clockevents_register_notifier(struct notifier_block *nb) | 138 | int clockevents_register_notifier(struct notifier_block *nb) |
| 139 | { | 139 | { |
| 140 | unsigned long flags; | ||
| 140 | int ret; | 141 | int ret; |
| 141 | 142 | ||
| 142 | spin_lock(&clockevents_lock); | 143 | spin_lock_irqsave(&clockevents_lock, flags); |
| 143 | ret = raw_notifier_chain_register(&clockevents_chain, nb); | 144 | ret = raw_notifier_chain_register(&clockevents_chain, nb); |
| 144 | spin_unlock(&clockevents_lock); | 145 | spin_unlock_irqrestore(&clockevents_lock, flags); |
| 145 | 146 | ||
| 146 | return ret; | 147 | return ret; |
| 147 | } | 148 | } |
| @@ -178,16 +179,18 @@ static void clockevents_notify_released(void) | |||
| 178 | */ | 179 | */ |
| 179 | void clockevents_register_device(struct clock_event_device *dev) | 180 | void clockevents_register_device(struct clock_event_device *dev) |
| 180 | { | 181 | { |
| 182 | unsigned long flags; | ||
| 183 | |||
| 181 | BUG_ON(dev->mode != CLOCK_EVT_MODE_UNUSED); | 184 | BUG_ON(dev->mode != CLOCK_EVT_MODE_UNUSED); |
| 182 | BUG_ON(!dev->cpumask); | 185 | BUG_ON(!dev->cpumask); |
| 183 | 186 | ||
| 184 | spin_lock(&clockevents_lock); | 187 | spin_lock_irqsave(&clockevents_lock, flags); |
| 185 | 188 | ||
| 186 | list_add(&dev->list, &clockevent_devices); | 189 | list_add(&dev->list, &clockevent_devices); |
| 187 | clockevents_do_notify(CLOCK_EVT_NOTIFY_ADD, dev); | 190 | clockevents_do_notify(CLOCK_EVT_NOTIFY_ADD, dev); |
| 188 | clockevents_notify_released(); | 191 | clockevents_notify_released(); |
| 189 | 192 | ||
| 190 | spin_unlock(&clockevents_lock); | 193 | spin_unlock_irqrestore(&clockevents_lock, flags); |
| 191 | } | 194 | } |
| 192 | EXPORT_SYMBOL_GPL(clockevents_register_device); | 195 | EXPORT_SYMBOL_GPL(clockevents_register_device); |
| 193 | 196 | ||
| @@ -235,8 +238,9 @@ void clockevents_exchange_device(struct clock_event_device *old, | |||
| 235 | void clockevents_notify(unsigned long reason, void *arg) | 238 | void clockevents_notify(unsigned long reason, void *arg) |
| 236 | { | 239 | { |
| 237 | struct list_head *node, *tmp; | 240 | struct list_head *node, *tmp; |
| 241 | unsigned long flags; | ||
| 238 | 242 | ||
| 239 | spin_lock(&clockevents_lock); | 243 | spin_lock_irqsave(&clockevents_lock, flags); |
| 240 | clockevents_do_notify(reason, arg); | 244 | clockevents_do_notify(reason, arg); |
| 241 | 245 | ||
| 242 | switch (reason) { | 246 | switch (reason) { |
| @@ -251,7 +255,7 @@ void clockevents_notify(unsigned long reason, void *arg) | |||
| 251 | default: | 255 | default: |
| 252 | break; | 256 | break; |
| 253 | } | 257 | } |
| 254 | spin_unlock(&clockevents_lock); | 258 | spin_unlock_irqrestore(&clockevents_lock, flags); |
| 255 | } | 259 | } |
| 256 | EXPORT_SYMBOL_GPL(clockevents_notify); | 260 | EXPORT_SYMBOL_GPL(clockevents_notify); |
| 257 | #endif | 261 | #endif |
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index 877dbedc3118..c2ec25087a35 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c | |||
| @@ -205,11 +205,11 @@ static void tick_handle_periodic_broadcast(struct clock_event_device *dev) | |||
| 205 | * Powerstate information: The system enters/leaves a state, where | 205 | * Powerstate information: The system enters/leaves a state, where |
| 206 | * affected devices might stop | 206 | * affected devices might stop |
| 207 | */ | 207 | */ |
| 208 | static void tick_do_broadcast_on_off(void *why) | 208 | static void tick_do_broadcast_on_off(unsigned long *reason) |
| 209 | { | 209 | { |
| 210 | struct clock_event_device *bc, *dev; | 210 | struct clock_event_device *bc, *dev; |
| 211 | struct tick_device *td; | 211 | struct tick_device *td; |
| 212 | unsigned long flags, *reason = why; | 212 | unsigned long flags; |
| 213 | int cpu, bc_stopped; | 213 | int cpu, bc_stopped; |
| 214 | 214 | ||
| 215 | spin_lock_irqsave(&tick_broadcast_lock, flags); | 215 | spin_lock_irqsave(&tick_broadcast_lock, flags); |
| @@ -276,8 +276,7 @@ void tick_broadcast_on_off(unsigned long reason, int *oncpu) | |||
| 276 | printk(KERN_ERR "tick-broadcast: ignoring broadcast for " | 276 | printk(KERN_ERR "tick-broadcast: ignoring broadcast for " |
| 277 | "offline CPU #%d\n", *oncpu); | 277 | "offline CPU #%d\n", *oncpu); |
| 278 | else | 278 | else |
| 279 | smp_call_function_single(*oncpu, tick_do_broadcast_on_off, | 279 | tick_do_broadcast_on_off(&reason); |
| 280 | &reason, 1); | ||
| 281 | } | 280 | } |
| 282 | 281 | ||
| 283 | /* | 282 | /* |
diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c index a999b92a1277..fddd69d16e03 100644 --- a/kernel/time/timer_list.c +++ b/kernel/time/timer_list.c | |||
| @@ -286,7 +286,7 @@ static int __init init_timer_list_procfs(void) | |||
| 286 | { | 286 | { |
| 287 | struct proc_dir_entry *pe; | 287 | struct proc_dir_entry *pe; |
| 288 | 288 | ||
| 289 | pe = proc_create("timer_list", 0644, NULL, &timer_list_fops); | 289 | pe = proc_create("timer_list", 0444, NULL, &timer_list_fops); |
| 290 | if (!pe) | 290 | if (!pe) |
| 291 | return -ENOMEM; | 291 | return -ENOMEM; |
| 292 | return 0; | 292 | return 0; |
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c index 243bafc2ec90..3eb159c277c8 100644 --- a/kernel/trace/blktrace.c +++ b/kernel/trace/blktrace.c | |||
| @@ -271,8 +271,8 @@ static void blk_trace_free(struct blk_trace *bt) | |||
| 271 | { | 271 | { |
| 272 | debugfs_remove(bt->msg_file); | 272 | debugfs_remove(bt->msg_file); |
| 273 | debugfs_remove(bt->dropped_file); | 273 | debugfs_remove(bt->dropped_file); |
| 274 | debugfs_remove(bt->dir); | ||
| 275 | relay_close(bt->rchan); | 274 | relay_close(bt->rchan); |
| 275 | debugfs_remove(bt->dir); | ||
| 276 | free_percpu(bt->sequence); | 276 | free_percpu(bt->sequence); |
| 277 | free_percpu(bt->msg_data); | 277 | free_percpu(bt->msg_data); |
| 278 | kfree(bt); | 278 | kfree(bt); |
| @@ -382,18 +382,8 @@ static int blk_subbuf_start_callback(struct rchan_buf *buf, void *subbuf, | |||
| 382 | 382 | ||
| 383 | static int blk_remove_buf_file_callback(struct dentry *dentry) | 383 | static int blk_remove_buf_file_callback(struct dentry *dentry) |
| 384 | { | 384 | { |
| 385 | struct dentry *parent = dentry->d_parent; | ||
| 386 | debugfs_remove(dentry); | 385 | debugfs_remove(dentry); |
| 387 | 386 | ||
| 388 | /* | ||
| 389 | * this will fail for all but the last file, but that is ok. what we | ||
| 390 | * care about is the top level buts->name directory going away, when | ||
| 391 | * the last trace file is gone. Then we don't have to rmdir() that | ||
| 392 | * manually on trace stop, so it nicely solves the issue with | ||
| 393 | * force killing of running traces. | ||
| 394 | */ | ||
| 395 | |||
| 396 | debugfs_remove(parent); | ||
| 397 | return 0; | 387 | return 0; |
| 398 | } | 388 | } |
| 399 | 389 | ||
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c index 1993b7186cdb..8c804e24f96f 100644 --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c | |||
| @@ -2222,7 +2222,11 @@ ftrace_regex_write(struct file *file, const char __user *ubuf, | |||
| 2222 | read++; | 2222 | read++; |
| 2223 | cnt--; | 2223 | cnt--; |
| 2224 | 2224 | ||
| 2225 | if (!(iter->flags & ~FTRACE_ITER_CONT)) { | 2225 | /* |
| 2226 | * If the parser haven't finished with the last write, | ||
| 2227 | * continue reading the user input without skipping spaces. | ||
| 2228 | */ | ||
| 2229 | if (!(iter->flags & FTRACE_ITER_CONT)) { | ||
| 2226 | /* skip white space */ | 2230 | /* skip white space */ |
| 2227 | while (cnt && isspace(ch)) { | 2231 | while (cnt && isspace(ch)) { |
| 2228 | ret = get_user(ch, ubuf++); | 2232 | ret = get_user(ch, ubuf++); |
| @@ -2232,8 +2236,9 @@ ftrace_regex_write(struct file *file, const char __user *ubuf, | |||
| 2232 | cnt--; | 2236 | cnt--; |
| 2233 | } | 2237 | } |
| 2234 | 2238 | ||
| 2239 | /* only spaces were written */ | ||
| 2235 | if (isspace(ch)) { | 2240 | if (isspace(ch)) { |
| 2236 | file->f_pos += read; | 2241 | *ppos += read; |
| 2237 | ret = read; | 2242 | ret = read; |
| 2238 | goto out; | 2243 | goto out; |
| 2239 | } | 2244 | } |
| @@ -2262,12 +2267,12 @@ ftrace_regex_write(struct file *file, const char __user *ubuf, | |||
| 2262 | if (ret) | 2267 | if (ret) |
| 2263 | goto out; | 2268 | goto out; |
| 2264 | iter->buffer_idx = 0; | 2269 | iter->buffer_idx = 0; |
| 2265 | } else | 2270 | } else { |
| 2266 | iter->flags |= FTRACE_ITER_CONT; | 2271 | iter->flags |= FTRACE_ITER_CONT; |
| 2272 | iter->buffer[iter->buffer_idx++] = ch; | ||
| 2273 | } | ||
| 2267 | 2274 | ||
| 2268 | 2275 | *ppos += read; | |
| 2269 | file->f_pos += read; | ||
| 2270 | |||
| 2271 | ret = read; | 2276 | ret = read; |
| 2272 | out: | 2277 | out: |
| 2273 | mutex_unlock(&ftrace_regex_lock); | 2278 | mutex_unlock(&ftrace_regex_lock); |
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 6df9861fde6b..5c75deeefe30 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
| @@ -3901,17 +3901,9 @@ trace_options_core_write(struct file *filp, const char __user *ubuf, size_t cnt, | |||
| 3901 | if (ret < 0) | 3901 | if (ret < 0) |
| 3902 | return ret; | 3902 | return ret; |
| 3903 | 3903 | ||
| 3904 | switch (val) { | 3904 | if (val != 0 && val != 1) |
| 3905 | case 0: | ||
| 3906 | trace_flags &= ~(1 << index); | ||
| 3907 | break; | ||
| 3908 | case 1: | ||
| 3909 | trace_flags |= 1 << index; | ||
| 3910 | break; | ||
| 3911 | |||
| 3912 | default: | ||
| 3913 | return -EINVAL; | 3905 | return -EINVAL; |
| 3914 | } | 3906 | set_tracer_flags(1 << index, val); |
| 3915 | 3907 | ||
| 3916 | *ppos += cnt; | 3908 | *ppos += cnt; |
| 3917 | 3909 | ||
diff --git a/kernel/wait.c b/kernel/wait.c index ea7c3b4275cf..c4bd3d825f35 100644 --- a/kernel/wait.c +++ b/kernel/wait.c | |||
| @@ -10,13 +10,14 @@ | |||
| 10 | #include <linux/wait.h> | 10 | #include <linux/wait.h> |
| 11 | #include <linux/hash.h> | 11 | #include <linux/hash.h> |
| 12 | 12 | ||
| 13 | void init_waitqueue_head(wait_queue_head_t *q) | 13 | void __init_waitqueue_head(wait_queue_head_t *q, struct lock_class_key *key) |
| 14 | { | 14 | { |
| 15 | spin_lock_init(&q->lock); | 15 | spin_lock_init(&q->lock); |
| 16 | lockdep_set_class(&q->lock, key); | ||
| 16 | INIT_LIST_HEAD(&q->task_list); | 17 | INIT_LIST_HEAD(&q->task_list); |
| 17 | } | 18 | } |
| 18 | 19 | ||
| 19 | EXPORT_SYMBOL(init_waitqueue_head); | 20 | EXPORT_SYMBOL(__init_waitqueue_head); |
| 20 | 21 | ||
| 21 | void add_wait_queue(wait_queue_head_t *q, wait_queue_t *wait) | 22 | void add_wait_queue(wait_queue_head_t *q, wait_queue_t *wait) |
| 22 | { | 23 | { |
