diff options
author | Peter Zijlstra <peterz@infradead.org> | 2014-05-09 04:49:03 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-05-22 04:21:26 -0400 |
commit | dbdb22754fde671dc93d2fae06f8be113d47f2fb (patch) | |
tree | 150c824b8fb435ca64f034c740804e7a7da2297b /kernel | |
parent | 143cf23df25b7082cd706c3c53188e741e7881c3 (diff) |
sched: Disallow sched_attr::sched_policy < 0
The scheduler uses policy=-1 to preserve the current policy state to
implement sys_sched_setparam(), this got exposed to userspace by
accident through sys_sched_setattr(), cure this.
Reported-by: Michael Kerrisk <mtk.manpages@gmail.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
Cc: <stable@vger.kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140509085311.GJ30445@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sched/core.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index f2205f02eb70..cdefcf7c5925 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c | |||
@@ -3662,6 +3662,9 @@ SYSCALL_DEFINE3(sched_setattr, pid_t, pid, struct sched_attr __user *, uattr, | |||
3662 | if (retval) | 3662 | if (retval) |
3663 | return retval; | 3663 | return retval; |
3664 | 3664 | ||
3665 | if (attr.sched_policy < 0) | ||
3666 | return -EINVAL; | ||
3667 | |||
3665 | rcu_read_lock(); | 3668 | rcu_read_lock(); |
3666 | retval = -ESRCH; | 3669 | retval = -ESRCH; |
3667 | p = find_process_by_pid(pid); | 3670 | p = find_process_by_pid(pid); |