diff options
author | Lai Jiangshan <laijs@cn.fujitsu.com> | 2009-03-25 04:58:39 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2009-03-25 13:32:34 -0400 |
commit | 220ba351dfa57eca4bec5ce0098a276446a47958 (patch) | |
tree | e0990d566ef8c19a291ad871caaf94fdd3d57008 /kernel | |
parent | e6f489013b985b58d096a3091ece0ed579367232 (diff) |
trace_stat: keep original order
Impact: make trace_stat files show items with the original order
trace_stat tracer reverse the items, it makes the output
looks a little ugly.
Example, when we read trace_stat/workqueues, we get cpu#7's stat.
at first, and then cpu#6... cpu#0.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Steven Rostedt <srostedt@redhat.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <49C9F23F.5040307@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/trace/trace_stat.c | 18 |
1 files changed, 8 insertions, 10 deletions
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index 8c129dd480ad..acdebd771a93 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c | |||
@@ -125,23 +125,21 @@ static int stat_seq_init(struct tracer_stat_session *session) | |||
125 | INIT_LIST_HEAD(&new_entry->list); | 125 | INIT_LIST_HEAD(&new_entry->list); |
126 | new_entry->stat = stat; | 126 | new_entry->stat = stat; |
127 | 127 | ||
128 | list_for_each_entry(iter_entry, &session->stat_list, list) { | 128 | list_for_each_entry_reverse(iter_entry, &session->stat_list, |
129 | list) { | ||
129 | 130 | ||
130 | /* Insertion with a descendent sorting */ | 131 | /* Insertion with a descendent sorting */ |
131 | if (ts->stat_cmp(new_entry->stat, | 132 | if (ts->stat_cmp(iter_entry->stat, |
132 | iter_entry->stat) > 0) { | 133 | new_entry->stat) >= 0) { |
133 | 134 | ||
134 | list_add_tail(&new_entry->list, | ||
135 | &iter_entry->list); | ||
136 | break; | ||
137 | |||
138 | /* The current smaller value */ | ||
139 | } else if (list_is_last(&iter_entry->list, | ||
140 | &session->stat_list)) { | ||
141 | list_add(&new_entry->list, &iter_entry->list); | 135 | list_add(&new_entry->list, &iter_entry->list); |
142 | break; | 136 | break; |
143 | } | 137 | } |
144 | } | 138 | } |
139 | |||
140 | /* The current larger value */ | ||
141 | if (list_empty(&new_entry->list)) | ||
142 | list_add(&new_entry->list, &session->stat_list); | ||
145 | } | 143 | } |
146 | exit: | 144 | exit: |
147 | mutex_unlock(&session->stat_mutex); | 145 | mutex_unlock(&session->stat_mutex); |