diff options
author | Ingo Molnar <mingo@elte.hu> | 2008-07-15 15:55:59 -0400 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-07-15 15:55:59 -0400 |
commit | 1a781a777b2f6ac46523fe92396215762ced624d (patch) | |
tree | 4f34bb4aade85c0eb364b53d664ec7f6ab959006 /kernel | |
parent | b9d2252c1e44fa83a4e65fdc9eb93db6297c55af (diff) | |
parent | 42a2f217a5e324ed5f2373ab1b7a0a15187c4d6c (diff) |
Merge branch 'generic-ipi' into generic-ipi-for-linus
Conflicts:
arch/powerpc/Kconfig
arch/s390/kernel/time.c
arch/x86/kernel/apic_32.c
arch/x86/kernel/cpu/perfctr-watchdog.c
arch/x86/kernel/i8259_64.c
arch/x86/kernel/ldt.c
arch/x86/kernel/nmi_64.c
arch/x86/kernel/smpboot.c
arch/x86/xen/smp.c
include/asm-x86/hw_irq_32.h
include/asm-x86/hw_irq_64.h
include/asm-x86/mach-default/irq_vectors.h
include/asm-x86/mach-voyager/irq_vectors.h
include/asm-x86/smp.h
kernel/Makefile
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/Makefile | 1 | ||||
-rw-r--r-- | kernel/hrtimer.c | 2 | ||||
-rw-r--r-- | kernel/profile.c | 6 | ||||
-rw-r--r-- | kernel/rcupdate.c | 2 | ||||
-rw-r--r-- | kernel/smp.c | 381 | ||||
-rw-r--r-- | kernel/softirq.c | 4 | ||||
-rw-r--r-- | kernel/time/tick-broadcast.c | 2 |
7 files changed, 390 insertions, 8 deletions
diff --git a/kernel/Makefile b/kernel/Makefile index f6328e16dfdd..0a7ed838984b 100644 --- a/kernel/Makefile +++ b/kernel/Makefile | |||
@@ -39,6 +39,7 @@ obj-$(CONFIG_RT_MUTEXES) += rtmutex.o | |||
39 | obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o | 39 | obj-$(CONFIG_DEBUG_RT_MUTEXES) += rtmutex-debug.o |
40 | obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o | 40 | obj-$(CONFIG_RT_MUTEX_TESTER) += rtmutex-tester.o |
41 | obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o | 41 | obj-$(CONFIG_GENERIC_ISA_DMA) += dma.o |
42 | obj-$(CONFIG_USE_GENERIC_SMP_HELPERS) += smp.o | ||
42 | obj-$(CONFIG_SMP) += spinlock.o | 43 | obj-$(CONFIG_SMP) += spinlock.o |
43 | obj-$(CONFIG_DEBUG_SPINLOCK) += spinlock.o | 44 | obj-$(CONFIG_DEBUG_SPINLOCK) += spinlock.o |
44 | obj-$(CONFIG_PROVE_LOCKING) += spinlock.o | 45 | obj-$(CONFIG_PROVE_LOCKING) += spinlock.o |
diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c index 2913a8bff612..b8e4dce80a74 100644 --- a/kernel/hrtimer.c +++ b/kernel/hrtimer.c | |||
@@ -622,7 +622,7 @@ static void retrigger_next_event(void *arg) | |||
622 | void clock_was_set(void) | 622 | void clock_was_set(void) |
623 | { | 623 | { |
624 | /* Retrigger the CPU local events everywhere */ | 624 | /* Retrigger the CPU local events everywhere */ |
625 | on_each_cpu(retrigger_next_event, NULL, 0, 1); | 625 | on_each_cpu(retrigger_next_event, NULL, 1); |
626 | } | 626 | } |
627 | 627 | ||
628 | /* | 628 | /* |
diff --git a/kernel/profile.c b/kernel/profile.c index ae7ead82cbc9..58926411eb2a 100644 --- a/kernel/profile.c +++ b/kernel/profile.c | |||
@@ -252,7 +252,7 @@ static void profile_flip_buffers(void) | |||
252 | mutex_lock(&profile_flip_mutex); | 252 | mutex_lock(&profile_flip_mutex); |
253 | j = per_cpu(cpu_profile_flip, get_cpu()); | 253 | j = per_cpu(cpu_profile_flip, get_cpu()); |
254 | put_cpu(); | 254 | put_cpu(); |
255 | on_each_cpu(__profile_flip_buffers, NULL, 0, 1); | 255 | on_each_cpu(__profile_flip_buffers, NULL, 1); |
256 | for_each_online_cpu(cpu) { | 256 | for_each_online_cpu(cpu) { |
257 | struct profile_hit *hits = per_cpu(cpu_profile_hits, cpu)[j]; | 257 | struct profile_hit *hits = per_cpu(cpu_profile_hits, cpu)[j]; |
258 | for (i = 0; i < NR_PROFILE_HIT; ++i) { | 258 | for (i = 0; i < NR_PROFILE_HIT; ++i) { |
@@ -275,7 +275,7 @@ static void profile_discard_flip_buffers(void) | |||
275 | mutex_lock(&profile_flip_mutex); | 275 | mutex_lock(&profile_flip_mutex); |
276 | i = per_cpu(cpu_profile_flip, get_cpu()); | 276 | i = per_cpu(cpu_profile_flip, get_cpu()); |
277 | put_cpu(); | 277 | put_cpu(); |
278 | on_each_cpu(__profile_flip_buffers, NULL, 0, 1); | 278 | on_each_cpu(__profile_flip_buffers, NULL, 1); |
279 | for_each_online_cpu(cpu) { | 279 | for_each_online_cpu(cpu) { |
280 | struct profile_hit *hits = per_cpu(cpu_profile_hits, cpu)[i]; | 280 | struct profile_hit *hits = per_cpu(cpu_profile_hits, cpu)[i]; |
281 | memset(hits, 0, NR_PROFILE_HIT*sizeof(struct profile_hit)); | 281 | memset(hits, 0, NR_PROFILE_HIT*sizeof(struct profile_hit)); |
@@ -558,7 +558,7 @@ static int __init create_hash_tables(void) | |||
558 | out_cleanup: | 558 | out_cleanup: |
559 | prof_on = 0; | 559 | prof_on = 0; |
560 | smp_mb(); | 560 | smp_mb(); |
561 | on_each_cpu(profile_nop, NULL, 0, 1); | 561 | on_each_cpu(profile_nop, NULL, 1); |
562 | for_each_online_cpu(cpu) { | 562 | for_each_online_cpu(cpu) { |
563 | struct page *page; | 563 | struct page *page; |
564 | 564 | ||
diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c index c09605f8d16c..6addab5e6d88 100644 --- a/kernel/rcupdate.c +++ b/kernel/rcupdate.c | |||
@@ -127,7 +127,7 @@ void rcu_barrier(void) | |||
127 | * until all the callbacks are queued. | 127 | * until all the callbacks are queued. |
128 | */ | 128 | */ |
129 | rcu_read_lock(); | 129 | rcu_read_lock(); |
130 | on_each_cpu(rcu_barrier_func, NULL, 0, 1); | 130 | on_each_cpu(rcu_barrier_func, NULL, 1); |
131 | rcu_read_unlock(); | 131 | rcu_read_unlock(); |
132 | wait_for_completion(&rcu_barrier_completion); | 132 | wait_for_completion(&rcu_barrier_completion); |
133 | mutex_unlock(&rcu_barrier_mutex); | 133 | mutex_unlock(&rcu_barrier_mutex); |
diff --git a/kernel/smp.c b/kernel/smp.c new file mode 100644 index 000000000000..4f582b257eba --- /dev/null +++ b/kernel/smp.c | |||
@@ -0,0 +1,381 @@ | |||
1 | /* | ||
2 | * Generic helpers for smp ipi calls | ||
3 | * | ||
4 | * (C) Jens Axboe <jens.axboe@oracle.com> 2008 | ||
5 | * | ||
6 | */ | ||
7 | #include <linux/init.h> | ||
8 | #include <linux/module.h> | ||
9 | #include <linux/percpu.h> | ||
10 | #include <linux/rcupdate.h> | ||
11 | #include <linux/smp.h> | ||
12 | |||
13 | static DEFINE_PER_CPU(struct call_single_queue, call_single_queue); | ||
14 | static LIST_HEAD(call_function_queue); | ||
15 | __cacheline_aligned_in_smp DEFINE_SPINLOCK(call_function_lock); | ||
16 | |||
17 | enum { | ||
18 | CSD_FLAG_WAIT = 0x01, | ||
19 | CSD_FLAG_ALLOC = 0x02, | ||
20 | }; | ||
21 | |||
22 | struct call_function_data { | ||
23 | struct call_single_data csd; | ||
24 | spinlock_t lock; | ||
25 | unsigned int refs; | ||
26 | cpumask_t cpumask; | ||
27 | struct rcu_head rcu_head; | ||
28 | }; | ||
29 | |||
30 | struct call_single_queue { | ||
31 | struct list_head list; | ||
32 | spinlock_t lock; | ||
33 | }; | ||
34 | |||
35 | void __cpuinit init_call_single_data(void) | ||
36 | { | ||
37 | int i; | ||
38 | |||
39 | for_each_possible_cpu(i) { | ||
40 | struct call_single_queue *q = &per_cpu(call_single_queue, i); | ||
41 | |||
42 | spin_lock_init(&q->lock); | ||
43 | INIT_LIST_HEAD(&q->list); | ||
44 | } | ||
45 | } | ||
46 | |||
47 | static void csd_flag_wait(struct call_single_data *data) | ||
48 | { | ||
49 | /* Wait for response */ | ||
50 | do { | ||
51 | /* | ||
52 | * We need to see the flags store in the IPI handler | ||
53 | */ | ||
54 | smp_mb(); | ||
55 | if (!(data->flags & CSD_FLAG_WAIT)) | ||
56 | break; | ||
57 | cpu_relax(); | ||
58 | } while (1); | ||
59 | } | ||
60 | |||
61 | /* | ||
62 | * Insert a previously allocated call_single_data element for execution | ||
63 | * on the given CPU. data must already have ->func, ->info, and ->flags set. | ||
64 | */ | ||
65 | static void generic_exec_single(int cpu, struct call_single_data *data) | ||
66 | { | ||
67 | struct call_single_queue *dst = &per_cpu(call_single_queue, cpu); | ||
68 | int wait = data->flags & CSD_FLAG_WAIT, ipi; | ||
69 | unsigned long flags; | ||
70 | |||
71 | spin_lock_irqsave(&dst->lock, flags); | ||
72 | ipi = list_empty(&dst->list); | ||
73 | list_add_tail(&data->list, &dst->list); | ||
74 | spin_unlock_irqrestore(&dst->lock, flags); | ||
75 | |||
76 | if (ipi) | ||
77 | arch_send_call_function_single_ipi(cpu); | ||
78 | |||
79 | if (wait) | ||
80 | csd_flag_wait(data); | ||
81 | } | ||
82 | |||
83 | static void rcu_free_call_data(struct rcu_head *head) | ||
84 | { | ||
85 | struct call_function_data *data; | ||
86 | |||
87 | data = container_of(head, struct call_function_data, rcu_head); | ||
88 | |||
89 | kfree(data); | ||
90 | } | ||
91 | |||
92 | /* | ||
93 | * Invoked by arch to handle an IPI for call function. Must be called with | ||
94 | * interrupts disabled. | ||
95 | */ | ||
96 | void generic_smp_call_function_interrupt(void) | ||
97 | { | ||
98 | struct call_function_data *data; | ||
99 | int cpu = get_cpu(); | ||
100 | |||
101 | /* | ||
102 | * It's ok to use list_for_each_rcu() here even though we may delete | ||
103 | * 'pos', since list_del_rcu() doesn't clear ->next | ||
104 | */ | ||
105 | rcu_read_lock(); | ||
106 | list_for_each_entry_rcu(data, &call_function_queue, csd.list) { | ||
107 | int refs; | ||
108 | |||
109 | if (!cpu_isset(cpu, data->cpumask)) | ||
110 | continue; | ||
111 | |||
112 | data->csd.func(data->csd.info); | ||
113 | |||
114 | spin_lock(&data->lock); | ||
115 | cpu_clear(cpu, data->cpumask); | ||
116 | WARN_ON(data->refs == 0); | ||
117 | data->refs--; | ||
118 | refs = data->refs; | ||
119 | spin_unlock(&data->lock); | ||
120 | |||
121 | if (refs) | ||
122 | continue; | ||
123 | |||
124 | spin_lock(&call_function_lock); | ||
125 | list_del_rcu(&data->csd.list); | ||
126 | spin_unlock(&call_function_lock); | ||
127 | |||
128 | if (data->csd.flags & CSD_FLAG_WAIT) { | ||
129 | /* | ||
130 | * serialize stores to data with the flag clear | ||
131 | * and wakeup | ||
132 | */ | ||
133 | smp_wmb(); | ||
134 | data->csd.flags &= ~CSD_FLAG_WAIT; | ||
135 | } else | ||
136 | call_rcu(&data->rcu_head, rcu_free_call_data); | ||
137 | } | ||
138 | rcu_read_unlock(); | ||
139 | |||
140 | put_cpu(); | ||
141 | } | ||
142 | |||
143 | /* | ||
144 | * Invoked by arch to handle an IPI for call function single. Must be called | ||
145 | * from the arch with interrupts disabled. | ||
146 | */ | ||
147 | void generic_smp_call_function_single_interrupt(void) | ||
148 | { | ||
149 | struct call_single_queue *q = &__get_cpu_var(call_single_queue); | ||
150 | LIST_HEAD(list); | ||
151 | |||
152 | /* | ||
153 | * Need to see other stores to list head for checking whether | ||
154 | * list is empty without holding q->lock | ||
155 | */ | ||
156 | smp_mb(); | ||
157 | while (!list_empty(&q->list)) { | ||
158 | unsigned int data_flags; | ||
159 | |||
160 | spin_lock(&q->lock); | ||
161 | list_replace_init(&q->list, &list); | ||
162 | spin_unlock(&q->lock); | ||
163 | |||
164 | while (!list_empty(&list)) { | ||
165 | struct call_single_data *data; | ||
166 | |||
167 | data = list_entry(list.next, struct call_single_data, | ||
168 | list); | ||
169 | list_del(&data->list); | ||
170 | |||
171 | /* | ||
172 | * 'data' can be invalid after this call if | ||
173 | * flags == 0 (when called through | ||
174 | * generic_exec_single(), so save them away before | ||
175 | * making the call. | ||
176 | */ | ||
177 | data_flags = data->flags; | ||
178 | |||
179 | data->func(data->info); | ||
180 | |||
181 | if (data_flags & CSD_FLAG_WAIT) { | ||
182 | smp_wmb(); | ||
183 | data->flags &= ~CSD_FLAG_WAIT; | ||
184 | } else if (data_flags & CSD_FLAG_ALLOC) | ||
185 | kfree(data); | ||
186 | } | ||
187 | /* | ||
188 | * See comment on outer loop | ||
189 | */ | ||
190 | smp_mb(); | ||
191 | } | ||
192 | } | ||
193 | |||
194 | /* | ||
195 | * smp_call_function_single - Run a function on a specific CPU | ||
196 | * @func: The function to run. This must be fast and non-blocking. | ||
197 | * @info: An arbitrary pointer to pass to the function. | ||
198 | * @wait: If true, wait until function has completed on other CPUs. | ||
199 | * | ||
200 | * Returns 0 on success, else a negative status code. Note that @wait | ||
201 | * will be implicitly turned on in case of allocation failures, since | ||
202 | * we fall back to on-stack allocation. | ||
203 | */ | ||
204 | int smp_call_function_single(int cpu, void (*func) (void *info), void *info, | ||
205 | int wait) | ||
206 | { | ||
207 | struct call_single_data d; | ||
208 | unsigned long flags; | ||
209 | /* prevent preemption and reschedule on another processor */ | ||
210 | int me = get_cpu(); | ||
211 | |||
212 | /* Can deadlock when called with interrupts disabled */ | ||
213 | WARN_ON(irqs_disabled()); | ||
214 | |||
215 | if (cpu == me) { | ||
216 | local_irq_save(flags); | ||
217 | func(info); | ||
218 | local_irq_restore(flags); | ||
219 | } else { | ||
220 | struct call_single_data *data = NULL; | ||
221 | |||
222 | if (!wait) { | ||
223 | data = kmalloc(sizeof(*data), GFP_ATOMIC); | ||
224 | if (data) | ||
225 | data->flags = CSD_FLAG_ALLOC; | ||
226 | } | ||
227 | if (!data) { | ||
228 | data = &d; | ||
229 | data->flags = CSD_FLAG_WAIT; | ||
230 | } | ||
231 | |||
232 | data->func = func; | ||
233 | data->info = info; | ||
234 | generic_exec_single(cpu, data); | ||
235 | } | ||
236 | |||
237 | put_cpu(); | ||
238 | return 0; | ||
239 | } | ||
240 | EXPORT_SYMBOL(smp_call_function_single); | ||
241 | |||
242 | /** | ||
243 | * __smp_call_function_single(): Run a function on another CPU | ||
244 | * @cpu: The CPU to run on. | ||
245 | * @data: Pre-allocated and setup data structure | ||
246 | * | ||
247 | * Like smp_call_function_single(), but allow caller to pass in a pre-allocated | ||
248 | * data structure. Useful for embedding @data inside other structures, for | ||
249 | * instance. | ||
250 | * | ||
251 | */ | ||
252 | void __smp_call_function_single(int cpu, struct call_single_data *data) | ||
253 | { | ||
254 | /* Can deadlock when called with interrupts disabled */ | ||
255 | WARN_ON((data->flags & CSD_FLAG_WAIT) && irqs_disabled()); | ||
256 | |||
257 | generic_exec_single(cpu, data); | ||
258 | } | ||
259 | |||
260 | /** | ||
261 | * smp_call_function_mask(): Run a function on a set of other CPUs. | ||
262 | * @mask: The set of cpus to run on. | ||
263 | * @func: The function to run. This must be fast and non-blocking. | ||
264 | * @info: An arbitrary pointer to pass to the function. | ||
265 | * @wait: If true, wait (atomically) until function has completed on other CPUs. | ||
266 | * | ||
267 | * Returns 0 on success, else a negative status code. | ||
268 | * | ||
269 | * If @wait is true, then returns once @func has returned. Note that @wait | ||
270 | * will be implicitly turned on in case of allocation failures, since | ||
271 | * we fall back to on-stack allocation. | ||
272 | * | ||
273 | * You must not call this function with disabled interrupts or from a | ||
274 | * hardware interrupt handler or from a bottom half handler. Preemption | ||
275 | * must be disabled when calling this function. | ||
276 | */ | ||
277 | int smp_call_function_mask(cpumask_t mask, void (*func)(void *), void *info, | ||
278 | int wait) | ||
279 | { | ||
280 | struct call_function_data d; | ||
281 | struct call_function_data *data = NULL; | ||
282 | cpumask_t allbutself; | ||
283 | unsigned long flags; | ||
284 | int cpu, num_cpus; | ||
285 | |||
286 | /* Can deadlock when called with interrupts disabled */ | ||
287 | WARN_ON(irqs_disabled()); | ||
288 | |||
289 | cpu = smp_processor_id(); | ||
290 | allbutself = cpu_online_map; | ||
291 | cpu_clear(cpu, allbutself); | ||
292 | cpus_and(mask, mask, allbutself); | ||
293 | num_cpus = cpus_weight(mask); | ||
294 | |||
295 | /* | ||
296 | * If zero CPUs, return. If just a single CPU, turn this request | ||
297 | * into a targetted single call instead since it's faster. | ||
298 | */ | ||
299 | if (!num_cpus) | ||
300 | return 0; | ||
301 | else if (num_cpus == 1) { | ||
302 | cpu = first_cpu(mask); | ||
303 | return smp_call_function_single(cpu, func, info, wait); | ||
304 | } | ||
305 | |||
306 | if (!wait) { | ||
307 | data = kmalloc(sizeof(*data), GFP_ATOMIC); | ||
308 | if (data) | ||
309 | data->csd.flags = CSD_FLAG_ALLOC; | ||
310 | } | ||
311 | if (!data) { | ||
312 | data = &d; | ||
313 | data->csd.flags = CSD_FLAG_WAIT; | ||
314 | } | ||
315 | |||
316 | spin_lock_init(&data->lock); | ||
317 | data->csd.func = func; | ||
318 | data->csd.info = info; | ||
319 | data->refs = num_cpus; | ||
320 | data->cpumask = mask; | ||
321 | |||
322 | spin_lock_irqsave(&call_function_lock, flags); | ||
323 | list_add_tail_rcu(&data->csd.list, &call_function_queue); | ||
324 | spin_unlock_irqrestore(&call_function_lock, flags); | ||
325 | |||
326 | /* Send a message to all CPUs in the map */ | ||
327 | arch_send_call_function_ipi(mask); | ||
328 | |||
329 | /* optionally wait for the CPUs to complete */ | ||
330 | if (wait) | ||
331 | csd_flag_wait(&data->csd); | ||
332 | |||
333 | return 0; | ||
334 | } | ||
335 | EXPORT_SYMBOL(smp_call_function_mask); | ||
336 | |||
337 | /** | ||
338 | * smp_call_function(): Run a function on all other CPUs. | ||
339 | * @func: The function to run. This must be fast and non-blocking. | ||
340 | * @info: An arbitrary pointer to pass to the function. | ||
341 | * @wait: If true, wait (atomically) until function has completed on other CPUs. | ||
342 | * | ||
343 | * Returns 0 on success, else a negative status code. | ||
344 | * | ||
345 | * If @wait is true, then returns once @func has returned; otherwise | ||
346 | * it returns just before the target cpu calls @func. In case of allocation | ||
347 | * failure, @wait will be implicitly turned on. | ||
348 | * | ||
349 | * You must not call this function with disabled interrupts or from a | ||
350 | * hardware interrupt handler or from a bottom half handler. | ||
351 | */ | ||
352 | int smp_call_function(void (*func)(void *), void *info, int wait) | ||
353 | { | ||
354 | int ret; | ||
355 | |||
356 | preempt_disable(); | ||
357 | ret = smp_call_function_mask(cpu_online_map, func, info, wait); | ||
358 | preempt_enable(); | ||
359 | return ret; | ||
360 | } | ||
361 | EXPORT_SYMBOL(smp_call_function); | ||
362 | |||
363 | void ipi_call_lock(void) | ||
364 | { | ||
365 | spin_lock(&call_function_lock); | ||
366 | } | ||
367 | |||
368 | void ipi_call_unlock(void) | ||
369 | { | ||
370 | spin_unlock(&call_function_lock); | ||
371 | } | ||
372 | |||
373 | void ipi_call_lock_irq(void) | ||
374 | { | ||
375 | spin_lock_irq(&call_function_lock); | ||
376 | } | ||
377 | |||
378 | void ipi_call_unlock_irq(void) | ||
379 | { | ||
380 | spin_unlock_irq(&call_function_lock); | ||
381 | } | ||
diff --git a/kernel/softirq.c b/kernel/softirq.c index 3e9e896fdc5b..81e2fe0f983a 100644 --- a/kernel/softirq.c +++ b/kernel/softirq.c | |||
@@ -645,12 +645,12 @@ __init int spawn_ksoftirqd(void) | |||
645 | /* | 645 | /* |
646 | * Call a function on all processors | 646 | * Call a function on all processors |
647 | */ | 647 | */ |
648 | int on_each_cpu(void (*func) (void *info), void *info, int retry, int wait) | 648 | int on_each_cpu(void (*func) (void *info), void *info, int wait) |
649 | { | 649 | { |
650 | int ret = 0; | 650 | int ret = 0; |
651 | 651 | ||
652 | preempt_disable(); | 652 | preempt_disable(); |
653 | ret = smp_call_function(func, info, retry, wait); | 653 | ret = smp_call_function(func, info, wait); |
654 | local_irq_disable(); | 654 | local_irq_disable(); |
655 | func(info); | 655 | func(info); |
656 | local_irq_enable(); | 656 | local_irq_enable(); |
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index 67f80c261709..f48d0f09d32f 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c | |||
@@ -268,7 +268,7 @@ void tick_broadcast_on_off(unsigned long reason, int *oncpu) | |||
268 | "offline CPU #%d\n", *oncpu); | 268 | "offline CPU #%d\n", *oncpu); |
269 | else | 269 | else |
270 | smp_call_function_single(*oncpu, tick_do_broadcast_on_off, | 270 | smp_call_function_single(*oncpu, tick_do_broadcast_on_off, |
271 | &reason, 1, 1); | 271 | &reason, 1); |
272 | } | 272 | } |
273 | 273 | ||
274 | /* | 274 | /* |