diff options
author | Oleg Nesterov <oleg@tv-sign.ru> | 2008-04-30 03:52:58 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-30 11:29:36 -0400 |
commit | 2dce81bff28dceb2153c901883a56f278d91db65 (patch) | |
tree | 831da312ea00c5c505d376098b5b1a90fe33fed7 /kernel | |
parent | 34c8f07b9ac499a807918eda377193a55f64f8df (diff) |
signals: cleanup the usage of print_fatal_signal()
Move the callsite of print_fatal_signal() down, under "if
(sig_kernel_coredump(signr))", so we don't need to check signr != SIGKILL.
We are only interested in the sig_kernel_coredump() signals anyway, and due to
the previous changes we almost never can see other fatal signals here except
SIGKILL.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/signal.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/kernel/signal.c b/kernel/signal.c index 0a873279393c..0db1d93c4d68 100644 --- a/kernel/signal.c +++ b/kernel/signal.c | |||
@@ -1787,9 +1787,10 @@ relock: | |||
1787 | * Anything else is fatal, maybe with a core dump. | 1787 | * Anything else is fatal, maybe with a core dump. |
1788 | */ | 1788 | */ |
1789 | current->flags |= PF_SIGNALED; | 1789 | current->flags |= PF_SIGNALED; |
1790 | if ((signr != SIGKILL) && print_fatal_signals) | 1790 | |
1791 | print_fatal_signal(regs, signr); | ||
1792 | if (sig_kernel_coredump(signr)) { | 1791 | if (sig_kernel_coredump(signr)) { |
1792 | if (print_fatal_signals) | ||
1793 | print_fatal_signal(regs, signr); | ||
1793 | /* | 1794 | /* |
1794 | * If it was able to dump core, this kills all | 1795 | * If it was able to dump core, this kills all |
1795 | * other threads in the group and synchronizes with | 1796 | * other threads in the group and synchronizes with |