aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>2008-02-02 15:10:35 -0500
committerSam Ravnborg <sam@ravnborg.org>2008-02-03 02:58:07 -0500
commit3f550096dede4430f83b16457da83bf429155ac2 (patch)
tree1e352deedbcf23cf97a4ca5a2db7f26dd26a4640 /kernel
parent42d4b839c82fd7dd8e412145eb6d9752468478e2 (diff)
Add HAVE_KPROBES
Linus: On the per-architecture side, I do think it would be better to *not* have internal architecture knowledge in a generic file, and as such a line like depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32 really shouldn't exist in a file like kernel/Kconfig.instrumentation. It would be much better to do depends on ARCH_SUPPORTS_KPROBES in that generic file, and then architectures that do support it would just have a bool ARCH_SUPPORTS_KPROBES default y in *their* architecture files. That would seem to be much more logical, and is readable both for arch maintainers *and* for people who have no clue - and don't care - about which architecture is supposed to support which interface... Changelog: Actually, I know I gave this as the magic incantation, but now that I see it, I realize that I should have told you to just use config KPROBES_SUPPORT def_bool y instead, which is a bit denser. We seem to use both kinds of syntax for these things, but this is really what "def_bool" is there for... - Use HAVE_KPROBES - Use a select - Yet another update : Moving to HAVE_* now. - Update ARM for kprobes support. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Cc: Jeff Dike <jdike@addtoit.com> Cc: David Howells <dhowells@redhat.com> Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/Kconfig.instrumentation5
1 files changed, 4 insertions, 1 deletions
diff --git a/kernel/Kconfig.instrumentation b/kernel/Kconfig.instrumentation
index d9d010a271db..2195b6544575 100644
--- a/kernel/Kconfig.instrumentation
+++ b/kernel/Kconfig.instrumentation
@@ -35,7 +35,7 @@ config HAVE_OPROFILE
35config KPROBES 35config KPROBES
36 bool "Kprobes" 36 bool "Kprobes"
37 depends on KALLSYMS && MODULES && !UML 37 depends on KALLSYMS && MODULES && !UML
38 depends on X86_32 || IA64 || PPC || S390 || SPARC64 || X86_64 || AVR32 || (ARM && !XIP_KERNEL) 38 depends on HAVE_KPROBES
39 help 39 help
40 Kprobes allows you to trap at almost any kernel address and 40 Kprobes allows you to trap at almost any kernel address and
41 execute a callback function. register_kprobe() establishes 41 execute a callback function. register_kprobe() establishes
@@ -43,6 +43,9 @@ config KPROBES
43 for kernel debugging, non-intrusive instrumentation and testing. 43 for kernel debugging, non-intrusive instrumentation and testing.
44 If in doubt, say "N". 44 If in doubt, say "N".
45 45
46config HAVE_KPROBES
47 def_bool n
48
46config MARKERS 49config MARKERS
47 bool "Activate markers" 50 bool "Activate markers"
48 help 51 help