lockdep: make cli/sti annotation warnings clearer

make cli/sti annotation warnings easier to interpret.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

1 files changed, 9 insertions, 4 deletions

diff --git a/kernel/lockdep.c b/kernel/lockdep.c
index 0f389621bb6b..723bd9f92556 100644
--- a/kernel/lockdep.c
+++ b/kernel/lockdep.c
@@ -2654,10 +2654,15 @@ static void check_flags(unsigned long flags)
         if (!debug_locks)
                 return;
 
-        if (irqs_disabled_flags(flags))
-                DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled);
-        else
-                DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled);
+        if (irqs_disabled_flags(flags)) {
+                if (DEBUG_LOCKS_WARN_ON(current->hardirqs_enabled)) {
+                        printk("possible reason: unannotated irqs-off.\n");
+                }
+        } else {
+                if (DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled)) {
+                        printk("possible reason: unannotated irqs-on.\n");
+                }
+        }
 
         /*
          * We dont accurately track softirq state in e.g.