diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2008-11-23 12:43:39 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-11-23 16:34:02 -0500 |
commit | 65afa5e603d507014580ead016ec887b49e1afa6 (patch) | |
tree | 0ee309e4193e90587b2febda09143891e0591cdc /kernel | |
parent | eae849ca034c7f1015f0a6f17421ebc737f0a069 (diff) |
tracing/function-return-tracer: free the return stack on free_task()
Impact: avoid losing some traces when a task is freed
do_exit() is not the last function called when a task finishes.
There are still some functions which are to be called such as
ree_task(). So we delay the freeing of the return stack to the
last moment.
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/exit.c | 2 | ||||
-rw-r--r-- | kernel/fork.c | 1 |
2 files changed, 1 insertions, 2 deletions
diff --git a/kernel/exit.c b/kernel/exit.c index ef04d03b3286..e5ae36ebe8af 100644 --- a/kernel/exit.c +++ b/kernel/exit.c | |||
@@ -47,7 +47,6 @@ | |||
47 | #include <linux/task_io_accounting_ops.h> | 47 | #include <linux/task_io_accounting_ops.h> |
48 | #include <linux/tracehook.h> | 48 | #include <linux/tracehook.h> |
49 | #include <trace/sched.h> | 49 | #include <trace/sched.h> |
50 | #include <linux/ftrace.h> | ||
51 | 50 | ||
52 | #include <asm/uaccess.h> | 51 | #include <asm/uaccess.h> |
53 | #include <asm/unistd.h> | 52 | #include <asm/unistd.h> |
@@ -1128,7 +1127,6 @@ NORET_TYPE void do_exit(long code) | |||
1128 | preempt_disable(); | 1127 | preempt_disable(); |
1129 | /* causes final put_task_struct in finish_task_switch(). */ | 1128 | /* causes final put_task_struct in finish_task_switch(). */ |
1130 | tsk->state = TASK_DEAD; | 1129 | tsk->state = TASK_DEAD; |
1131 | ftrace_retfunc_exit_task(tsk); | ||
1132 | schedule(); | 1130 | schedule(); |
1133 | BUG(); | 1131 | BUG(); |
1134 | /* Avoid "noreturn function does return". */ | 1132 | /* Avoid "noreturn function does return". */ |
diff --git a/kernel/fork.c b/kernel/fork.c index fbf4a4c0a628..d6e1a3205f62 100644 --- a/kernel/fork.c +++ b/kernel/fork.c | |||
@@ -140,6 +140,7 @@ void free_task(struct task_struct *tsk) | |||
140 | prop_local_destroy_single(&tsk->dirties); | 140 | prop_local_destroy_single(&tsk->dirties); |
141 | free_thread_info(tsk->stack); | 141 | free_thread_info(tsk->stack); |
142 | rt_mutex_debug_task_free(tsk); | 142 | rt_mutex_debug_task_free(tsk); |
143 | ftrace_retfunc_exit_task(tsk); | ||
143 | free_task_struct(tsk); | 144 | free_task_struct(tsk); |
144 | } | 145 | } |
145 | EXPORT_SYMBOL(free_task); | 146 | EXPORT_SYMBOL(free_task); |