diff options
author | Andi Kleen <ak@suse.de> | 2006-07-10 07:44:01 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2006-07-10 16:24:14 -0400 |
commit | f9829cceb686f3719215fe43c8593e5f3efe1710 (patch) | |
tree | eb6f721915c879646f81e423b6606d6b4376bed9 /kernel | |
parent | 8f72e4028a1ff968000cec4a034f45619fbd7ec4 (diff) |
[PATCH] Minor cleanup to lockdep.c
- Use printk formatting for indentation
- Don't leave NTFS in the default event filter
Signed-off-by: Andi Kleen <ak@suse.de>
Acked-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/lockdep.c | 44 |
1 files changed, 12 insertions, 32 deletions
diff --git a/kernel/lockdep.c b/kernel/lockdep.c index f32ca78c198d..42af5cc31a49 100644 --- a/kernel/lockdep.c +++ b/kernel/lockdep.c | |||
@@ -169,22 +169,17 @@ EXPORT_SYMBOL(lockdep_internal); | |||
169 | */ | 169 | */ |
170 | static int class_filter(struct lock_class *class) | 170 | static int class_filter(struct lock_class *class) |
171 | { | 171 | { |
172 | #if 0 | ||
173 | /* Example */ | ||
172 | if (class->name_version == 1 && | 174 | if (class->name_version == 1 && |
173 | !strcmp(class->name, "&rl->lock")) | 175 | !strcmp(class->name, "lockname")) |
174 | return 1; | 176 | return 1; |
175 | if (class->name_version == 1 && | 177 | if (class->name_version == 1 && |
176 | !strcmp(class->name, "&ni->mrec_lock")) | 178 | !strcmp(class->name, "&struct->lockfield")) |
177 | return 1; | 179 | return 1; |
178 | if (class->name_version == 1 && | 180 | #endif |
179 | !strcmp(class->name, "mft_ni_runlist_lock")) | 181 | /* Allow everything else. 0 would be filter everything else */ |
180 | return 1; | 182 | return 1; |
181 | if (class->name_version == 1 && | ||
182 | !strcmp(class->name, "mft_ni_mrec_lock")) | ||
183 | return 1; | ||
184 | if (class->name_version == 1 && | ||
185 | !strcmp(class->name, "&vol->lcnbmp_lock")) | ||
186 | return 1; | ||
187 | return 0; | ||
188 | } | 183 | } |
189 | #endif | 184 | #endif |
190 | 185 | ||
@@ -408,23 +403,12 @@ static void lockdep_print_held_locks(struct task_struct *curr) | |||
408 | print_lock(curr->held_locks + i); | 403 | print_lock(curr->held_locks + i); |
409 | } | 404 | } |
410 | } | 405 | } |
411 | /* | ||
412 | * Helper to print a nice hierarchy of lock dependencies: | ||
413 | */ | ||
414 | static void print_spaces(int nr) | ||
415 | { | ||
416 | int i; | ||
417 | |||
418 | for (i = 0; i < nr; i++) | ||
419 | printk(" "); | ||
420 | } | ||
421 | 406 | ||
422 | static void print_lock_class_header(struct lock_class *class, int depth) | 407 | static void print_lock_class_header(struct lock_class *class, int depth) |
423 | { | 408 | { |
424 | int bit; | 409 | int bit; |
425 | 410 | ||
426 | print_spaces(depth); | 411 | printk("%*s->", depth, ""); |
427 | printk("->"); | ||
428 | print_lock_name(class); | 412 | print_lock_name(class); |
429 | printk(" ops: %lu", class->ops); | 413 | printk(" ops: %lu", class->ops); |
430 | printk(" {\n"); | 414 | printk(" {\n"); |
@@ -433,17 +417,14 @@ static void print_lock_class_header(struct lock_class *class, int depth) | |||
433 | if (class->usage_mask & (1 << bit)) { | 417 | if (class->usage_mask & (1 << bit)) { |
434 | int len = depth; | 418 | int len = depth; |
435 | 419 | ||
436 | print_spaces(depth); | 420 | len += printk("%*s %s", depth, "", usage_str[bit]); |
437 | len += printk(" %s", usage_str[bit]); | ||
438 | len += printk(" at:\n"); | 421 | len += printk(" at:\n"); |
439 | print_stack_trace(class->usage_traces + bit, len); | 422 | print_stack_trace(class->usage_traces + bit, len); |
440 | } | 423 | } |
441 | } | 424 | } |
442 | print_spaces(depth); | 425 | printk("%*s }\n", depth, ""); |
443 | printk(" }\n"); | ||
444 | 426 | ||
445 | print_spaces(depth); | 427 | printk("%*s ... key at: ",depth,""); |
446 | printk(" ... key at: "); | ||
447 | print_ip_sym((unsigned long)class->key); | 428 | print_ip_sym((unsigned long)class->key); |
448 | } | 429 | } |
449 | 430 | ||
@@ -463,8 +444,7 @@ static void print_lock_dependencies(struct lock_class *class, int depth) | |||
463 | DEBUG_LOCKS_WARN_ON(!entry->class); | 444 | DEBUG_LOCKS_WARN_ON(!entry->class); |
464 | print_lock_dependencies(entry->class, depth + 1); | 445 | print_lock_dependencies(entry->class, depth + 1); |
465 | 446 | ||
466 | print_spaces(depth); | 447 | printk("%*s ... acquired at:\n",depth,""); |
467 | printk(" ... acquired at:\n"); | ||
468 | print_stack_trace(&entry->trace, 2); | 448 | print_stack_trace(&entry->trace, 2); |
469 | printk("\n"); | 449 | printk("\n"); |
470 | } | 450 | } |