diff options
author | Gleb Natapov <gleb@redhat.com> | 2011-11-22 09:08:21 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2011-12-07 10:31:22 -0500 |
commit | 86b47c25494b824da655b95f6fdb4fdb3f17aa77 (patch) | |
tree | 45ed2f1c82a258bcbbe0550aa728b11187512322 /kernel | |
parent | a33caeb118198286309859f014c0662f3ed54ed4 (diff) |
perf: Do no try to schedule task events if there are none
perf_event_sched_in() shouldn't try to schedule task events if there
are none otherwise task's ctx->is_active will be set and will not be
cleared during sched_out. This will prevent newly added events from
being scheduled into the task context.
Fixes a boo-boo in commit 1d5f003f5a9 ("perf: Do not set task_ctx
pointer in cpuctx if there are no events in the context").
Signed-off-by: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20111122140821.GF2557@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/events/core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c index 600c1629b64d..d3b9df5962c2 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c | |||
@@ -2174,11 +2174,11 @@ static void perf_event_context_sched_in(struct perf_event_context *ctx, | |||
2174 | */ | 2174 | */ |
2175 | cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); | 2175 | cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE); |
2176 | 2176 | ||
2177 | perf_event_sched_in(cpuctx, ctx, task); | ||
2178 | |||
2179 | if (ctx->nr_events) | 2177 | if (ctx->nr_events) |
2180 | cpuctx->task_ctx = ctx; | 2178 | cpuctx->task_ctx = ctx; |
2181 | 2179 | ||
2180 | perf_event_sched_in(cpuctx, cpuctx->task_ctx, task); | ||
2181 | |||
2182 | perf_pmu_enable(ctx->pmu); | 2182 | perf_pmu_enable(ctx->pmu); |
2183 | perf_ctx_unlock(cpuctx, ctx); | 2183 | perf_ctx_unlock(cpuctx, ctx); |
2184 | 2184 | ||