diff options
author | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:18 -0500 |
---|---|---|
committer | Rusty Russell <rusty@rustcorp.com.au> | 2012-01-12 18:02:18 -0500 |
commit | 2329abfa344a9a824bc4c71f2415528777265510 (patch) | |
tree | 7779fadc6ceba76071e3f5db0ec6a1dee41a0dfd /kernel | |
parent | 6d6a55ec0877393f467067d44b9a2a8c2e4a82d2 (diff) |
module_param: make bool parameters really bool (core code)
module_param(bool) used to counter-intuitively take an int. In
fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
trick.
It's time to remove the int/unsigned int option. For this version
it'll simply give a warning, but it'll break next kernel version.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/irq/internals.h | 2 | ||||
-rw-r--r-- | kernel/irq/spurious.c | 2 | ||||
-rw-r--r-- | kernel/printk.c | 8 |
3 files changed, 6 insertions, 6 deletions
diff --git a/kernel/irq/internals.h b/kernel/irq/internals.h index a73dd6c7372d..b7952316016a 100644 --- a/kernel/irq/internals.h +++ b/kernel/irq/internals.h | |||
@@ -15,7 +15,7 @@ | |||
15 | 15 | ||
16 | #define istate core_internal_state__do_not_mess_with_it | 16 | #define istate core_internal_state__do_not_mess_with_it |
17 | 17 | ||
18 | extern int noirqdebug; | 18 | extern bool noirqdebug; |
19 | 19 | ||
20 | /* | 20 | /* |
21 | * Bits used by threaded handlers: | 21 | * Bits used by threaded handlers: |
diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c index dc813a948be2..611cd6003c45 100644 --- a/kernel/irq/spurious.c +++ b/kernel/irq/spurious.c | |||
@@ -325,7 +325,7 @@ void note_interrupt(unsigned int irq, struct irq_desc *desc, | |||
325 | desc->irqs_unhandled = 0; | 325 | desc->irqs_unhandled = 0; |
326 | } | 326 | } |
327 | 327 | ||
328 | int noirqdebug __read_mostly; | 328 | bool noirqdebug __read_mostly; |
329 | 329 | ||
330 | int noirqdebug_setup(char *str) | 330 | int noirqdebug_setup(char *str) |
331 | { | 331 | { |
diff --git a/kernel/printk.c b/kernel/printk.c index 63b3bc31fe32..13c0a1143f49 100644 --- a/kernel/printk.c +++ b/kernel/printk.c | |||
@@ -521,7 +521,7 @@ static void __call_console_drivers(unsigned start, unsigned end) | |||
521 | } | 521 | } |
522 | } | 522 | } |
523 | 523 | ||
524 | static int __read_mostly ignore_loglevel; | 524 | static bool __read_mostly ignore_loglevel; |
525 | 525 | ||
526 | static int __init ignore_loglevel_setup(char *str) | 526 | static int __init ignore_loglevel_setup(char *str) |
527 | { | 527 | { |
@@ -696,9 +696,9 @@ static void zap_locks(void) | |||
696 | } | 696 | } |
697 | 697 | ||
698 | #if defined(CONFIG_PRINTK_TIME) | 698 | #if defined(CONFIG_PRINTK_TIME) |
699 | static int printk_time = 1; | 699 | static bool printk_time = 1; |
700 | #else | 700 | #else |
701 | static int printk_time = 0; | 701 | static bool printk_time = 0; |
702 | #endif | 702 | #endif |
703 | module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); | 703 | module_param_named(time, printk_time, bool, S_IRUGO | S_IWUSR); |
704 | 704 | ||
@@ -1098,7 +1098,7 @@ int update_console_cmdline(char *name, int idx, char *name_new, int idx_new, cha | |||
1098 | return -1; | 1098 | return -1; |
1099 | } | 1099 | } |
1100 | 1100 | ||
1101 | int console_suspend_enabled = 1; | 1101 | bool console_suspend_enabled = 1; |
1102 | EXPORT_SYMBOL(console_suspend_enabled); | 1102 | EXPORT_SYMBOL(console_suspend_enabled); |
1103 | 1103 | ||
1104 | static int __init console_suspend_disable(char *str) | 1104 | static int __init console_suspend_disable(char *str) |