aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorFrederic Weisbecker <fweisbec@gmail.com>2010-12-10 16:11:10 -0500
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2010-12-17 15:34:18 -0500
commit20377f32dcb77941d450728da18cce5b1a7faec5 (patch)
treeef92da7c1fabcc68685021655842b3b18a6ee773 /kernel
parente27fc9641e8ddc8146f8e01f06e5eba2469698de (diff)
rcu: Stop chasing QS if another CPU did it for us
When a CPU is idle and others CPUs handled its extended quiescent state to complete grace periods on its behalf, it will catch up with completed grace periods numbers when it wakes up. But at this point there might be no more grace period to complete, but still the woken CPU always keeps its stale qs_pending value and will then continue to chase quiescent states even if its not needed anymore. This results in clusters of spurious softirqs until a new real grace period is started. Because if we continue to chase quiescent states but we have completed every grace periods, rcu_report_qs_rdp() is puzzled and makes that state run into infinite loops. As suggested by Lai Jiangshan, just reset qs_pending if someone completed every grace periods on our behalf. Suggested-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/rcutree.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 120820ffc657..916f42b39f1e 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -678,6 +678,14 @@ __rcu_process_gp_end(struct rcu_state *rsp, struct rcu_node *rnp, struct rcu_dat
678 678
679 /* Remember that we saw this grace-period completion. */ 679 /* Remember that we saw this grace-period completion. */
680 rdp->completed = rnp->completed; 680 rdp->completed = rnp->completed;
681
682 /*
683 * If another CPU handled our extended quiescent states and
684 * we have no more grace period to complete yet, then stop
685 * chasing quiescent states.
686 */
687 if (rdp->completed == rnp->gpnum)
688 rdp->qs_pending = 0;
681 } 689 }
682} 690}
683 691