aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorSteven Rostedt <srostedt@redhat.com>2011-01-06 15:08:29 -0500
committerIngo Molnar <mingo@elte.hu>2011-01-11 09:17:24 -0500
commitf123c98e7f168e949b283690693695f988332c3d (patch)
tree18e3421ae3e23625686564af36ca844805cf812d /kernel
parentcb600d2f83c854ec3d6660063e4466431999489b (diff)
rtmutex: Fix comment about why new_owner can be NULL in wake_futex_pi()
The comment about why rt_mutex_next_owner() can return NULL in wake_futex_pi() is not the normal case. Tracing the cause of why this occurs is more likely that waiter simply timedout. But because it originally caused contention with the futex, the owner will go into the kernel when it unlocks the lock. Then it will hit this code path and rt_mutex_next_owner() will return NULL. Cc: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/futex.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/kernel/futex.c b/kernel/futex.c
index 3019b92e6917..5696d38cc71d 100644
--- a/kernel/futex.c
+++ b/kernel/futex.c
@@ -791,10 +791,9 @@ static int wake_futex_pi(u32 __user *uaddr, u32 uval, struct futex_q *this)
791 new_owner = rt_mutex_next_owner(&pi_state->pi_mutex); 791 new_owner = rt_mutex_next_owner(&pi_state->pi_mutex);
792 792
793 /* 793 /*
794 * This happens when we have stolen the lock and the original 794 * It is possible that the next waiter (the one that brought
795 * pending owner did not enqueue itself back on the rt_mutex. 795 * this owner to the kernel) timed out and is no longer
796 * Thats not a tragedy. We know that way, that a lock waiter 796 * waiting on the lock.
797 * is on the fly. We make the futex_q waiter the pending owner.
798 */ 797 */
799 if (!new_owner) 798 if (!new_owner)
800 new_owner = this->task; 799 new_owner = this->task;