diff options
author | Valentin Ilie <valentin.ilie@gmail.com> | 2012-08-18 17:52:42 -0400 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2012-08-20 16:37:07 -0400 |
commit | 044c782ce3a901fbd17cbe701c592f582381174d (patch) | |
tree | d876983bb2930219181f09b900ce42c61782e4e5 /kernel/workqueue.c | |
parent | 7635d2fd7f0fa63b6ec03050614c314d7139f14a (diff) |
workqueue: fix checkpatch issues
Fixed some checkpatch warnings.
tj: adapted to wq/for-3.7 and massaged pr_xxx() format strings a bit.
Signed-off-by: Valentin Ilie <valentin.ilie@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
LKML-Reference: <1345326762-21747-1-git-send-email-valentin.ilie@gmail.com>
Diffstat (limited to 'kernel/workqueue.c')
-rw-r--r-- | kernel/workqueue.c | 29 |
1 files changed, 13 insertions, 16 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 7da24711038f..de429ba000ee 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c | |||
@@ -269,18 +269,18 @@ struct workqueue_struct { | |||
269 | }; | 269 | }; |
270 | 270 | ||
271 | struct workqueue_struct *system_wq __read_mostly; | 271 | struct workqueue_struct *system_wq __read_mostly; |
272 | struct workqueue_struct *system_highpri_wq __read_mostly; | ||
273 | struct workqueue_struct *system_long_wq __read_mostly; | ||
274 | struct workqueue_struct *system_nrt_wq __read_mostly; | ||
275 | struct workqueue_struct *system_unbound_wq __read_mostly; | ||
276 | struct workqueue_struct *system_freezable_wq __read_mostly; | ||
277 | struct workqueue_struct *system_nrt_freezable_wq __read_mostly; | ||
278 | EXPORT_SYMBOL_GPL(system_wq); | 272 | EXPORT_SYMBOL_GPL(system_wq); |
273 | struct workqueue_struct *system_highpri_wq __read_mostly; | ||
279 | EXPORT_SYMBOL_GPL(system_highpri_wq); | 274 | EXPORT_SYMBOL_GPL(system_highpri_wq); |
275 | struct workqueue_struct *system_long_wq __read_mostly; | ||
280 | EXPORT_SYMBOL_GPL(system_long_wq); | 276 | EXPORT_SYMBOL_GPL(system_long_wq); |
277 | struct workqueue_struct *system_nrt_wq __read_mostly; | ||
281 | EXPORT_SYMBOL_GPL(system_nrt_wq); | 278 | EXPORT_SYMBOL_GPL(system_nrt_wq); |
279 | struct workqueue_struct *system_unbound_wq __read_mostly; | ||
282 | EXPORT_SYMBOL_GPL(system_unbound_wq); | 280 | EXPORT_SYMBOL_GPL(system_unbound_wq); |
281 | struct workqueue_struct *system_freezable_wq __read_mostly; | ||
283 | EXPORT_SYMBOL_GPL(system_freezable_wq); | 282 | EXPORT_SYMBOL_GPL(system_freezable_wq); |
283 | struct workqueue_struct *system_nrt_freezable_wq __read_mostly; | ||
284 | EXPORT_SYMBOL_GPL(system_nrt_freezable_wq); | 284 | EXPORT_SYMBOL_GPL(system_nrt_freezable_wq); |
285 | 285 | ||
286 | #define CREATE_TRACE_POINTS | 286 | #define CREATE_TRACE_POINTS |
@@ -2232,11 +2232,9 @@ __acquires(&gcwq->lock) | |||
2232 | lock_map_release(&cwq->wq->lockdep_map); | 2232 | lock_map_release(&cwq->wq->lockdep_map); |
2233 | 2233 | ||
2234 | if (unlikely(in_atomic() || lockdep_depth(current) > 0)) { | 2234 | if (unlikely(in_atomic() || lockdep_depth(current) > 0)) { |
2235 | printk(KERN_ERR "BUG: workqueue leaked lock or atomic: " | 2235 | pr_err("BUG: workqueue leaked lock or atomic: %s/0x%08x/%d\n" |
2236 | "%s/0x%08x/%d\n", | 2236 | " last function: %pf\n", |
2237 | current->comm, preempt_count(), task_pid_nr(current)); | 2237 | current->comm, preempt_count(), task_pid_nr(current), f); |
2238 | printk(KERN_ERR " last function: "); | ||
2239 | print_symbol("%s\n", (unsigned long)f); | ||
2240 | debug_show_held_locks(current); | 2238 | debug_show_held_locks(current); |
2241 | dump_stack(); | 2239 | dump_stack(); |
2242 | } | 2240 | } |
@@ -2790,8 +2788,8 @@ reflush: | |||
2790 | 2788 | ||
2791 | if (++flush_cnt == 10 || | 2789 | if (++flush_cnt == 10 || |
2792 | (flush_cnt % 100 == 0 && flush_cnt <= 1000)) | 2790 | (flush_cnt % 100 == 0 && flush_cnt <= 1000)) |
2793 | pr_warning("workqueue %s: flush on destruction isn't complete after %u tries\n", | 2791 | pr_warn("workqueue %s: flush on destruction isn't complete after %u tries\n", |
2794 | wq->name, flush_cnt); | 2792 | wq->name, flush_cnt); |
2795 | goto reflush; | 2793 | goto reflush; |
2796 | } | 2794 | } |
2797 | 2795 | ||
@@ -3275,9 +3273,8 @@ static int wq_clamp_max_active(int max_active, unsigned int flags, | |||
3275 | int lim = flags & WQ_UNBOUND ? WQ_UNBOUND_MAX_ACTIVE : WQ_MAX_ACTIVE; | 3273 | int lim = flags & WQ_UNBOUND ? WQ_UNBOUND_MAX_ACTIVE : WQ_MAX_ACTIVE; |
3276 | 3274 | ||
3277 | if (max_active < 1 || max_active > lim) | 3275 | if (max_active < 1 || max_active > lim) |
3278 | printk(KERN_WARNING "workqueue: max_active %d requested for %s " | 3276 | pr_warn("workqueue: max_active %d requested for %s is out of range, clamping between %d and %d\n", |
3279 | "is out of range, clamping between %d and %d\n", | 3277 | max_active, name, 1, lim); |
3280 | max_active, name, 1, lim); | ||
3281 | 3278 | ||
3282 | return clamp_val(max_active, 1, lim); | 3279 | return clamp_val(max_active, 1, lim); |
3283 | } | 3280 | } |