aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/workqueue.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2013-01-24 14:01:33 -0500
committerTejun Heo <tj@kernel.org>2013-01-24 14:01:33 -0500
commit715b06b864c99a18cb8368dfb187da4f569788cd (patch)
tree599ab1152a1c93b83d1be05aaeb370cac2e7e3eb /kernel/workqueue.c
parent35b6bb63b8a288f90e07948867941a553b3d97bc (diff)
workqueue: introduce WORK_OFFQ_CPU_NONE
Currently, when a work item is off queue, high bits of its data encodes the last CPU it was on. This is scheduled to be changed to pool ID, which will make it impossible to use WORK_CPU_NONE to indicate no association. This patch limits the number of bits which are used for off-queue cpu number to 31 (so that the max fits in an int) and uses the highest possible value - WORK_OFFQ_CPU_NONE - to indicate no association. Signed-off-by: Tejun Heo <tj@kernel.org> Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Diffstat (limited to 'kernel/workqueue.c')
-rw-r--r--kernel/workqueue.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 1a686e481132..405282d30046 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -573,7 +573,7 @@ static struct global_cwq *get_work_gcwq(struct work_struct *work)
573 (data & WORK_STRUCT_WQ_DATA_MASK))->pool->gcwq; 573 (data & WORK_STRUCT_WQ_DATA_MASK))->pool->gcwq;
574 574
575 cpu = data >> WORK_OFFQ_CPU_SHIFT; 575 cpu = data >> WORK_OFFQ_CPU_SHIFT;
576 if (cpu == WORK_CPU_NONE) 576 if (cpu == WORK_OFFQ_CPU_NONE)
577 return NULL; 577 return NULL;
578 578
579 BUG_ON(cpu >= nr_cpu_ids && cpu != WORK_CPU_UNBOUND); 579 BUG_ON(cpu >= nr_cpu_ids && cpu != WORK_CPU_UNBOUND);
@@ -583,7 +583,7 @@ static struct global_cwq *get_work_gcwq(struct work_struct *work)
583static void mark_work_canceling(struct work_struct *work) 583static void mark_work_canceling(struct work_struct *work)
584{ 584{
585 struct global_cwq *gcwq = get_work_gcwq(work); 585 struct global_cwq *gcwq = get_work_gcwq(work);
586 unsigned long cpu = gcwq ? gcwq->cpu : WORK_CPU_NONE; 586 unsigned long cpu = gcwq ? gcwq->cpu : WORK_OFFQ_CPU_NONE;
587 587
588 set_work_data(work, (cpu << WORK_OFFQ_CPU_SHIFT) | WORK_OFFQ_CANCELING, 588 set_work_data(work, (cpu << WORK_OFFQ_CPU_SHIFT) | WORK_OFFQ_CANCELING,
589 WORK_STRUCT_PENDING); 589 WORK_STRUCT_PENDING);