diff options
author | Frederic Weisbecker <fweisbec@gmail.com> | 2010-05-19 15:35:17 -0400 |
---|---|---|
committer | Frederic Weisbecker <fweisbec@gmail.com> | 2010-06-08 17:29:52 -0400 |
commit | c9cf4dbb4d9ca715d8fedf13301a53296429abc6 (patch) | |
tree | 66f0bb55d89a41bbe8ac76f8dee418e84e255d2d /kernel/trace | |
parent | 9dda696f0de87a2e5cfabb147e28c76b7d3c6846 (diff) |
x86: Unify dumpstack.h and stacktrace.h
arch/x86/include/asm/stacktrace.h and arch/x86/kernel/dumpstack.h
declare headers of objects that deal with the same topic.
Actually most of the files that include stacktrace.h also include
dumpstack.h
Although dumpstack.h seems more reserved for internals of stack
traces, those are quite often needed to define specialized stack
trace operations. And perf event arch headers are going to need
access to such low level operations anyway. So don't continue to
bother with dumpstack.h as it's not anymore about isolated deep
internals.
v2: fix struct stack_frame definition conflict in sysprof
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Soeren Sandmann <sandmann@daimi.au.dk>
Diffstat (limited to 'kernel/trace')
-rw-r--r-- | kernel/trace/trace_sysprof.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/kernel/trace/trace_sysprof.c b/kernel/trace/trace_sysprof.c index a7974a552ca9..c080956f4d8e 100644 --- a/kernel/trace/trace_sysprof.c +++ b/kernel/trace/trace_sysprof.c | |||
@@ -33,12 +33,13 @@ static DEFINE_MUTEX(sample_timer_lock); | |||
33 | */ | 33 | */ |
34 | static DEFINE_PER_CPU(struct hrtimer, stack_trace_hrtimer); | 34 | static DEFINE_PER_CPU(struct hrtimer, stack_trace_hrtimer); |
35 | 35 | ||
36 | struct stack_frame { | 36 | struct stack_frame_user { |
37 | const void __user *next_fp; | 37 | const void __user *next_fp; |
38 | unsigned long return_address; | 38 | unsigned long return_address; |
39 | }; | 39 | }; |
40 | 40 | ||
41 | static int copy_stack_frame(const void __user *fp, struct stack_frame *frame) | 41 | static int |
42 | copy_stack_frame(const void __user *fp, struct stack_frame_user *frame) | ||
42 | { | 43 | { |
43 | int ret; | 44 | int ret; |
44 | 45 | ||
@@ -125,7 +126,7 @@ trace_kernel(struct pt_regs *regs, struct trace_array *tr, | |||
125 | static void timer_notify(struct pt_regs *regs, int cpu) | 126 | static void timer_notify(struct pt_regs *regs, int cpu) |
126 | { | 127 | { |
127 | struct trace_array_cpu *data; | 128 | struct trace_array_cpu *data; |
128 | struct stack_frame frame; | 129 | struct stack_frame_user frame; |
129 | struct trace_array *tr; | 130 | struct trace_array *tr; |
130 | const void __user *fp; | 131 | const void __user *fp; |
131 | int is_user; | 132 | int is_user; |