aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/trace
diff options
context:
space:
mode:
authorZhaolei <zhaolei@cn.fujitsu.com>2009-04-20 03:02:17 -0400
committerFrederic Weisbecker <fweisbec@gmail.com>2009-06-01 19:14:26 -0400
commitf3c4ae26e93d354152196b62797ba86ad86dd0cc (patch)
tree62a6ea34e64bffaaa192d05c42409f4ef1d361d5 /kernel/trace
parentb8867164f05791a6b5363bd51c1274e03600886e (diff)
trace_workqueue: remove blank line between each cpu
The blankline between each cpu's workqueue stat is not necessary, because the cpu number is enough to part them by eye. Old style also caused a blankline below headline, and made code complex by using lock, disableirq and get cpu var. Old style: # CPU INSERTED EXECUTED NAME # | | | | 0 8644 8644 events/0 0 0 0 cpuset ... 0 1 1 kdmflush 1 35365 35365 events/1 ... New style: # CPU INSERTED EXECUTED NAME # | | | | 0 8644 8644 events/0 0 0 0 cpuset ... 0 1 1 kdmflush 1 35365 35365 events/1 ... [ Impact: provide more readable code ] Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Tom Zanussi <tzanussi@gmail.com> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'kernel/trace')
-rw-r--r--kernel/trace/trace_workqueue.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/kernel/trace/trace_workqueue.c b/kernel/trace/trace_workqueue.c
index 890974aed64d..97fcea4acce1 100644
--- a/kernel/trace/trace_workqueue.c
+++ b/kernel/trace/trace_workqueue.c
@@ -185,16 +185,9 @@ static void *workqueue_stat_next(void *prev, int idx)
185static int workqueue_stat_show(struct seq_file *s, void *p) 185static int workqueue_stat_show(struct seq_file *s, void *p)
186{ 186{
187 struct cpu_workqueue_stats *cws = p; 187 struct cpu_workqueue_stats *cws = p;
188 unsigned long flags;
189 int cpu = cws->cpu;
190 struct pid *pid; 188 struct pid *pid;
191 struct task_struct *tsk; 189 struct task_struct *tsk;
192 190
193 spin_lock_irqsave(&workqueue_cpu_stat(cpu)->lock, flags);
194 if (&cws->list == workqueue_cpu_stat(cpu)->list.next)
195 seq_printf(s, "\n");
196 spin_unlock_irqrestore(&workqueue_cpu_stat(cpu)->lock, flags);
197
198 pid = find_get_pid(cws->pid); 191 pid = find_get_pid(cws->pid);
199 if (pid) { 192 if (pid) {
200 tsk = get_pid_task(pid, PIDTYPE_PID); 193 tsk = get_pid_task(pid, PIDTYPE_PID);