diff options
author | Tejun Heo <tj@kernel.org> | 2015-02-13 17:37:39 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-14 00:21:37 -0500 |
commit | 1a40243bae6fa0cc09cee40d51e258c725d897e6 (patch) | |
tree | 77f9ba8333dbfbefc26dbf406d71d169a14b335b /kernel/trace | |
parent | dfbcbf42dd07b649bb02b1558e2c7150c035b4dc (diff) |
tracing: use %*pb[l] to print bitmaps including cpumasks and nodemasks
printk and friends can now format bitmaps using '%*pb[l]'. cpumask
and nodemask also provide cpumask_pr_args() and nodemask_pr_args()
respectively which can be used to generate the two printf arguments
necessary to format the specified cpu/nodemask.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/trace')
-rw-r--r-- | kernel/trace/trace.c | 6 | ||||
-rw-r--r-- | kernel/trace/trace_seq.c | 2 |
2 files changed, 4 insertions, 4 deletions
diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 77b8dc528006..62c6506d663f 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c | |||
@@ -3353,12 +3353,12 @@ tracing_cpumask_read(struct file *filp, char __user *ubuf, | |||
3353 | 3353 | ||
3354 | mutex_lock(&tracing_cpumask_update_lock); | 3354 | mutex_lock(&tracing_cpumask_update_lock); |
3355 | 3355 | ||
3356 | len = cpumask_scnprintf(mask_str, count, tr->tracing_cpumask); | 3356 | len = snprintf(mask_str, count, "%*pb\n", |
3357 | if (count - len < 2) { | 3357 | cpumask_pr_args(tr->tracing_cpumask)); |
3358 | if (len >= count) { | ||
3358 | count = -EINVAL; | 3359 | count = -EINVAL; |
3359 | goto out_err; | 3360 | goto out_err; |
3360 | } | 3361 | } |
3361 | len += sprintf(mask_str + len, "\n"); | ||
3362 | count = simple_read_from_buffer(ubuf, count, ppos, mask_str, NR_CPUS+1); | 3362 | count = simple_read_from_buffer(ubuf, count, ppos, mask_str, NR_CPUS+1); |
3363 | 3363 | ||
3364 | out_err: | 3364 | out_err: |
diff --git a/kernel/trace/trace_seq.c b/kernel/trace/trace_seq.c index f8b45d8792f9..e694c9f9efa4 100644 --- a/kernel/trace/trace_seq.c +++ b/kernel/trace/trace_seq.c | |||
@@ -120,7 +120,7 @@ void trace_seq_bitmask(struct trace_seq *s, const unsigned long *maskp, | |||
120 | 120 | ||
121 | __trace_seq_init(s); | 121 | __trace_seq_init(s); |
122 | 122 | ||
123 | seq_buf_bitmask(&s->seq, maskp, nmaskbits); | 123 | seq_buf_printf(&s->seq, "%*pb", nmaskbits, maskp); |
124 | 124 | ||
125 | if (unlikely(seq_buf_has_overflowed(&s->seq))) { | 125 | if (unlikely(seq_buf_has_overflowed(&s->seq))) { |
126 | s->seq.len = save_len; | 126 | s->seq.len = save_len; |