diff options
author | Namhyung Kim <namhyung@kernel.org> | 2014-01-17 03:08:36 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2014-02-20 12:30:08 -0500 |
commit | a43b97043048eac1686f409af7ad3bb8071b9d83 (patch) | |
tree | 367ed7b0d76753cd63fe49aa731a788dcee4e9b3 /kernel/trace | |
parent | 591dffdade9f07692a7dd3ed16830ec24e901ece (diff) |
tracing/uprobes: Rename uprobe_{trace,perf}_print() functions
The uprobe_{trace,perf}_print functions are misnomers since what they
do is not printing. There's also a real print function named
print_uprobe_event() so they'll only increase confusion IMHO.
Rename them with double underscores to follow convention of kprobe.
Link: http://lkml.kernel.org/r/1389946120-19610-2-git-send-email-namhyung@kernel.org
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace')
-rw-r--r-- | kernel/trace/trace_uprobe.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 79e52d93860b..c5d2612bf233 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c | |||
@@ -758,7 +758,7 @@ static void uprobe_buffer_put(struct uprobe_cpu_buffer *ucb) | |||
758 | mutex_unlock(&ucb->mutex); | 758 | mutex_unlock(&ucb->mutex); |
759 | } | 759 | } |
760 | 760 | ||
761 | static void uprobe_trace_print(struct trace_uprobe *tu, | 761 | static void __uprobe_trace_func(struct trace_uprobe *tu, |
762 | unsigned long func, struct pt_regs *regs) | 762 | unsigned long func, struct pt_regs *regs) |
763 | { | 763 | { |
764 | struct uprobe_trace_entry_head *entry; | 764 | struct uprobe_trace_entry_head *entry; |
@@ -807,14 +807,14 @@ out: | |||
807 | static int uprobe_trace_func(struct trace_uprobe *tu, struct pt_regs *regs) | 807 | static int uprobe_trace_func(struct trace_uprobe *tu, struct pt_regs *regs) |
808 | { | 808 | { |
809 | if (!is_ret_probe(tu)) | 809 | if (!is_ret_probe(tu)) |
810 | uprobe_trace_print(tu, 0, regs); | 810 | __uprobe_trace_func(tu, 0, regs); |
811 | return 0; | 811 | return 0; |
812 | } | 812 | } |
813 | 813 | ||
814 | static void uretprobe_trace_func(struct trace_uprobe *tu, unsigned long func, | 814 | static void uretprobe_trace_func(struct trace_uprobe *tu, unsigned long func, |
815 | struct pt_regs *regs) | 815 | struct pt_regs *regs) |
816 | { | 816 | { |
817 | uprobe_trace_print(tu, func, regs); | 817 | __uprobe_trace_func(tu, func, regs); |
818 | } | 818 | } |
819 | 819 | ||
820 | /* Event entry printers */ | 820 | /* Event entry printers */ |
@@ -1014,7 +1014,7 @@ static bool uprobe_perf_filter(struct uprobe_consumer *uc, | |||
1014 | return ret; | 1014 | return ret; |
1015 | } | 1015 | } |
1016 | 1016 | ||
1017 | static void uprobe_perf_print(struct trace_uprobe *tu, | 1017 | static void __uprobe_perf_func(struct trace_uprobe *tu, |
1018 | unsigned long func, struct pt_regs *regs) | 1018 | unsigned long func, struct pt_regs *regs) |
1019 | { | 1019 | { |
1020 | struct ftrace_event_call *call = &tu->tp.call; | 1020 | struct ftrace_event_call *call = &tu->tp.call; |
@@ -1078,14 +1078,14 @@ static int uprobe_perf_func(struct trace_uprobe *tu, struct pt_regs *regs) | |||
1078 | return UPROBE_HANDLER_REMOVE; | 1078 | return UPROBE_HANDLER_REMOVE; |
1079 | 1079 | ||
1080 | if (!is_ret_probe(tu)) | 1080 | if (!is_ret_probe(tu)) |
1081 | uprobe_perf_print(tu, 0, regs); | 1081 | __uprobe_perf_func(tu, 0, regs); |
1082 | return 0; | 1082 | return 0; |
1083 | } | 1083 | } |
1084 | 1084 | ||
1085 | static void uretprobe_perf_func(struct trace_uprobe *tu, unsigned long func, | 1085 | static void uretprobe_perf_func(struct trace_uprobe *tu, unsigned long func, |
1086 | struct pt_regs *regs) | 1086 | struct pt_regs *regs) |
1087 | { | 1087 | { |
1088 | uprobe_perf_print(tu, func, regs); | 1088 | __uprobe_perf_func(tu, func, regs); |
1089 | } | 1089 | } |
1090 | #endif /* CONFIG_PERF_EVENTS */ | 1090 | #endif /* CONFIG_PERF_EVENTS */ |
1091 | 1091 | ||