diff options
author | Steven Rostedt <rostedt@goodmis.org> | 2008-05-22 00:22:16 -0400 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2008-05-26 16:39:45 -0400 |
commit | 19384c0314342222b18d4c7f09cdce1ca74dfd2a (patch) | |
tree | 9312acd07471cb89f2090f01e3259eab40de3eea /kernel/trace/trace_selftest.c | |
parent | c6531cce6e6e4b99bcda46b6268d6f2d9e30aea4 (diff) |
ftrace: limit use of check pages
The check_pages function is called often enough that it can cause problems
with trace outputs or even bringing the system to a halt.
This patch limits the check_pages to the places that are most likely to
have problems. The check is made at the flip between the global array and
the max save array, as well as when the size of the buffers changes and
the self tests.
This patch also removes the BUG_ON from check_pages and replaces it with
a WARN_ON and disabling of the tracer.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Cc: pq@iki.fi
Cc: proski@gnu.org
Cc: sandmann@redhat.com
Cc: a.p.zijlstra@chello.nl
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/trace/trace_selftest.c')
-rw-r--r-- | kernel/trace/trace_selftest.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index 3877dd9102f1..18c5423bc977 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c | |||
@@ -28,6 +28,7 @@ trace_test_buffer_cpu(struct trace_array *tr, struct trace_array_cpu *data) | |||
28 | page = list_entry(data->trace_pages.next, struct page, lru); | 28 | page = list_entry(data->trace_pages.next, struct page, lru); |
29 | entries = page_address(page); | 29 | entries = page_address(page); |
30 | 30 | ||
31 | check_pages(data); | ||
31 | if (head_page(data) != entries) | 32 | if (head_page(data) != entries) |
32 | goto failed; | 33 | goto failed; |
33 | 34 | ||