diff options
author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2014-11-12 10:29:54 -0500 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2014-11-19 15:25:39 -0500 |
commit | 19a7fe206232cc875a3083211e0a21c08edd756e (patch) | |
tree | 948aba93b9f2f6681eb7cc3209b0ec87e19470d1 /kernel/trace/trace_output.h | |
parent | e400a40cffa77e45c60c5431ec8757579247cae2 (diff) |
tracing: Add trace_seq_has_overflowed() and trace_handle_return()
Adding a trace_seq_has_overflowed() which returns true if the trace_seq
had too much written into it allows us to simplify the code.
Instead of checking the return value of every call to trace_seq_printf()
and friends, they can all be called normally, and at the end we can
return !trace_seq_has_overflowed() instead.
Several functions also return TRACE_TYPE_PARTIAL_LINE when the trace_seq
overflowed and TRACE_TYPE_HANDLED otherwise. Another helper function
was created called trace_handle_return() which takes a trace_seq and
returns these enums. Using this helper function also simplifies the
code.
This change also makes it possible to remove the return values of
trace_seq_printf() and friends. They should instead just be
void functions.
Link: http://lkml.kernel.org/r/20141114011410.365183157@goodmis.org
Reviewed-by: Petr Mladek <pmladek@suse.cz>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_output.h')
-rw-r--r-- | kernel/trace/trace_output.h | 16 |
1 files changed, 5 insertions, 11 deletions
diff --git a/kernel/trace/trace_output.h b/kernel/trace/trace_output.h index 80b25b585a70..8ef2c40efb3c 100644 --- a/kernel/trace/trace_output.h +++ b/kernel/trace/trace_output.h | |||
@@ -35,17 +35,11 @@ trace_print_lat_fmt(struct trace_seq *s, struct trace_entry *entry); | |||
35 | extern int __unregister_ftrace_event(struct trace_event *event); | 35 | extern int __unregister_ftrace_event(struct trace_event *event); |
36 | extern struct rw_semaphore trace_event_sem; | 36 | extern struct rw_semaphore trace_event_sem; |
37 | 37 | ||
38 | #define SEQ_PUT_FIELD_RET(s, x) \ | 38 | #define SEQ_PUT_FIELD(s, x) \ |
39 | do { \ | 39 | trace_seq_putmem(s, &(x), sizeof(x)) |
40 | if (!trace_seq_putmem(s, &(x), sizeof(x))) \ | 40 | |
41 | return TRACE_TYPE_PARTIAL_LINE; \ | 41 | #define SEQ_PUT_HEX_FIELD(s, x) \ |
42 | } while (0) | 42 | trace_seq_putmem_hex(s, &(x), sizeof(x)) |
43 | |||
44 | #define SEQ_PUT_HEX_FIELD_RET(s, x) \ | ||
45 | do { \ | ||
46 | if (!trace_seq_putmem_hex(s, &(x), sizeof(x))) \ | ||
47 | return TRACE_TYPE_PARTIAL_LINE; \ | ||
48 | } while (0) | ||
49 | 43 | ||
50 | #endif | 44 | #endif |
51 | 45 | ||