diff options
author | Steven Rostedt <srostedt@redhat.com> | 2010-04-22 18:46:14 -0400 |
---|---|---|
committer | Steven Rostedt <rostedt@goodmis.org> | 2010-05-14 14:20:32 -0400 |
commit | a9a5776380208a3e48a92d0c763ee1a3b486fb73 (patch) | |
tree | 5ecd41c3b373e2156f5bf748ae777e022296a30c /kernel/trace/trace_functions_graph.c | |
parent | 0405ab80aa94afb13bf9ac4a6fc9f2923d4b9114 (diff) |
tracing: Allow events to share their print functions
Multiple events may use the same method to print their data.
Instead of having all events have a pointer to their print funtions,
the trace_event structure now points to a trace_event_functions structure
that will hold the way to print ouf the event.
The event itself is now passed to the print function to let the print
function know what kind of event it should print.
This opens the door to consolidating the way several events print
their output.
text data bss dec hex filename
4913961 1088356 861512 6863829 68bbd5 vmlinux.orig
4900382 1048964 861512 6810858 67ecea vmlinux.init
4900446 1049028 861512 6810986 67ed6a vmlinux.preprint
This change slightly increases the size but is needed for the next change.
v3: Fix the branch tracer events to handle this change.
v2: Fix the new function graph tracer event calls to handle this change.
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Acked-by: Masami Hiramatsu <mhiramat@redhat.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_functions_graph.c')
-rw-r--r-- | kernel/trace/trace_functions_graph.c | 13 |
1 files changed, 9 insertions, 4 deletions
diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index dd11c830eb84..79f4bac99a94 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c | |||
@@ -1025,7 +1025,7 @@ print_graph_comment(struct trace_seq *s, struct trace_entry *ent, | |||
1025 | if (!event) | 1025 | if (!event) |
1026 | return TRACE_TYPE_UNHANDLED; | 1026 | return TRACE_TYPE_UNHANDLED; |
1027 | 1027 | ||
1028 | ret = event->trace(iter, sym_flags); | 1028 | ret = event->funcs->trace(iter, sym_flags, event); |
1029 | if (ret != TRACE_TYPE_HANDLED) | 1029 | if (ret != TRACE_TYPE_HANDLED) |
1030 | return ret; | 1030 | return ret; |
1031 | } | 1031 | } |
@@ -1112,7 +1112,8 @@ print_graph_function(struct trace_iterator *iter) | |||
1112 | } | 1112 | } |
1113 | 1113 | ||
1114 | static enum print_line_t | 1114 | static enum print_line_t |
1115 | print_graph_function_event(struct trace_iterator *iter, int flags) | 1115 | print_graph_function_event(struct trace_iterator *iter, int flags, |
1116 | struct trace_event *event) | ||
1116 | { | 1117 | { |
1117 | return print_graph_function(iter); | 1118 | return print_graph_function(iter); |
1118 | } | 1119 | } |
@@ -1225,14 +1226,18 @@ void graph_trace_close(struct trace_iterator *iter) | |||
1225 | } | 1226 | } |
1226 | } | 1227 | } |
1227 | 1228 | ||
1229 | static struct trace_event_functions graph_functions = { | ||
1230 | .trace = print_graph_function_event, | ||
1231 | }; | ||
1232 | |||
1228 | static struct trace_event graph_trace_entry_event = { | 1233 | static struct trace_event graph_trace_entry_event = { |
1229 | .type = TRACE_GRAPH_ENT, | 1234 | .type = TRACE_GRAPH_ENT, |
1230 | .trace = print_graph_function_event, | 1235 | .funcs = &graph_functions, |
1231 | }; | 1236 | }; |
1232 | 1237 | ||
1233 | static struct trace_event graph_trace_ret_event = { | 1238 | static struct trace_event graph_trace_ret_event = { |
1234 | .type = TRACE_GRAPH_RET, | 1239 | .type = TRACE_GRAPH_RET, |
1235 | .trace = print_graph_function_event, | 1240 | .funcs = &graph_functions |
1236 | }; | 1241 | }; |
1237 | 1242 | ||
1238 | static struct tracer graph_trace __read_mostly = { | 1243 | static struct tracer graph_trace __read_mostly = { |