aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/timer.c
diff options
context:
space:
mode:
authorPavel Emelianov <xemul@sw.ru>2007-05-08 03:30:19 -0400
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2007-05-08 14:15:11 -0400
commitb5e618181a927210f8be1d3d2249d31904ba358d (patch)
tree731f1ae4ff1ba56d402bb329182b7d935bb439a1 /kernel/timer.c
parentdb9c02fa8bd50eb104781a9f78cae923d8da1e74 (diff)
Introduce a handy list_first_entry macro
There are many places in the kernel where the construction like foo = list_entry(head->next, struct foo_struct, list); are used. The code might look more descriptive and neat if using the macro list_first_entry(head, type, member) \ list_entry((head)->next, type, member) Here is the macro itself and the examples of its usage in the generic code. If it will turn out to be useful, I can prepare the set of patches to inject in into arch-specific code, drivers, networking, etc. Signed-off-by: Pavel Emelianov <xemul@openvz.org> Signed-off-by: Kirill Korotaev <dev@openvz.org> Cc: Randy Dunlap <randy.dunlap@oracle.com> Cc: Andi Kleen <andi@firstfloor.org> Cc: Zach Brown <zach.brown@oracle.com> Cc: Davide Libenzi <davidel@xmailserver.org> Cc: John McCutchan <ttb@tentacle.dhs.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@elte.hu> Cc: john stultz <johnstul@us.ibm.com> Cc: Ram Pai <linuxram@us.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/timer.c')
-rw-r--r--kernel/timer.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/timer.c b/kernel/timer.c
index ba41af2bb6cc..7a6448340f90 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -629,7 +629,7 @@ static inline void __run_timers(tvec_base_t *base)
629 void (*fn)(unsigned long); 629 void (*fn)(unsigned long);
630 unsigned long data; 630 unsigned long data;
631 631
632 timer = list_entry(head->next,struct timer_list,entry); 632 timer = list_first_entry(head, struct timer_list,entry);
633 fn = timer->function; 633 fn = timer->function;
634 data = timer->data; 634 data = timer->data;
635 635
@@ -1248,7 +1248,7 @@ static void migrate_timer_list(tvec_base_t *new_base, struct list_head *head)
1248 struct timer_list *timer; 1248 struct timer_list *timer;
1249 1249
1250 while (!list_empty(head)) { 1250 while (!list_empty(head)) {
1251 timer = list_entry(head->next, struct timer_list, entry); 1251 timer = list_first_entry(head, struct timer_list, entry);
1252 detach_timer(timer, 0); 1252 detach_timer(timer, 0);
1253 timer_set_base(timer, new_base); 1253 timer_set_base(timer, new_base);
1254 internal_add_timer(new_base, timer); 1254 internal_add_timer(new_base, timer);