diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-18 11:37:41 -0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-04-18 11:37:41 -0400 |
| commit | 73e3e6481f56b3b5b618671a8d32b19a35f84316 (patch) | |
| tree | 44addba339ca1279a82d6d702e92e6cc2c183810 /kernel/time | |
| parent | 4adeaaf51ebcc3f629f5512b96aebb5089388bca (diff) | |
| parent | 6993fc5bbc5d63ccd55985b39c34417e430e75e9 (diff) | |
Merge git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt
* git://git.kernel.org/pub/scm/linux/kernel/git/tglx/linux-2.6-hrt:
clocksource: make clocksource watchdog cycle through online CPUs
Documentation: move timer related documentation to a single place
clockevents: optimise tick_nohz_stop_sched_tick() a bit
locking: remove unused double_spin_lock()
hrtimers: simplify lockdep handling
timers: simplify lockdep handling
posix-timers: fix shadowed variables
timer_list: add annotations to workqueue.c
hrtimer: use nanosleep specific restart_block fields
hrtimer: add nanosleep specific restart_block member
Diffstat (limited to 'kernel/time')
| -rw-r--r-- | kernel/time/clocksource.c | 18 | ||||
| -rw-r--r-- | kernel/time/tick-sched.c | 6 |
2 files changed, 16 insertions, 8 deletions
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c index f61402b1f2d0..73961f35fdc8 100644 --- a/kernel/time/clocksource.c +++ b/kernel/time/clocksource.c | |||
| @@ -141,8 +141,16 @@ static void clocksource_watchdog(unsigned long data) | |||
| 141 | } | 141 | } |
| 142 | 142 | ||
| 143 | if (!list_empty(&watchdog_list)) { | 143 | if (!list_empty(&watchdog_list)) { |
| 144 | __mod_timer(&watchdog_timer, | 144 | /* |
| 145 | watchdog_timer.expires + WATCHDOG_INTERVAL); | 145 | * Cycle through CPUs to check if the CPUs stay |
| 146 | * synchronized to each other. | ||
| 147 | */ | ||
| 148 | int next_cpu = next_cpu(raw_smp_processor_id(), cpu_online_map); | ||
| 149 | |||
| 150 | if (next_cpu >= NR_CPUS) | ||
| 151 | next_cpu = first_cpu(cpu_online_map); | ||
| 152 | watchdog_timer.expires += WATCHDOG_INTERVAL; | ||
| 153 | add_timer_on(&watchdog_timer, next_cpu); | ||
| 146 | } | 154 | } |
| 147 | spin_unlock(&watchdog_lock); | 155 | spin_unlock(&watchdog_lock); |
| 148 | } | 156 | } |
| @@ -164,7 +172,8 @@ static void clocksource_check_watchdog(struct clocksource *cs) | |||
| 164 | if (!started && watchdog) { | 172 | if (!started && watchdog) { |
| 165 | watchdog_last = watchdog->read(); | 173 | watchdog_last = watchdog->read(); |
| 166 | watchdog_timer.expires = jiffies + WATCHDOG_INTERVAL; | 174 | watchdog_timer.expires = jiffies + WATCHDOG_INTERVAL; |
| 167 | add_timer(&watchdog_timer); | 175 | add_timer_on(&watchdog_timer, |
| 176 | first_cpu(cpu_online_map)); | ||
| 168 | } | 177 | } |
| 169 | } else { | 178 | } else { |
| 170 | if (cs->flags & CLOCK_SOURCE_IS_CONTINUOUS) | 179 | if (cs->flags & CLOCK_SOURCE_IS_CONTINUOUS) |
| @@ -185,7 +194,8 @@ static void clocksource_check_watchdog(struct clocksource *cs) | |||
| 185 | watchdog_last = watchdog->read(); | 194 | watchdog_last = watchdog->read(); |
| 186 | watchdog_timer.expires = | 195 | watchdog_timer.expires = |
| 187 | jiffies + WATCHDOG_INTERVAL; | 196 | jiffies + WATCHDOG_INTERVAL; |
| 188 | add_timer(&watchdog_timer); | 197 | add_timer_on(&watchdog_timer, |
| 198 | first_cpu(cpu_online_map)); | ||
| 189 | } | 199 | } |
| 190 | } | 200 | } |
| 191 | } | 201 | } |
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 686da821d376..69dba0c71727 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c | |||
| @@ -158,9 +158,8 @@ void tick_nohz_stop_idle(int cpu) | |||
| 158 | } | 158 | } |
| 159 | } | 159 | } |
| 160 | 160 | ||
| 161 | static ktime_t tick_nohz_start_idle(int cpu) | 161 | static ktime_t tick_nohz_start_idle(struct tick_sched *ts) |
| 162 | { | 162 | { |
| 163 | struct tick_sched *ts = &per_cpu(tick_cpu_sched, cpu); | ||
| 164 | ktime_t now, delta; | 163 | ktime_t now, delta; |
| 165 | 164 | ||
| 166 | now = ktime_get(); | 165 | now = ktime_get(); |
| @@ -201,8 +200,8 @@ void tick_nohz_stop_sched_tick(void) | |||
| 201 | local_irq_save(flags); | 200 | local_irq_save(flags); |
| 202 | 201 | ||
| 203 | cpu = smp_processor_id(); | 202 | cpu = smp_processor_id(); |
| 204 | now = tick_nohz_start_idle(cpu); | ||
| 205 | ts = &per_cpu(tick_cpu_sched, cpu); | 203 | ts = &per_cpu(tick_cpu_sched, cpu); |
| 204 | now = tick_nohz_start_idle(ts); | ||
| 206 | 205 | ||
| 207 | /* | 206 | /* |
| 208 | * If this cpu is offline and it is the one which updates | 207 | * If this cpu is offline and it is the one which updates |
| @@ -222,7 +221,6 @@ void tick_nohz_stop_sched_tick(void) | |||
| 222 | if (need_resched()) | 221 | if (need_resched()) |
| 223 | goto end; | 222 | goto end; |
| 224 | 223 | ||
| 225 | cpu = smp_processor_id(); | ||
| 226 | if (unlikely(local_softirq_pending())) { | 224 | if (unlikely(local_softirq_pending())) { |
| 227 | static int ratelimit; | 225 | static int ratelimit; |
| 228 | 226 | ||
