diff options
author | Lin Ming <ming.m.lin@intel.com> | 2009-11-17 00:49:50 -0500 |
---|---|---|
committer | Thomas Gleixner <tglx@linutronix.de> | 2009-11-17 05:52:34 -0500 |
commit | 0696b711e4be45fa104c12329f617beb29c03f78 (patch) | |
tree | 96292fdc4ab443d6218077d363548532df6cbd8b /kernel/time/timekeeping.c | |
parent | a9366e61b03f55a6e009e687ad10e706714c9907 (diff) |
timekeeping: Fix clock_gettime vsyscall time warp
Since commit 0a544198 "timekeeping: Move NTP adjusted clock multiplier
to struct timekeeper" the clock multiplier of vsyscall is updated with
the unmodified clock multiplier of the clock source and not with the
NTP adjusted multiplier of the timekeeper.
This causes user space observerable time warps:
new CLOCK-warp maximum: 120 nsecs, 00000025c337c537 -> 00000025c337c4bf
Add a new argument "mult" to update_vsyscall() and hand in the
timekeeping internal NTP adjusted multiplier.
Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Cc: "Zhang Yanmin" <yanmin_zhang@linux.intel.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tony Luck <tony.luck@intel.com>
LKML-Reference: <1258436990.17765.83.camel@minggr.sh.intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/time/timekeeping.c')
-rw-r--r-- | kernel/time/timekeeping.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c index c3a4e2907eaa..2a6d3e3e2c3e 100644 --- a/kernel/time/timekeeping.c +++ b/kernel/time/timekeeping.c | |||
@@ -177,7 +177,7 @@ void timekeeping_leap_insert(int leapsecond) | |||
177 | { | 177 | { |
178 | xtime.tv_sec += leapsecond; | 178 | xtime.tv_sec += leapsecond; |
179 | wall_to_monotonic.tv_sec -= leapsecond; | 179 | wall_to_monotonic.tv_sec -= leapsecond; |
180 | update_vsyscall(&xtime, timekeeper.clock); | 180 | update_vsyscall(&xtime, timekeeper.clock, timekeeper.mult); |
181 | } | 181 | } |
182 | 182 | ||
183 | #ifdef CONFIG_GENERIC_TIME | 183 | #ifdef CONFIG_GENERIC_TIME |
@@ -337,7 +337,7 @@ int do_settimeofday(struct timespec *tv) | |||
337 | timekeeper.ntp_error = 0; | 337 | timekeeper.ntp_error = 0; |
338 | ntp_clear(); | 338 | ntp_clear(); |
339 | 339 | ||
340 | update_vsyscall(&xtime, timekeeper.clock); | 340 | update_vsyscall(&xtime, timekeeper.clock, timekeeper.mult); |
341 | 341 | ||
342 | write_sequnlock_irqrestore(&xtime_lock, flags); | 342 | write_sequnlock_irqrestore(&xtime_lock, flags); |
343 | 343 | ||
@@ -811,7 +811,7 @@ void update_wall_time(void) | |||
811 | update_xtime_cache(nsecs); | 811 | update_xtime_cache(nsecs); |
812 | 812 | ||
813 | /* check to see if there is a new clocksource to use */ | 813 | /* check to see if there is a new clocksource to use */ |
814 | update_vsyscall(&xtime, timekeeper.clock); | 814 | update_vsyscall(&xtime, timekeeper.clock, timekeeper.mult); |
815 | } | 815 | } |
816 | 816 | ||
817 | /** | 817 | /** |