aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/signal.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@tv-sign.ru>2008-02-06 04:36:13 -0500
committerLinus Torvalds <torvalds@woody.linux-foundation.org>2008-02-06 13:41:00 -0500
commitd9ae90ac4bdce769ddb27c2e24c3351a30c3daf8 (patch)
tree220f88576b5c83369892ce13cb180bab6cccba7a /kernel/signal.c
parent06b8e878a9bc9301201cffe186eba99c4185f20a (diff)
use __set_task_state() for TRACED/STOPPED tasks
1. It is much easier to grep for ->state change if __set_task_state() is used instead of the direct assignment. 2. ptrace_stop() and handle_group_stop() use set_task_state() which adds the unneeded mb() (btw even if we use mb() it is still possible that do_wait() sees the new ->state but not ->exit_code, but this is ok). Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru> Acked-by: Roland McGrath <roland@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/signal.c')
-rw-r--r--kernel/signal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/signal.c b/kernel/signal.c
index 6a5f97cd337a..e46971560fcb 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -1601,7 +1601,7 @@ static void ptrace_stop(int exit_code, int nostop_code, siginfo_t *info)
1601 current->exit_code = exit_code; 1601 current->exit_code = exit_code;
1602 1602
1603 /* Let the debugger run. */ 1603 /* Let the debugger run. */
1604 set_current_state(TASK_TRACED); 1604 __set_current_state(TASK_TRACED);
1605 spin_unlock_irq(&current->sighand->siglock); 1605 spin_unlock_irq(&current->sighand->siglock);
1606 try_to_freeze(); 1606 try_to_freeze();
1607 read_lock(&tasklist_lock); 1607 read_lock(&tasklist_lock);