diff options
author | Peter Zijlstra <a.p.zijlstra@chello.nl> | 2008-02-29 15:21:01 -0500 |
---|---|---|
committer | Ingo Molnar <mingo@elte.hu> | 2008-03-07 10:42:59 -0500 |
commit | 810b38179e9e4d4f57b4b733767bb08f8291a965 (patch) | |
tree | 91692de4fbd46879b29d803839b5bf7e25f30cd8 /kernel/sched_fair.c | |
parent | ce4796d1e16cf3761dc2a02b8d588667d05b3078 (diff) |
sched: retain vruntime
Kei Tokunaga reported an interactivity problem when moving tasks
between control groups.
Tasks would retain their old vruntime when moved between groups, this
can cause funny lags. Re-set the vruntime on group move to fit within
the new tree.
Reported-by: Kei Tokunaga <tokunaga.keiich@jp.fujitsu.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'kernel/sched_fair.c')
-rw-r--r-- | kernel/sched_fair.c | 14 |
1 files changed, 14 insertions, 0 deletions
diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c index 3df4d46994ca..e2a530515619 100644 --- a/kernel/sched_fair.c +++ b/kernel/sched_fair.c | |||
@@ -1353,6 +1353,16 @@ static void set_curr_task_fair(struct rq *rq) | |||
1353 | set_next_entity(cfs_rq_of(se), se); | 1353 | set_next_entity(cfs_rq_of(se), se); |
1354 | } | 1354 | } |
1355 | 1355 | ||
1356 | #ifdef CONFIG_FAIR_GROUP_SCHED | ||
1357 | static void moved_group_fair(struct task_struct *p) | ||
1358 | { | ||
1359 | struct cfs_rq *cfs_rq = task_cfs_rq(p); | ||
1360 | |||
1361 | update_curr(cfs_rq); | ||
1362 | place_entity(cfs_rq, &p->se, 1); | ||
1363 | } | ||
1364 | #endif | ||
1365 | |||
1356 | /* | 1366 | /* |
1357 | * All the scheduling class methods: | 1367 | * All the scheduling class methods: |
1358 | */ | 1368 | */ |
@@ -1381,6 +1391,10 @@ static const struct sched_class fair_sched_class = { | |||
1381 | 1391 | ||
1382 | .prio_changed = prio_changed_fair, | 1392 | .prio_changed = prio_changed_fair, |
1383 | .switched_to = switched_to_fair, | 1393 | .switched_to = switched_to_fair, |
1394 | |||
1395 | #ifdef CONFIG_FAIR_GROUP_SCHED | ||
1396 | .moved_group = moved_group_fair, | ||
1397 | #endif | ||
1384 | }; | 1398 | }; |
1385 | 1399 | ||
1386 | #ifdef CONFIG_SCHED_DEBUG | 1400 | #ifdef CONFIG_SCHED_DEBUG |