aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/sched
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2014-05-23 06:20:42 -0400
committerIngo Molnar <mingo@kernel.org>2014-06-05 05:52:13 -0400
commitfa93384f40deeb294fd29f2fdcadbd0ebc2dedf1 (patch)
tree7948bf37a7b399f753937a311488b3f23b01622e /kernel/sched
parent2538d960d0c74cdc639f05723e04a67aed1efdf9 (diff)
sched: Fix signedness bug in yield_to()
yield_to() is supposed to return -ESRCH if there is no task to yield to, but because the type is bool that is the same as returning true. The only place I see which cares is kvm_vcpu_on_spin(). Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Raghavendra <raghavendra.kt@linux.vnet.ibm.com> Signed-off-by: Peter Zijlstra <peterz@infradead.org> Cc: Gleb Natapov <gleb@kernel.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: kvm@vger.kernel.org Link: http://lkml.kernel.org/r/20140523102042.GA7267@mwanda Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/sched')
-rw-r--r--kernel/sched/core.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 321d800e4baa..afcc84234a3e 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -4195,7 +4195,7 @@ EXPORT_SYMBOL(yield);
4195 * false (0) if we failed to boost the target. 4195 * false (0) if we failed to boost the target.
4196 * -ESRCH if there's no task to yield to. 4196 * -ESRCH if there's no task to yield to.
4197 */ 4197 */
4198bool __sched yield_to(struct task_struct *p, bool preempt) 4198int __sched yield_to(struct task_struct *p, bool preempt)
4199{ 4199{
4200 struct task_struct *curr = current; 4200 struct task_struct *curr = current;
4201 struct rq *rq, *p_rq; 4201 struct rq *rq, *p_rq;